Skip to content

Address code review feedback: fix indentation and complete RAII migration#1104

Closed
Copilot wants to merge 1 commit intofeature/VPLAY-12070_segfault_in_ScheduleRetune_callback-follow-upfrom
copilot/sub-pr-1098
Closed

Address code review feedback: fix indentation and complete RAII migration#1104
Copilot wants to merge 1 commit intofeature/VPLAY-12070_segfault_in_ScheduleRetune_callback-follow-upfrom
copilot/sub-pr-1098

Conversation

Copy link
Contributor

Copilot AI commented Mar 2, 2026

Addresses feedback on PR #1098 regarding indentation inconsistencies and completion of RAII-based mutex management for mStreamMutex.

Changes

  • Fixed indentation in EnableContentRestrictions(): Corrected else block at lines 12164-12168 where mApplyContentRestriction = true; was improperly indented
  • Fixed indentation in SetPreferredLanguages(): Corrected nested else block indentation around line 12776
  • Removed deprecated mutex APIs: Deleted AcquireStreamLock(), TryStreamLock(), and ReleaseStreamLock() from priv_aamp.cpp, priv_aamp.h, and test infrastructure
  • Fixed memory management: Changed free() to cJSON_free() for cJSON-allocated strings in GetThumbnailTracks()

Example

Before (incorrect indentation):

else
{
    AAMPLOG_INFO("mpStreamAbstractionAAMP is not Ready, %d", state);
mApplyContentRestriction = true;  // Wrong indent level
}

After (correct indentation):

else
{
    AAMPLOG_INFO("mpStreamAbstractionAAMP is not Ready, %d", state);
    mApplyContentRestriction = true;  // Properly indented with tabs
}

All mutex operations now use RAII patterns (std::lock_guard, std::unique_lock) exclusively.


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Copilot AI changed the title [WIP] WIP address feedback on VPLAY-12838 RAII for mStreamMutex Address code review feedback: fix indentation and complete RAII migration Mar 2, 2026
@pstroffolino pstroffolino deleted the copilot/sub-pr-1098 branch March 5, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants