VPLAY-12884 Crash from teardown on HDCP error#1227
VPLAY-12884 Crash from teardown on HDCP error#1227jameslofthouse-RED wants to merge 1 commit intodev_sprint_25_2from
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a crash during teardown triggered by a GStreamer HDCP protection error by avoiding an immediate flush/teardown while injection may still be active, and instead relying on retune to reset playback state safely.
Changes:
- Stop calling
Flush(..., shouldTearDown=true)onHDCPProtectionFailureapplication bus messages. - Mute video and schedule a retune when
HDCPProtectionFailureis received.
aampgstplayer.cpp
Outdated
| _this->Flush(0, AAMP_NORMAL_PLAY_RATE, true); | ||
| // Do not flush(teardown) here as injection threads may still be running | ||
| // Allow retune to reset everything | ||
| // _this->Flush(0, AAMP_NORMAL_PLAY_RATE, true); |
There was a problem hiding this comment.
Please avoid leaving commented-out production code here. Instead of commenting out the Flush(teardown) call, remove it and keep only the explanatory comment (or replace it with an explicit, safe alternative such as pausing injection before teardown if a flush is still required). Keeping disabled code in-line makes future maintenance and auditing harder and can mask regressions.
| // _this->Flush(0, AAMP_NORMAL_PLAY_RATE, true); |
aampgstplayer.cpp
Outdated
| // Do not flush(teardown) here as injection threads may still be running | ||
| // Allow retune to reset everything |
There was a problem hiding this comment.
The newly added comment lines aren’t indented consistently with the surrounding block (tab-indented). Please indent them to match the existing formatting so the block stays readable.
| // Do not flush(teardown) here as injection threads may still be running | |
| // Allow retune to reset everything | |
| // Do not flush(teardown) here as injection threads may still be running | |
| // Allow retune to reset everything |
Reason for change: On processing a gst HDCP error, flush with teardown is called without
stopping stream injection leading to an abort
Test Procedure: See ticket
Risks: low
Signed-off-by: James Lofthouse <james_lofthouse@comcast.com>
jameslofthouse-RED
force-pushed
the
feature/VPLAY-12884_remove_flush_on_HDCP_error
branch
from
e3c3710 to
d8b237a
Compare
jameslofthouse-RED
changed the title
Reason for change: On processing a gst HDCP error, flush with teardown is called without
stopping stream injection leading to an abort
Test Procedure: See ticket
Risks: low