Skip to content

VPLAY-11886: Rate correction is enabled during RW on LLD #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
psiva01 wants to merge 4 commits into
base: dev_sprint_25_2
Choose a base branch
from
+1 −1
Open

VPLAY-11886: Rate correction is enabled during RW on LLD #724

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
68f87fc
VPLAY-11886: Rate correction is enabled during RW on LLD
psiva01 Dec 2, 2025
d1f3637
VPLAY-11886: Revert back L1 changes
psiva01 Dec 3, 2025
68bd0a1
Merge branch 'dev_sprint_25_2' into feature/VPLAY-11886
psiva01 Dec 3, 2025
0c3a152
Merge branch 'dev_sprint_25_2' into feature/VPLAY-11886
psiva01 Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fragmentcollector_mpd.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3503,7 +3503,7 @@ AAMPStatusType StreamAbstractionAAMP_MPD::Init(TuneType tuneType)
liveAdjust = true;
notifyEnteringLive = true;
}
else if (((eTUNETYPE_SEEK == tuneType) || (eTUNETYPE_RETUNE == tuneType || eTUNETYPE_NEW_SEEK == tuneType)) && (currentRate > AAMP_RATE_PAUSE))
else if (((eTUNETYPE_SEEK == tuneType) || (eTUNETYPE_RETUNE == tuneType || eTUNETYPE_NEW_SEEK == tuneType)) && (currentRate != AAMP_RATE_PAUSE))
Copy link
Contributor

@nu641001 nu641001 Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, the logic used aamp->rate, but after the localTSB integration, it shifted to currentRate which sets PAUSE to stream abstraction object if pipelinePaused, but in actual PAUSE, aamp->rate remains AAMP_NORMAL_RATE and the pipelinePaused flag is set. Is it acceptable to keep using aamp->rate > AAMP_RATE_PAUSE? With the recent fix, the scope of this else if now also includes rewind scenarios—correct?

Copy link
Contributor

@jfagunde jfagunde Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nu641001 ,
currentRate is a local variable set to aamp->rate in line 3198
Before merging https://github.com/rdkcentral/aamp/pull/649/files#diff-9412049d3685e68289ccd0b5e0a718c64d26b9a783882ba14700abd57e136be3, this function was using mPlayRate (which is always 1 when using AAMP TSB, see VPLAY-11583). Is that what you mean?

Copy link
Contributor

@nu641001 nu641001 Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @jfagunde Now I see where the confusion came from. The rate in StreamAbstraction essentially mirrors the value in aamp->rate. Since aamp->rate never transitions to a PAUSED state, the check for rate != PAUSE doesn’t really apply here. We can safely remove that condition to avoid any future ambiguity.

{
double seekWindowEnd = duration - aamp->mLiveOffset;
// check if seek beyond live point
Expand Down
Loading