VPLAY-11918 process id logging minor cleanup #730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason for Change: incorporating some copilot recommendations including: - cast pid_t to int while printing - log as "PID:" instead of "process:" Signed-off-by: Philip Stroffolino <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs minor cleanup on process ID logging in the AAMP CLI by improving the format and casting approach for pid_t.
Key Changes:
- Reordered
#include <unistd.h>to follow project headers (after "Aampcli.h" and "scte35/AampSCTE35.h") - Changed logging label from "process:" to "PID:" for clarity
- Updated format specifier and cast from implicit to explicit (
static_cast<long>with%ld)
Copilot finished reviewing on behalf of
pstroffolino
December 3, 2025 20:07
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change: incorporating some copilot recommendations including: