Skip to content

RDKCOM-5547: RDKBNETWOR-84 DSLite feature integration with WanManager (Wg network… #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devinmungan wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

RDKCOM-5547: RDKBNETWOR-84 DSLite feature integration with WanManager (Wg network… #52

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d815f65
RDKBNETWOR-84: DSLite feature integration with WanManager (Wg network…
devinmungan Nov 27, 2025
5eab890
Merge branch 'develop' into develop
Sukanya673 Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions source/ccsp/components/include/ipc_msg.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,7 @@ typedef struct _DHCP_MGR_IPV6_MSG
bool maptAssigned;
bool mapeAssigned;
ipc_map_data_t map;
Comment on lines 258 to 260
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The map field and its associated boolean flags (maptAssigned, mapeAssigned) are now unconditionally present in DHCP_MGR_IPV6_MSG. However, the corresponding field in ipc_dhcpv6_data_t structure (line 181) still guards the map data with preprocessor directives (FEATURE_MAPT || MAPT_UNIFICATION_ENABLED). This inconsistency means that when FEATURE_MAPT and MAPT_UNIFICATION_ENABLED are not defined, ipc_dhcpv6_data_t won't have the mapt field but DHCP_MGR_IPV6_MSG will have the map field. This could lead to confusion and potential compilation issues when translating between these structures. Either both structures should unconditionally include the MAP-related fields, or both should use the same conditional compilation guards.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The field name has been changed from 'mapt' to 'map' in the DHCP_MGR_IPV6_MSG structure, but the corresponding field in the ipc_dhcpv6_data_t structure (line 181) is still named 'mapt'. This naming inconsistency is confusing and makes the codebase harder to maintain. Both structures now use ipc_map_data_t and should use consistent field naming.

Suggested change
ipc_map_data_t map;
ipc_map_data_t mapt;

Copilot uses AI. Check for mistakes.
char aftr[BUFLEN_256];
} DHCP_MGR_IPV6_MSG;

typedef enum {
Expand Down
Loading