RDKEMW-9843: report loaded and unloaded voltage from RCU #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tage loaded, unloaded, and percentage in remote control service.
Contributor
egalla204
requested changes
Dec 10, 2025
src/ble/hal/blercu/bleservices/gatt/gatt_remotecontrolservice.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
This PR implements support for tracking battery voltage information from the Remote Control Unit (RCU). It adds a new BLE characteristic to report loaded voltage, unloaded voltage, and battery percentage from the remote control device.
Key changes:
- Adds a new
RawBatteryVoltageBLE characteristic UUID (0xed08) for reading battery voltage data - Implements voltage parsing logic that interprets 8-bit values as voltage measurements (upper 2 bits for whole volts, lower 6 bits for fractional increments)
- Integrates voltage tracking into the remote control service lifecycle with proper initialization, request handling, and cleanup
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ble/hal/utils/bleuuid.h | Adds the RawBatteryVoltage characteristic UUID enum value |
| src/ble/hal/utils/bleuuid.cpp | Registers the human-readable name for the RawBatteryVoltage characteristic |
| src/ble/hal/blercu/bleservices/gatt/gatt_remotecontrolservice.h | Declares new methods, member variables, and characteristic pointer for handling raw battery voltage |
| src/ble/hal/blercu/bleservices/gatt/gatt_remotecontrolservice.cpp | Implements voltage request handling, parsing logic, and integrates into service lifecycle |
| src/ble/hal/blercu/bleservices/blercuremotecontrolservice.h | Adds slot registration method for battery voltage change notifications |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/ble/hal/blercu/bleservices/gatt/gatt_remotecontrolservice.cpp
Outdated
Show resolved
Hide resolved
src/ble/hal/blercu/bleservices/gatt/gatt_remotecontrolservice.cpp
Outdated
Show resolved
Hide resolved
msmith113
changed the title
Co-authored-by: Gene Gallagher <129112619+egalla204@users.noreply.github.com>
Contributor
see RDKEMW-11249 or CHANGELOG for release notes
Contributor
Contributor
Contributor
msmith113
force-pushed
the
feature/RDKEMW-9843
branch
from
3c612fe to
251ce7c
Compare
Contributor
egalla204
approved these changes
Jan 21, 2026
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RDKEMW-9843
Now tracks voltage loaded, unloaded, and percentage in remote control service.