[poc]Cpesp 7136 extern by santoshcomcast · Pull Request #143 · rdkcentral/devicesettings

santoshcomcast · 2025-09-10T13:31:59Z

No description provided.

Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

rdkcmf-jenkins · 2025-09-10T13:42:22Z

ds/audioOutputPortConfig.cpp

+		}
+	printf("\n\n=========================================================================================================================\n\n");
+
+


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Incorrect sizeof expression

The expression "sizeof (kPort_audio) / sizeof (kPort_audio[0])" is suspicious. Note that "kPort_audio" is a pointer and therefore the division will not return the number of array elements which may have been the intent.

Medium Impact, CWE-467
BAD_SIZEOF

rdkcmf-jenkins · 2025-09-10T13:42:22Z

ds/audioOutputPortConfig.cpp

+			printf("%d:%s: typeCfg->typeId = %d\n", __LINE__, __func__, typeCfg->typeId);
+			printf("%d:%s: typeCfg->name = %s\n", __LINE__, __func__, typeCfg->name);
+			printf("%d:%s: typeCfg->numSupportedEncodings = %zu\n", __LINE__, __func__, typeCfg->numSupportedEncodings);
+			printf("%d:%s: typeCfg->numSupportedCompressions = %zu\n", __LINE__, __func__, typeCfg->numSupportedCompressions);


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Incorrect sizeof expression

The expression "sizeof (kConfigs1) / sizeof (kConfigs1[0])" is suspicious. Note that "kConfigs1" is a pointer and therefore the division will not return the number of array elements which may have been the intent.

Medium Impact, CWE-467
BAD_SIZEOF

rdkcmf-jenkins · 2025-09-10T13:42:22Z

ds/audioOutputPortConfig.cpp

+			printf("%d:%s: typeCfg->typeId = %d\n", __LINE__, __func__, typeCfg->typeId);
+			printf("%d:%s: typeCfg->name = %s\n", __LINE__, __func__, typeCfg->name);
+			printf("%d:%s: typeCfg->numSupportedEncodings = %zu\n", __LINE__, __func__, typeCfg->numSupportedEncodings);
+			printf("%d:%s: typeCfg->numSupportedCompressions = %zu\n", __LINE__, __func__, typeCfg->numSupportedCompressions);


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Incorrect sizeof expression

The expression "sizeof (kConfig_audio) / sizeof (kConfig_audio[0])" is suspicious. Note that "kConfig_audio" is a pointer and therefore the division will not return the number of array elements which may have been the intent.

Medium Impact, CWE-467
BAD_SIZEOF

rdkcmf-jenkins · 2025-09-10T13:42:22Z

ds/audioOutputPortConfig.cpp

+		}
+	printf("\n\n=========================================================================================================================\n\n");
+
+	printf("\n\n=========================================================================================================================\n\n");


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Incorrect sizeof expression

The expression "sizeof (kPorts1) / sizeof (kPorts1[0])" is suspicious. Note that "kPorts1" is a pointer and therefore the division will not return the number of array elements which may have been the intent.

Medium Impact, CWE-467
BAD_SIZEOF

rdkcmf-jenkins · 2025-09-10T13:42:22Z

ds/audioOutputPortConfig.cpp

+			printf("%d:%s: typeCfg->typeId = %d\n", __LINE__, __func__, typeCfg->typeId);
+			printf("%d:%s: typeCfg->name = %s\n", __LINE__, __func__, typeCfg->name);
+			printf("%d:%s: typeCfg->numSupportedEncodings = %zu\n", __LINE__, __func__, typeCfg->numSupportedEncodings);
+			printf("%d:%s: typeCfg->numSupportedCompressions = %zu\n", __LINE__, __func__, typeCfg->numSupportedCompressions);


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Unsigned compared against 0

This less-than-zero comparison of an unsigned value is never true. "i < 0UL".

Medium Impact, CWE-570
NO_EFFECT

Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

rdkcmf-jenkins · 2025-09-11T07:51:58Z

ds/audioOutputPortConfig.cpp

+			printf("%d:%s: typeCfg->typeId = %d\n", __LINE__, __func__, typeCfg->typeId);
+			printf("%d:%s: typeCfg->name = %s\n", __LINE__, __func__, typeCfg->name);
+			printf("%d:%s: typeCfg->numSupportedEncodings = %zu\n", __LINE__, __func__, typeCfg->numSupportedEncodings);
+			printf("%d:%s: typeCfg->numSupportedCompressions = %zu\n", __LINE__, __func__, typeCfg->numSupportedCompressions);


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Negative loop bound

Using unsigned variable "kConfig_size_local" in a loop exit condition.

Medium Impact, CWE-606
NEGATIVE_RETURNS

rdkcmf-jenkins · 2025-09-11T07:51:58Z

ds/audioOutputPortConfig.cpp

+		}
+	printf("\n\n=========================================================================================================================\n\n");
+	#else
+	printf("\n\n=========================================================================================================================\n\n");


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Negative loop bound

Using unsigned variable "kPort_size_local" in a loop exit condition.

Medium Impact, CWE-606
NEGATIVE_RETURNS

rdkcmf-jenkins · 2025-09-11T07:51:58Z

ds/audioOutputPortConfig.cpp

+			pKConSize = (int *) dlsym(dllib, "kConfig_size");
+			pKPortSize = (int *) dlsym(dllib, "kPort_size");
+			if(pKConSize)
+			{


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Double unlock

"pthread_mutex_unlock" unlocks "dsLock" while it is unlocked.

Medium Impact, CWE-765
LOCK

rdkcmf-jenkins · 2025-09-11T07:51:58Z

ds/audioOutputPortConfig.cpp

+            dlclose(dllib);
+        }
+        else {
+            INT_ERROR("Opening libdshalsrv.so failed\r\n");


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Double unlock

"pthread_mutex_unlock" unlocks "dsLock" while it is unlocked.

Medium Impact, CWE-765
LOCK

rdkcmf-jenkins · 2025-09-11T07:51:58Z

ds/audioOutputPortConfig.cpp

+            dlclose(dllib);
+        }
+        else {
+            INT_ERROR("Opening libdshalsrv.so failed\r\n");


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Double unlock

"pthread_mutex_unlock" unlocks "dsLock" while it is unlocked.

Medium Impact, CWE-765
LOCK

rdkcmf-jenkins · 2025-09-11T07:51:59Z

ds/audioOutputPortConfig.cpp

+	#if 1
+	printf("\n\n=========================================================================================================================\n\n");
+	printf("\n%d:%s print configs dlsym\n", __LINE__, __func__);
+


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Double unlock

"pthread_mutex_unlock" unlocks "dsLock" while it is unlocked.

Medium Impact, CWE-765
LOCK

rdkcmf-jenkins · 2025-09-11T07:51:59Z

ds/audioOutputPortConfig.cpp

+	#if 1
+	printf("\n\n=========================================================================================================================\n\n");
+	printf("\n%d:%s print configs dlsym\n", __LINE__, __func__);
+


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Double unlock

"pthread_mutex_unlock" unlocks "dsLock" while it is unlocked.

Medium Impact, CWE-765
LOCK

rdkcmf-jenkins · 2025-09-11T07:51:59Z

ds/audioOutputPortConfig.cpp

+			printf("%d:%s: typeCfg->name = %s\n", __LINE__, __func__, typeCfg->name);
+			printf("%d:%s: typeCfg->numSupportedEncodings = %zu\n", __LINE__, __func__, typeCfg->numSupportedEncodings);
+			printf("%d:%s: typeCfg->numSupportedCompressions = %zu\n", __LINE__, __func__, typeCfg->numSupportedCompressions);
+			printf("%d:%s: typeCfg->numSupportedStereoModes = %zu\n", __LINE__, __func__, typeCfg->numSupportedStereoModes);


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Data race condition

Accessing "kConfigs1" without holding lock "dsLock". Elsewhere, "kConfigs1" is written to with "dsLock" held 1 out of 1 times.

Medium Impact, CWE-366
MISSING_LOCK

rdkcmf-jenkins · 2025-09-11T07:51:59Z

ds/audioOutputPortConfig.cpp

+	printf("\n\n=========================================================================================================================\n\n");
+	printf("\n%d:%s print configs dlsym\n", __LINE__, __func__);
+
+	for (size_t i = 0; i < kConfig_size_local; i++) {


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Incorrect sizeof expression

The expression "sizeof (kConfigs1) / sizeof (kConfigs1[0])" is suspicious. Note that "kConfigs1" is a pointer and therefore the division will not return the number of array elements which may have been the intent.

Medium Impact, CWE-467
BAD_SIZEOF

rdkcmf-jenkins · 2025-09-11T07:51:59Z

ds/audioOutputPortConfig.cpp

+	printf("\n%d:%s print configs dlsym\n", __LINE__, __func__);
+
+	for (size_t i = 0; i < kConfig_size_local; i++) {
+			const dsAudioTypeConfig_t *typeCfg = &kConfigs1[i];


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Incorrect sizeof expression

The expression "sizeof (kPorts1) / sizeof (kPorts1[0])" is suspicious. Note that "kPorts1" is a pointer and therefore the division will not return the number of array elements which may have been the intent.

Medium Impact, CWE-467
BAD_SIZEOF

Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

rdkcmf-jenkins · 2025-09-11T09:04:52Z

ds/audioOutputPortConfig.cpp

+	#if 1
+	printf("\n\n=========================================================================================================================\n\n");
+	printf("\n%d:%s print configs dlsym\n", __LINE__, __func__);
+


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Double unlock

"pthread_mutex_unlock" unlocks "dsLock" while it is unlocked.

Medium Impact, CWE-765
LOCK

Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

rdkcmf-jenkins · 2025-09-12T07:24:11Z

ds/audioOutputPortConfig.cpp

+			aPortType.enable();
+			printf("%d:%s: typeCfg->typeId = %d\n", __LINE__, __func__, typeCfg->typeId);
+			printf("%d:%s: typeCfg->name = %s\n", __LINE__, __func__, typeCfg->name);
+			printf("%d:%s: typeCfg->numSupportedEncodings = %zu\n", __LINE__, __func__, typeCfg->numSupportedEncodings);


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Negative loop bound

Using unsigned variable "kConfig_size_local" in a loop exit condition.

Medium Impact, CWE-606
NEGATIVE_RETURNS

rdkcmf-jenkins · 2025-09-12T07:24:11Z

ds/audioOutputPortConfig.cpp

+			printf("%d:%s: port->id.index = %d\n", __LINE__, __func__, port->id.index);
+		}
+	}
+	else


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Negative loop bound

Using unsigned variable "kPort_size_local" in a loop exit condition.

Medium Impact, CWE-606
NEGATIVE_RETURNS

Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

santoshcomcast added 3 commits September 10, 2025 09:55

POC: read the variable through dlsym utlity.

bec9c03

read variable through dlsym utility

a1ce0dd

Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

debug extern from lib

34ef765

santoshcomcast requested a review from a team as a code owner September 10, 2025 13:32

santoshcomcast requested a review from a team September 10, 2025 13:32

rdkcmf-jenkins reviewed Sep 10, 2025

View reviewed changes

debug poc

7deaac8

Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

rdkcmf-jenkins reviewed Sep 11, 2025

View reviewed changes

debug poc

adf06cc

Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

rdkcmf-jenkins reviewed Sep 11, 2025

View reviewed changes

debug poc

eb49b4a

Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

rdkcmf-jenkins reviewed Sep 12, 2025

View reviewed changes

santoshcomcast added 4 commits September 12, 2025 12:57

debug poc

1de2bef

Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

debug build issue

4e473dd

Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

debug poc

1211fad

Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

debug poc

0521d96

Signed-off-by: grandhi_santoshkumar <grandhi_santoshkumar@comcast.com>

rdkcentral deleted a comment from rdkcmf-jenkins Oct 29, 2025

		}
		printf("\n\n=========================================================================================================================\n\n");

Conversation

santoshcomcast commented Sep 10, 2025

Uh oh!

rdkcmf-jenkins Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Incorrect sizeof expression

Uh oh!

rdkcmf-jenkins Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Incorrect sizeof expression

Uh oh!

rdkcmf-jenkins Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Incorrect sizeof expression

Uh oh!

rdkcmf-jenkins Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Incorrect sizeof expression

Uh oh!

rdkcmf-jenkins Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unsigned compared against 0

Uh oh!

rdkcmf-jenkins Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Negative loop bound

Uh oh!

rdkcmf-jenkins Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Negative loop bound

Uh oh!

rdkcmf-jenkins Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Double unlock

Uh oh!

rdkcmf-jenkins Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Double unlock

Uh oh!

rdkcmf-jenkins Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Double unlock

Uh oh!

rdkcmf-jenkins Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Double unlock

Uh oh!

rdkcmf-jenkins Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Double unlock

Uh oh!

rdkcmf-jenkins Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Data race condition

Uh oh!

rdkcmf-jenkins Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Incorrect sizeof expression

Uh oh!

rdkcmf-jenkins Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Incorrect sizeof expression

Uh oh!

rdkcmf-jenkins Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

rdkcmf-jenkins Sep 10, 2025 •

edited

Loading

rdkcmf-jenkins Sep 10, 2025 •

edited

Loading

rdkcmf-jenkins Sep 10, 2025 •

edited

Loading

rdkcmf-jenkins Sep 10, 2025 •

edited

Loading

rdkcmf-jenkins Sep 10, 2025 •

edited

Loading

rdkcmf-jenkins Sep 11, 2025 •

edited

Loading

rdkcmf-jenkins Sep 11, 2025 •

edited

Loading

rdkcmf-jenkins Sep 11, 2025 •

edited

Loading

rdkcmf-jenkins Sep 11, 2025 •

edited

Loading

rdkcmf-jenkins Sep 11, 2025 •

edited

Loading

rdkcmf-jenkins Sep 11, 2025 •

edited

Loading

rdkcmf-jenkins Sep 11, 2025 •

edited

Loading

rdkcmf-jenkins Sep 11, 2025 •

edited

Loading

rdkcmf-jenkins Sep 11, 2025 •

edited

Loading

rdkcmf-jenkins Sep 11, 2025 •

edited

Loading

rdkcmf-jenkins Sep 11, 2025 •

edited

Loading

rdkcmf-jenkins Sep 12, 2025 •

edited

Loading

rdkcmf-jenkins Sep 12, 2025 •

edited

Loading