Skip to content

Rdkemw 4778: Test #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 36 commits into
base: develop
Choose a base branch
from
+31 −3
Draft

Rdkemw 4778: Test #352

Show file tree
Hide file tree
Changes from 34 commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
e7f8a19
Create auto_pr_creation_target_repo_caller.yml
ssitar583 Jul 8, 2025
8eb747a
Update auto_pr_creation_target_repo_caller.yml
ssitar583 Jul 8, 2025
16f5463
Update auto_pr_creation_target_repo_caller.yml
ssitar583 Jul 8, 2025
c8625e9
Update auto_pr_creation_target_repo_caller.yml
ssitar583 Jul 8, 2025
921fb95
Update auto_pr_creation_target_repo_caller.yml
ssitar583 Jul 8, 2025
e1b06b9
Update auto_pr_creation_target_repo_caller.yml
ssitar583 Jul 8, 2025
66a51f2
Update auto_pr_creation_target_repo_caller.yml
ssitar583 Jul 8, 2025
6bc4e69
Update auto_pr_creation_target_repo_caller.yml
ssitar583 Jul 8, 2025
6c99d70
Update auto_pr_creation_target_repo_caller.yml
ssitar583 Jul 8, 2025
c964491
Update auto_pr_creation_target_repo_caller.yml
ssitar583 Jul 8, 2025
2d9d0fd
Update auto_pr_creation_target_repo_caller.yml
ssitar583 Jul 8, 2025
4194158
Update auto_pr_creation_target_repo_caller.yml
ssitar583 Jul 9, 2025
b6ef3ab
Update IXCast.h
ssitar583 Jul 9, 2025
c6dbc97
Update IXCast.h
ssitar583 Jul 9, 2025
58e0feb
Update IXCast.h
ssitar583 Jul 9, 2025
342a40c
Update IXCast.h
ssitar583 Jul 11, 2025
3be66b7
Update IUSBDevice.h
ssitar583 Jul 15, 2025
1c678d7
Update IUSBDevice.h
ssitar583 Jul 15, 2025
2ba1fac
Update IUSBDevice.h
ssitar583 Jul 15, 2025
a23b580
Update IUSBDevice.h
ssitar583 Jul 15, 2025
12e138d
Update IUSBDevice.h
ssitar583 Jul 15, 2025
7058ff5
Update IUSBDevice.h
ssitar583 Jul 15, 2025
94d3bc9
Update IUSBDevice.h
ssitar583 Jul 15, 2025
ce89686
Update IUSBDevice.h
ssitar583 Jul 15, 2025
cd12c08
Update IUSBDevice.h
ssitar583 Jul 15, 2025
9a83db3
Update IUSBDevice.h
ssitar583 Jul 15, 2025
bc66676
Update IDeviceInfo.h
ssitar583 Jul 16, 2025
f378f73
Update IDeviceInfo.h
ssitar583 Jul 16, 2025
5bd8f06
Update auto_pr_creation_target_repo_caller.yml
ssitar583 Jul 16, 2025
fe848b4
Update IXCast.h
ssitar583 Jul 16, 2025
360b26b
Update auto_pr_creation_target_repo_caller.yml
ssitar583 Jul 16, 2025
ea6f890
Update IXCast.h
ssitar583 Jul 16, 2025
dcf58b7
Update auto_pr_creation_target_repo_caller.yml
ssitar583 Jul 16, 2025
89dbd05
Update auto_pr_creation_target_repo_caller.yml
ssitar583 Jul 16, 2025
0191d2c
Update IAmazonPrime.h
ssitar583 Jul 23, 2025
f6712dc
Update IAmazonPrime.h
ssitar583 Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/workflows/auto_pr_creation_target_repo_caller.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: Auto PR Creation Caller

on:
pull_request:
types: [closed]
branches:
- test_develop

jobs:
debug_check:
runs-on: ubuntu-latest
steps:
- run: echo "Triggered"

call_auto_pr_workflow:
Comment on lines +11 to +15

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 2 months ago

To fix the issue, add an explicit permissions block to the workflow. Since the debug_check job only echoes a message, it requires minimal permissions (e.g., contents: read). The call_auto_pr_workflow job involves calling an external workflow and using secrets, which might require additional permissions, such as contents: read and pull-requests: write. These permissions should be set to the least privilege necessary for the tasks.

Suggested changeset 1
.github/workflows/auto_pr_creation_target_repo_caller.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/auto_pr_creation_target_repo_caller.yml b/.github/workflows/auto_pr_creation_target_repo_caller.yml
--- a/.github/workflows/auto_pr_creation_target_repo_caller.yml
+++ b/.github/workflows/auto_pr_creation_target_repo_caller.yml
@@ -6,15 +6,22 @@
     branches:
       - test_develop
 
+permissions:
+  contents: read
+  pull-requests: write
+
 jobs:
   debug_check:
     runs-on: ubuntu-latest
+    permissions:
+      contents: read
     steps:
       - run: echo "Triggered" 
       
   call_auto_pr_workflow:
-    #secrets:
-      #RDKCM_RDKE: ${{ secrets.RDKCM_RDKE }}
+    permissions:
+      contents: read
+      pull-requests: write
     uses: rdkcentral/build_tools_workflows/.github/workflows/auto_pr_creation_meta.yml@RDKEMW-4778
     secrets:
       RDKCM_RDKE: ${{ secrets.RDKCM_RDKE }}
EOF
@@ -6,15 +6,22 @@
branches:
- test_develop

permissions:
contents: read
pull-requests: write

jobs:
debug_check:
runs-on: ubuntu-latest
permissions:
contents: read
steps:
- run: echo "Triggered"

call_auto_pr_workflow:
#secrets:
#RDKCM_RDKE: ${{ secrets.RDKCM_RDKE }}
permissions:
contents: read
pull-requests: write
uses: rdkcentral/build_tools_workflows/.github/workflows/auto_pr_creation_meta.yml@RDKEMW-4778
secrets:
RDKCM_RDKE: ${{ secrets.RDKCM_RDKE }}
Copilot is powered by AI and may make mistakes. Always verify output.
#secrets:
#RDKCM_RDKE: ${{ secrets.RDKCM_RDKE }}
uses: rdkcentral/build_tools_workflows/.github/workflows/auto_pr_creation_meta.yml@RDKEMW-4778
secrets:
RDKCM_RDKE: ${{ secrets.RDKCM_RDKE }}
#runs-on: ubuntu-latest
#steps:
# - name: Print placeholder instead of actual logic
# run: echo "This is a placeholder for the actual logic."
Comment on lines +18 to +24

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 2 months ago

To fix the issue, we should add a permissions block to explicitly limit the permissions of the GITHUB_TOKEN. The permissions should only allow the minimum necessary access, based on the workflow's functionality. For example:

  • contents: read is typically required for read-only access to the repository’s contents.
  • Additional permissions (like pull-requests: write) can be added if the workflow needs to create or update pull requests.

The permissions block can be added at the workflow level (to apply to all jobs) or at the job level (to be specific to individual jobs). In this case, adding the permissions block at the workflow level ensures all jobs in the workflow inherit these minimal permissions.

Suggested changeset 1
.github/workflows/auto_pr_creation_target_repo_caller.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/auto_pr_creation_target_repo_caller.yml b/.github/workflows/auto_pr_creation_target_repo_caller.yml
--- a/.github/workflows/auto_pr_creation_target_repo_caller.yml
+++ b/.github/workflows/auto_pr_creation_target_repo_caller.yml
@@ -1,5 +1,9 @@
 name: Auto PR Creation Caller
 
+permissions:
+  contents: read
+  pull-requests: write
+
 on:
   pull_request:
     types: [closed]
EOF
@@ -1,5 +1,9 @@
name: Auto PR Creation Caller

permissions:
contents: read
pull-requests: write

on:
pull_request:
types: [closed]
Copilot is powered by AI and may make mistakes. Always verify output.
2 changes: 1 addition & 1 deletion apis/DeviceInfo/IDeviceInfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/

//Test2
#pragma once

#include "Module.h"
Expand Down
2 changes: 1 addition & 1 deletion apis/USBDevice/IUSBDevice.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/

//Test10
#pragma once

#include "Module.h"
Expand Down
4 changes: 4 additions & 0 deletions apis/XCast/IXCast.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@

// @stubgen:include <com/IIteratorType.h>

//Test3

namespace WPEFramework {
namespace Exchange {
struct EXTERNAL IXCast : virtual public Core::IUnknown {
Expand Down Expand Up @@ -71,6 +73,8 @@ namespace WPEFramework {
virtual uint32_t getManufacturerName(string &manufacturername /* @out */ ) const = 0;
virtual uint32_t setModelName(string modelname) const = 0;
virtual uint32_t getModelName(string &modelname /* @out */ ) const = 0;


};

} // Exchange
Expand Down
Loading