-
Notifications
You must be signed in to change notification settings - Fork 14
RDKEMW-6078: Adding Interface for the DS Settings Manager. #424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Reason for change: Adding Interface for the DS Settings Manager. Test Procedure: no Risks: NO Priority: P1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check review comments of audio component.
Doing review with other component.
// @brief On Front Panel display time format changed | ||
// @text OnFPDTimeFormatChanged | ||
// @param timeFormat: current time format 12 or 24 hour | ||
virtual void OnFPDTimeFormatChanged(const FPDTimeFormat timeFormat) {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you check this event is not using in RDK-e?
|
||
|
||
// @event | ||
struct EXTERNAL INotification : virtual public Core::IUnknown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check few FPD related function are deprecated.
sync with develop
sync with develop
int32_t typeId; | ||
string name; | ||
// IDeviceSettingsAudioCompressionIterator *audioCompressions; | ||
// IDeviceSettingsAudioEncodingIterator *audioEncodings; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this commneted? if not needed pls remove it
Reason for change: Adding Interface for the DS Settings Manager.
Test Procedure: no
Risks: NO
Priority: P1