Skip to content

Conversation

Dosakaya
Copy link
Contributor

Reason for change: Adding Interface for the DS Settings Manager.
Test Procedure: no
Risks: NO
Priority: P1

Reason for change: Adding Interface for the DS Settings Manager.
Test Procedure: no
Risks: NO
Priority: P1
@Dosakaya Dosakaya requested a review from a team as a code owner July 24, 2025 11:36
@CLAassistant
Copy link

CLAassistant commented Jul 24, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

@santoshcomcast santoshcomcast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check review comments of audio component.
Doing review with other component.

// @brief On Front Panel display time format changed
// @text OnFPDTimeFormatChanged
// @param timeFormat: current time format 12 or 24 hour
virtual void OnFPDTimeFormatChanged(const FPDTimeFormat timeFormat) {};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you check this event is not using in RDK-e?



// @event
struct EXTERNAL INotification : virtual public Core::IUnknown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check few FPD related function are deprecated.

int32_t typeId;
string name;
// IDeviceSettingsAudioCompressionIterator *audioCompressions;
// IDeviceSettingsAudioEncodingIterator *audioEncodings;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this commneted? if not needed pls remove it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants