Conversation
Documentation Auto-GeneratedDocumentation has been automatically generated for the changed plugins and committed to this PR branch. The generated documentation files have been added to the PR for review. |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request corrects the JSON-RPC event names for three notification methods in the RDKWindowManager interface. The @text annotations for OnHidden, OnFocus, and OnBlur notification methods are updated from PascalCase to camelCase (onHidden, onFocus, onBlur) to follow the established naming convention for JSON-RPC events.
Changes:
- Updated @text annotations for three notification methods in IRDKWindowManager.h to use camelCase for JSON-RPC events
- Updated corresponding event references in the RDKWindowManager.md documentation to match the corrected naming
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apis/RDKWindowManager/IRDKWindowManager.h | Corrected @text annotations from OnHidden/OnFocus/OnBlur to onHidden/onFocus/onBlur for proper JSON-RPC event naming |
| docs/apis/RDKWindowManager.md | Updated event table references to use lowercase onHidden/onFocus/onBlur, consistent with other events and detailed event documentation sections |
ramasat
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Update in IRDKWindowManager.h
Test Procedure: Validate via postman that onFocus, onBlur and onHidden events are received.
Priority: P1
Version: Minor
Risks: None
Signed-off-by: IshvarAdithya_KavasseryRamanathan@comcast.com