RDKEMW-1000 : Add COM-RPC support to UnifiedCASManagement plugin#719
RDKEMW-1000 : Add COM-RPC support to UnifiedCASManagement plugin#719naveen-0206 wants to merge 3 commits intodevelopfrom
Conversation
Documentation Auto-GeneratedDocumentation has been automatically generated for the changed plugins and committed to this PR branch. The generated documentation files have been added to the PR for review. |
There was a problem hiding this comment.
Pull request overview
This PR introduces a new COM-RPC interface for UnifiedCASManagement and wires it into the shared ID registry so it can be exposed as a Thunder/JSON-RPC plugin.
Changes:
- Added
IUnifiedCASManagementCOM-RPC interface with registration,Manage,Unmanage,SendAPIs, and a CAS data notification event, including JSON-RPC tagging. - Added corresponding
ID_UNIFIEDCASMANAGEMENTandID_UNIFIEDCASMANAGEMENT_NOTIFICATIONentries inapis/Ids.hto allocate unique interface and notification IDs.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| apis/UnifiedCASManagement/IUnifiedCASManagement.h | Defines the new UnifiedCASManagement COM-RPC interface, notification event, and JSON-RPC metadata for CAS management and messaging. |
| apis/Ids.h | Reserves unique IDS values for the UnifiedCASManagement interface and its notification to integrate with the global COM-RPC ID space. |
2a5a184 to
1dcbee2
Compare
Documentation Auto-GeneratedDocumentation has been automatically generated for the changed plugins and committed to this PR branch. The generated documentation files have been added to the PR for review. |
648b364 to
56eb3f1
Compare
Documentation Auto-GeneratedDocumentation has been automatically generated for the changed plugins and committed to this PR branch. The generated documentation files have been added to the PR for review. |
207eae5 to
4145750
Compare
Documentation Auto-GeneratedDocumentation has been automatically generated for the changed plugins and committed to this PR branch. The generated documentation files have been added to the PR for review. |
50a83b5 to
353638a
Compare
353638a to
0e41656
Compare
Documentation Auto-GeneratedDocumentation has been automatically generated for the changed plugins and committed to this PR branch. The generated documentation files have been added to the PR for review. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
apis/Ids.h:342
- New IDS enum constants
ID_UNIFIEDCASMANAGEMENT/ID_UNIFIEDCASMANAGEMENT_NOTIFICATIONdo not follow the ALL_UPPER_SNAKE_CASE enum naming guideline (words should be separated with underscores). Since these IDs are newly introduced, it would be best to rename them to something likeID_UNIFIED_CAS_MANAGEMENTandID_UNIFIED_CAS_MANAGEMENT_NOTIFICATION(and update the interface header accordingly) before they become part of the public API surface.
ID_GOOGLE_CAST = ID_ENTOS_OFFSET + 0x470,
afa83df to
bbb43f6
Compare
Documentation Auto-GeneratedDocumentation has been automatically generated for the changed plugins and committed to this PR branch. The generated documentation files have been added to the PR for review. |
94b6aa9 to
046829b
Compare
Documentation Auto-GeneratedDocumentation has been automatically generated for the changed plugins and committed to this PR branch. The generated documentation files have been added to the PR for review. |
ef48220 to
ecf8e9f
Compare
Documentation Auto-GeneratedDocumentation has been automatically generated for the changed plugins and committed to this PR branch. The generated documentation files have been added to the PR for review. |
9324169 to
5e3cc5f
Compare
Reason For Change: Adding UnifiedCASManagement interface header Changes Test procedure : Test UnifiedCASManagement Priority: P1 Signed-off-by: naveen-0206 <naveenkumar.t@ltts.com>
5e3cc5f to
f3d4cc6
Compare
Documentation Auto-GeneratedDocumentation has been automatically generated for the changed plugins and committed to this PR branch. The generated documentation files have been added to the PR for review. |
Reason For Change: Adding UnifiedCASManagement interface header Changes
Test procedure : Test UnifiedCASManagement
Priority: P1