Skip to content

RDKEMW-12279 RALF Support for EntOS - PackageManager integration #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SKumarMetro wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

RDKEMW-12279 RALF Support for EntOS - PackageManager integration #722

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c99fe06
Added GENERAL_FAILURE to IPackageInstaller::FailReason
SKumarMetro Jan 26, 2026
f8ef543
Merge branch 'develop' of https://github.com/rdkcentral/entservices-a…
SKumarMetro Jan 29, 2026
ac7a5b0
Merge branch 'develop' of https://github.com/rdkcentral/entservices-a…
SKumarMetro Feb 4, 2026
4e0f9d6
Merge branch 'develop' of https://github.com/rdkcentral/entservices-a…
SKumarMetro Feb 5, 2026
0f8399c
disable JSONRPC for IPackageHandler
SKumarMetro Feb 5, 2026
dd2ebf8
Revert "disable JSONRPC for IPackageHandler"
SKumarMetro Feb 11, 2026
ed31d64
Merge branch 'develop' of https://github.com/rdkcentral/entservices-a…
SKumarMetro Feb 17, 2026
a9a0ec0
Merge branch 'develop' into topic/RDKEMW-12279
SKumarMetro Feb 17, 2026
a229647
Auto-generate documentation from interface changes
rdkcm-rdke Feb 17, 2026
ccb3bcc
Merge branch 'develop' of https://github.com/rdkcentral/entservices-a…
SKumarMetro Feb 19, 2026
21f1f56
Merge branch 'develop' into topic/RDKEMW-12279
SKumarMetro Feb 19, 2026
f2bdd92
Merge branch 'topic/RDKEMW-12279' of https://github.com/rdkcentral/en…
SKumarMetro Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apis/PackageManager/IAppPackageManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ namespace Exchange {

enum class FailReason : uint8_t {
NONE, // XXX: Not in HLA
GENERAL_FAILURE,
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The enum value GENERAL_FAILURE is missing the required @text annotation. According to the Enum Naming convention, enum values in interfaces marked with @JSON should include @text annotations to define their JSON RPC representation.

For example, similar patterns can be seen in:

  • apis/FirmwareUpdate/IFirmwareUpdate.h:30 - VALIDATION_FAILED = 1 /* @text VALIDATION_FAILED */
  • apis/USBMassStorage/IUSBMassStorage.h:35 - READ_ONLY = 1 /* @text READ_ONLY */

The @text annotation should be added in the format: GENERAL_FAILURE /* @text GENERAL_FAILURE */,

Refer: https://github.com/rdkcentral/entservices-apis/blob/develop/.github/instructions/api_headers.instructions.md#enum-naming

Copilot generated this review using guidance from repository custom instructions.
SIGNATURE_VERIFICATION_FAILURE,
PACKAGE_MISMATCH_FAILURE,
INVALID_METADATA_FAILURE,
Expand Down
Loading