Revert "RDKEMW-999 : Add COM-RPC support to ResourceManager plugin"#741
Closed
naveen-0206 wants to merge 1 commit intodevelopfrom
Closed
Revert "RDKEMW-999 : Add COM-RPC support to ResourceManager plugin"#741naveen-0206 wants to merge 1 commit intodevelopfrom
naveen-0206 wants to merge 1 commit intodevelopfrom
Conversation
)" This reverts commit e80b1a2.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts PR #701, which had added COM-RPC support to the ResourceManager plugin. The revert cleanly removes all artifacts of the COM-RPC implementation while preserving the existing ResourceManager plugin documentation (ResourceManagerPlugin.md).
Changes:
- Removed the COM-RPC interface definition for ResourceManager
- Removed the generated API documentation for the COM-RPC interface
- Removed the interface ID constant from the central ID registry
- Removed the documentation sidebar entry for the COM-RPC version
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/apis/ResourceManager.md | Removed auto-generated documentation for COM-RPC ResourceManager interface |
| docs/_sidebar.md | Removed sidebar entry for ResourceManager.md (keeping ResourceManagerPlugin.md) |
| apis/ResourceManager/IResourceManager.h | Removed COM-RPC interface header definition |
| apis/Ids.h | Removed ID_RESOURCEMANAGER constant from the ID registry |
Contributor
Author
|
No need to revert the changes i have made a fix on the top of earlier changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #701