Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the RemoveKeyIntercept method signature in the IRDKWindowManager interface, changing it from a single JSON string parameter to three separate parameters (clientId, keyCode, modifiers). This represents a breaking API change that will require updates to all consumers of this interface.
Changes:
- Modified
RemoveKeyInterceptmethod signature from accepting a singleinterceptJSON string parameter to accepting three discrete parameters:clientId(string),keyCode(uint32_t), andmodifiers(string) - Updated method documentation to reflect the new parameter structure
madanagopalt
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.