RDKEMW-14381: Add the new API getTimeSinceWakeup in PowerManager Plugin#746
RDKEMW-14381: Add the new API getTimeSinceWakeup in PowerManager Plugin#746
Conversation
Documentation Auto-GeneratedDocumentation has been automatically generated for the changed plugins and committed to this PR branch. The generated documentation files have been added to the PR for review. |
There was a problem hiding this comment.
Pull request overview
Adds a new PowerManager JSON-RPC/API surface for retrieving elapsed time since device wakeup, updating both the public interface header and the generated API documentation.
Changes:
- Documented the new
getTimeSinceWakeupmethod indocs/apis/PowerManager.md(including request/response examples). - Added
GetTimeSinceWakeupto theExchange::IPowerManagerinterface.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| docs/apis/PowerManager.md | Adds documentation entry and examples for the new getTimeSinceWakeup API and adjusts subsequent example IDs. |
| apis/PowerManager/IPowerManager.h | Introduces the new GetTimeSinceWakeup interface method for implementation by the PowerManager plugin. |
docs/apis/PowerManager.md
Outdated
| "jsonrpc": 2.0, | ||
| "id": 7, | ||
| "result": { | ||
| "secondsSinceWakeup": "" |
There was a problem hiding this comment.
The secondsSinceWakeup field is documented as uint32, but the response example shows it as an empty string. Please update the example to return a numeric value (e.g., 0) and ensure the documented type matches the actual JSON value type used by the API.
| "secondsSinceWakeup": "" | |
| "secondsSinceWakeup": 0 |
apis/PowerManager/IPowerManager.h
Outdated
|
|
||
| /** Get the Wakeup Time */ | ||
| // @text getTimeSinceWakeup | ||
| // @brief Get the the Wakeup Time |
There was a problem hiding this comment.
@brief contains a duplicated word (“Get the the Wakeup Time”). Please fix the wording.
| // @brief Get the the Wakeup Time | |
| // @brief Get the Wakeup Time |
Documentation Auto-GeneratedDocumentation has been automatically generated for the changed plugins and committed to this PR branch. The generated documentation files have been added to the PR for review. |
Documentation Auto-GeneratedDocumentation has been automatically generated for the changed plugins and committed to this PR branch. The generated documentation files have been added to the PR for review. |
Reason for change: Add the new API getTimeSinceWakeup in PowerManager Plugin
Test Procedure: Check the Ticket
Risks: Low
Priority: P1
version: Patch
Signed-off-by:Dineshkumar P [dinesh_kumar2@comcast.com]