Skip to content

RDKEMW-14381: Add the new API getTimeSinceWakeup in PowerManager Plugin#746

Open
dkumar798 wants to merge 6 commits intodevelopfrom
feature/RDKEMW-14381
Open

RDKEMW-14381: Add the new API getTimeSinceWakeup in PowerManager Plugin#746
dkumar798 wants to merge 6 commits intodevelopfrom
feature/RDKEMW-14381

Conversation

@dkumar798
Copy link
Contributor

Reason for change: Add the new API getTimeSinceWakeup in PowerManager Plugin
Test Procedure: Check the Ticket
Risks: Low
Priority: P1
version: Patch
Signed-off-by:Dineshkumar P [dinesh_kumar2@comcast.com]

@dkumar798 dkumar798 requested a review from a team as a code owner February 24, 2026 09:39
Copilot AI review requested due to automatic review settings February 24, 2026 09:39
@github-actions
Copy link

Documentation Auto-Generated

Documentation has been automatically generated for the changed plugins and committed to this PR branch.

The generated documentation files have been added to the PR for review.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new PowerManager JSON-RPC/API surface for retrieving elapsed time since device wakeup, updating both the public interface header and the generated API documentation.

Changes:

  • Documented the new getTimeSinceWakeup method in docs/apis/PowerManager.md (including request/response examples).
  • Added GetTimeSinceWakeup to the Exchange::IPowerManager interface.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
docs/apis/PowerManager.md Adds documentation entry and examples for the new getTimeSinceWakeup API and adjusts subsequent example IDs.
apis/PowerManager/IPowerManager.h Introduces the new GetTimeSinceWakeup interface method for implementation by the PowerManager plugin.

"jsonrpc": 2.0,
"id": 7,
"result": {
"secondsSinceWakeup": ""
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The secondsSinceWakeup field is documented as uint32, but the response example shows it as an empty string. Please update the example to return a numeric value (e.g., 0) and ensure the documented type matches the actual JSON value type used by the API.

Suggested change
"secondsSinceWakeup": ""
"secondsSinceWakeup": 0

Copilot uses AI. Check for mistakes.

/** Get the Wakeup Time */
// @text getTimeSinceWakeup
// @brief Get the the Wakeup Time
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brief contains a duplicated word (“Get the the Wakeup Time”). Please fix the wording.

Suggested change
// @brief Get the the Wakeup Time
// @brief Get the Wakeup Time

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

Documentation Auto-Generated

Documentation has been automatically generated for the changed plugins and committed to this PR branch.

The generated documentation files have been added to the PR for review.

Copilot AI review requested due to automatic review settings February 24, 2026 09:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

@github-actions
Copy link

Documentation Auto-Generated

Documentation has been automatically generated for the changed plugins and committed to this PR branch.

The generated documentation files have been added to the PR for review.

Copilot AI review requested due to automatic review settings February 25, 2026 07:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants