Skip to content

RDKEMW-13233:Renaming Storagemanager to appstoragemanager#750

Open
Sonajeya31 wants to merge 7 commits intotopic/RDKEMW-13976from
topic/rdkemw-13235
Open

RDKEMW-13233:Renaming Storagemanager to appstoragemanager#750
Sonajeya31 wants to merge 7 commits intotopic/RDKEMW-13976from
topic/rdkemw-13235

Conversation

@Sonajeya31
Copy link
Contributor

Reason for change: Our appstoragemanager is currently in conflict with existing storagemanager plugin
Verify:Build and Test

@Sonajeya31 Sonajeya31 requested a review from a team as a code owner February 26, 2026 06:47
Copilot AI review requested due to automatic review settings February 26, 2026 06:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns the API and documentation naming to use AppStorageManager instead of StorageManager to avoid plugin naming conflicts.

Changes:

  • Renames the documented plugin name/callsign from StorageManager to AppStorageManager in generated API docs.
  • Updates the docs sidebar to list AppStorageManager and removes the StorageManager entry.
  • Renames the public Exchange interface identifier and interface type to ID_APPSTORAGEMANAGER / IAppStorageManager.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
docs/apis/AppStorageManager.md Updates plugin name, version link, callsign, and JSON-RPC method prefix to org.rdk.AppStorageManager.
docs/_sidebar.md Adds AppStorageManager to API reference navigation and removes StorageManager entry.
apis/Ids.h Renames the public ID constant from ID_STORAGEMANAGER to ID_APPSTORAGEMANAGER.
apis/AppStorageManager/IAppStorageManager.h Renames interface type to IAppStorageManager and switches to the new ID constant.
Comments suppressed due to low confidence (2)

apis/AppStorageManager/IAppStorageManager.h:29

  • Renaming the interface type from IStorageManager to IAppStorageManager is a source-breaking change for any existing C++ consumers. If compatibility is needed, consider providing a deprecated alias/type wrapper so existing code can still compile while migrating to the new name.
    docs/apis/AppStorageManager.md:7
  • The description now reads "A AppStorageManager plugin..." which is grammatically incorrect. Consider changing to "An AppStorageManager plugin..." or rephrasing to avoid the article altogether (e.g., "AppStorageManager plugin for the Thunder framework").

ID_PACKAGE_LOCK_ITERATOR = ID_APP_PACKAGE_MANAGER + 10,

ID_STORAGEMANAGER = ID_ENTOS_OFFSET + 0x310,
ID_APPSTORAGEMANAGER = ID_ENTOS_OFFSET + 0x310,
Copy link

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming the public interface ID constant from ID_STORAGEMANAGER to ID_APPSTORAGEMANAGER is a source-breaking API change for any external consumers including this header. If backward compatibility is required, consider keeping ID_STORAGEMANAGER as a deprecated alias to the new name (both mapping to the same numeric value).

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants