RDKEMW-13233:Renaming Storagemanager to appstoragemanager#750
Open
Sonajeya31 wants to merge 7 commits intotopic/RDKEMW-13976from
Open
RDKEMW-13233:Renaming Storagemanager to appstoragemanager#750Sonajeya31 wants to merge 7 commits intotopic/RDKEMW-13976from
Sonajeya31 wants to merge 7 commits intotopic/RDKEMW-13976from
Conversation
Co-authored-by: Sonajeya31 <155615090+Sonajeya31@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns the API and documentation naming to use AppStorageManager instead of StorageManager to avoid plugin naming conflicts.
Changes:
- Renames the documented plugin name/callsign from
StorageManagertoAppStorageManagerin generated API docs. - Updates the docs sidebar to list AppStorageManager and removes the StorageManager entry.
- Renames the public Exchange interface identifier and interface type to
ID_APPSTORAGEMANAGER/IAppStorageManager.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/apis/AppStorageManager.md | Updates plugin name, version link, callsign, and JSON-RPC method prefix to org.rdk.AppStorageManager. |
| docs/_sidebar.md | Adds AppStorageManager to API reference navigation and removes StorageManager entry. |
| apis/Ids.h | Renames the public ID constant from ID_STORAGEMANAGER to ID_APPSTORAGEMANAGER. |
| apis/AppStorageManager/IAppStorageManager.h | Renames interface type to IAppStorageManager and switches to the new ID constant. |
Comments suppressed due to low confidence (2)
apis/AppStorageManager/IAppStorageManager.h:29
- Renaming the interface type from IStorageManager to IAppStorageManager is a source-breaking change for any existing C++ consumers. If compatibility is needed, consider providing a deprecated alias/type wrapper so existing code can still compile while migrating to the new name.
docs/apis/AppStorageManager.md:7 - The description now reads "A AppStorageManager plugin..." which is grammatically incorrect. Consider changing to "An AppStorageManager plugin..." or rephrasing to avoid the article altogether (e.g., "AppStorageManager plugin for the Thunder framework").
| ID_PACKAGE_LOCK_ITERATOR = ID_APP_PACKAGE_MANAGER + 10, | ||
|
|
||
| ID_STORAGEMANAGER = ID_ENTOS_OFFSET + 0x310, | ||
| ID_APPSTORAGEMANAGER = ID_ENTOS_OFFSET + 0x310, |
There was a problem hiding this comment.
Renaming the public interface ID constant from ID_STORAGEMANAGER to ID_APPSTORAGEMANAGER is a source-breaking API change for any external consumers including this header. If backward compatibility is required, consider keeping ID_STORAGEMANAGER as a deprecated alias to the new name (both mapping to the same numeric value).
B-Larsen
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Our appstoragemanager is currently in conflict with existing storagemanager plugin
Verify:Build and Test