RDKEMW-11794: Inspect multiple web applications #28

mounikapalem · 2026-01-06T14:54:27Z

No description provided.

github-actions · 2026-01-06T14:54:38Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

rdkcmf-jenkins · 2026-01-06T14:55:28Z

b'## Copyright scan failure
Commit: bb59c00
Report detail: https://gist.github.com/rdkcmf-jenkins/831eb0592ec2043a4d42896af41039e2'

mounikapalem · 2026-01-07T09:48:24Z

I have read the CLA Document and I hereby sign the CLA

RuntimeManager/CMakeLists.txt

RuntimeManager/RuntimeManagerImplementation.h

RuntimeManager/RuntimeManagerImplementation.cpp

madanagopalt

kindly look at comments

Copilot

Pull request overview

This pull request adds support for inspecting multiple web applications running in containers simultaneously. The implementation introduces a WebInspector gateway that sets up port forwarding from host ports (2000-2100) to the WebInspector port (22222) inside containers, enabling external debugging tools to connect to containerized web applications.

Changes:

Added WebInspector attachment/detachment logic in container lifecycle event handlers
Introduced new Gateway module with networking and iptables utilities for port forwarding
Enhanced RuntimeManager with debug port management and container IP address resolution

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 17 comments.

Show a summary per file

File	Description
RuntimeManager/RuntimeManagerImplementation.h	Added forward declaration for WebInspector and member variables for tracking WebInspector instances and port availability
RuntimeManager/RuntimeManagerImplementation.cpp	Implemented WebInspector attachment on container start and cleanup on container stop
RuntimeManager/Gateway/WebInspector.h	Defined WebInspector class for managing debugging connections
RuntimeManager/Gateway/WebInspector.cpp	Implemented WebInspector with iptables port forwarding rules
RuntimeManager/Gateway/NetFilter.h	Defined NetFilter wrapper class for iptables operations
RuntimeManager/Gateway/NetFilter.cpp	Implemented NetFilter with locking and C++ wrapper functions
RuntimeManager/Gateway/NetFilterUtils.h	C API header for low-level iptables operations
RuntimeManager/Gateway/NetFilterUtils.c	Low-level C implementation of iptables rule management
RuntimeManager/Gateway/NetFilterLock.h	File-based locking mechanism for iptables operations
RuntimeManager/Gateway/NetFilterLock.cpp	Implementation of NetFilterLock using flock
RuntimeManager/Gateway/Debugger.h	Base class for debugger attachments
RuntimeManager/Gateway/ContainerUtils.h	Utility functions for container operations
RuntimeManager/Gateway/ContainerUtils.cpp	Implementation for entering container namespaces and retrieving IP addresses
RuntimeManager/Gateway/CMakeLists.txt	Build configuration for Gateway library
RuntimeManager/CMakeLists.txt	Updated to build Gateway module and link iptables libraries
.github/workflows/L1-tests.yml	Added required iptables development packages for CI

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

RuntimeManager/RuntimeManagerImplementation.cpp

RuntimeManager/CMakeLists.txt

RuntimeManager/RuntimeManagerImplementation.cpp

RuntimeManager/Gateway/NetFilterLock.cpp

RuntimeManager/RuntimeManagerImplementation.h

RuntimeManager/RuntimeManagerImplementation.cpp

RuntimeManager/Gateway/NetFilterLock.cpp

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 16 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

RuntimeManager/RuntimeManagerImplementation.cpp

RuntimeManager/Gateway/NetFilter.cpp

RuntimeManager/Gateway/ContainerUtils.cpp

RuntimeManager/Gateway/WebInspector.cpp

RuntimeManager/CMakeLists.txt

RuntimeManager/RuntimeManagerImplementation.cpp

RuntimeManager/Gateway/ContainerUtils.cpp

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 17 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

RuntimeManager/Gateway/NetFilterUtils.c

RuntimeManager/RuntimeManagerImplementation.cpp

RuntimeManager/Gateway/ContainerUtils.cpp

RuntimeManager/Gateway/NetFilterUtils.c

Copilot · 2026-01-19T00:31:02Z

@mounikapalem I've opened a new pull request, #43, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 14 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

RuntimeManager/Gateway/NetFilterUtils.c

RuntimeManager/Gateway/ContainerUtils.cpp

RuntimeManager/Gateway/ContainerUtils.h

RuntimeManager/Gateway/NetFilterUtils.c

RuntimeManager/Gateway/ContainerUtils.cpp

RuntimeManager/Gateway/NetFilterUtils.c

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 8 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

RuntimeManager/Gateway/NetFilterUtils.c

RuntimeManager/Gateway/ContainerUtils.cpp

RuntimeManager/Gateway/WebInspector.cpp

RuntimeManager/RuntimeManagerImplementation.cpp

RuntimeManager/Gateway/NetFilterUtils.c

RuntimeManager/Gateway/ContainerUtils.cpp

madanagopalt · 2026-01-28T06:26:54Z

RuntimeManager/CMakeLists.txt

 separate_arguments(RUNTIME_MANAGER_INCLUDES)
 include_directories(BEFORE ${RUNTIME_MANAGER_INCLUDES})

+find_path(LIBIPTC_INCLUDE_DIR NAMES libiptc/libiptc.h)


Can everylines of this can go inside DEBUG check?

madanagopalt · 2026-01-28T06:27:05Z

RuntimeManager/CMakeLists.txt

+endif()
+
+# IPv4 tables
+find_package_handle_standard_args(LIBIP4TC


Can everylines of this can go inside DEBUG check?

madanagopalt · 2026-01-28T06:27:09Z

RuntimeManager/CMakeLists.txt

+    set(LIBIPTC_LIBRARIES ${LIBIPTC_LIBRARY})
+endif()
+
+if(LIBIPTC_FOUND AND NOT TARGET LibIptc::LibIptc)


Can everylines of this can go inside DEBUG check?

madanagopalt · 2026-01-28T06:27:18Z

RuntimeManager/CMakeLists.txt

+
+mark_as_advanced(LIBIPTC_LIBRARY LIBIPTC_INCLUDE_DIR)
+
+if(LIBIPTC_FOUND)


Can everylines of this can go inside DEBUG check?

madanagopalt

kindly update cmake file

Reason for change: Updated WebInspector to support inspection across multiple web applications. Risks: low Priority: P2

Refactor NetFilter.cpp to enhance logging and add regex matching for comment removal.

Reason for change: Addressed the review comments. Risks: low Priority: P2

Co-authored-by: Copilot <[email protected]>

Reason for change: Addressed the review comments. Risks: low Priority: P2

Co-authored-by: Copilot <[email protected]>

Reason for change: Addressed the review comments. Risks: low Priority: P2

Co-authored-by: Copilot <[email protected]>

Reason for change: Updated the cmake file. Risks: low Priority: P2

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 10 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

RuntimeManager/RuntimeManagerImplementation.cpp

RuntimeManager/Gateway/NetFilterLock.h

RuntimeManager/CMakeLists.txt

RuntimeManager/Gateway/CMakeLists.txt

RuntimeManager/Gateway/NetFilterUtils.c

RuntimeManager/RuntimeManagerImplementation.cpp

RuntimeManager/Gateway/NetFilterUtils.c

RuntimeManager/RuntimeManagerImplementation.cpp

mounikapalem requested a review from madanagopalt January 7, 2026 04:14

madanagopalt reviewed Jan 9, 2026

View reviewed changes

RuntimeManager/CMakeLists.txt Outdated Show resolved Hide resolved

madanagopalt reviewed Jan 9, 2026

View reviewed changes

RuntimeManager/RuntimeManagerImplementation.h Show resolved Hide resolved

madanagopalt reviewed Jan 9, 2026

View reviewed changes

RuntimeManager/RuntimeManagerImplementation.h Show resolved Hide resolved

madanagopalt reviewed Jan 9, 2026

View reviewed changes

RuntimeManager/RuntimeManagerImplementation.cpp Outdated Show resolved Hide resolved

madanagopalt reviewed Jan 9, 2026

View reviewed changes

RuntimeManager/RuntimeManagerImplementation.cpp Show resolved Hide resolved

madanagopalt requested changes Jan 9, 2026

View reviewed changes

mounikapalem force-pushed the topic/RDKEMW-11794 branch from 18d44de to a475ee6 Compare January 12, 2026 04:18

madanagopalt requested a review from Copilot January 13, 2026 06:17

Copilot started reviewing on behalf of madanagopalt January 13, 2026 06:17 View session

Copilot AI reviewed Jan 13, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 13, 2026 10:37

Copilot started reviewing on behalf of mounikapalem January 13, 2026 10:37 View session

Copilot AI reviewed Jan 13, 2026

View reviewed changes

mounikapalem force-pushed the topic/RDKEMW-11794 branch from 19d2bc6 to b13636e Compare January 17, 2026 13:44

Copilot AI review requested due to automatic review settings January 17, 2026 15:26

Copilot started reviewing on behalf of mounikapalem January 17, 2026 15:26 View session

Copilot AI reviewed Jan 17, 2026

View reviewed changes

Copilot AI mentioned this pull request Jan 19, 2026

Add L1 test coverage for Gateway module #43

Draft

Copilot AI review requested due to automatic review settings January 19, 2026 01:02

Copilot started reviewing on behalf of mounikapalem January 19, 2026 01:03 View session

Copilot AI reviewed Jan 19, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 19, 2026 03:47

Copilot started reviewing on behalf of mounikapalem January 19, 2026 03:48 View session

Copilot AI reviewed Jan 19, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 19, 2026 09:10

madanagopalt reviewed Jan 28, 2026

View reviewed changes

madanagopalt requested changes Jan 28, 2026

View reviewed changes

mounikapalem and others added 18 commits January 28, 2026 12:23

RDKEMW-11794: Inspect multiple web applications

d2eb2e4

Reason for change: Updated WebInspector to support inspection across multiple web applications. Risks: low Priority: P2

Updated NetFilterUtils.c

f4dfdb7

Updated NetFilter.cpp with regex matching and improved logging

c579b72

Refactor NetFilter.cpp to enhance logging and add regex matching for comment removal.

Add iptables-dev to package installation

e49d6be

Add additional dependencies for installation

03b60f0

RDKEMW-11794: Inspect multiple web applications

f147f67

Reason for change: Addressed the review comments. Risks: low Priority: P2

RDKEMW-11794: Inspect multiple web applications

b3cc377

Reason for change: Addressed the review comments. Risks: low Priority: P2

Addressed indentation issues

0c03d24

Co-authored-by: Copilot <[email protected]>

RDKEMW-11794: Inspect multiple web applications

a522a73

Reason for change: Addressed the review comments. Risks: low Priority: P2

Apply suggestions from code review

d59bd40

Co-authored-by: Copilot <[email protected]>

Addressed review comments

bbeb176

Co-authored-by: Copilot <[email protected]>

Update L1-tests.yml

15b1f15

RDKEMW-11794: Inspect multiple web applications

30834d1

Reason for change: Addressed the review comments. Risks: low Priority: P2

RDKEMW-11794: Inspect multiple web applications

accfd58

Reason for change: Addressed the review comments. Risks: low Priority: P2

Update L1-tests.yml

22c36f8

RDKEMW-11794: Inspect multiple web applications

c5f8fe1

Reason for change: Addressed the review comments. Risks: low Priority: P2

RDKEMW-11794: Inspect multiple web applications

7632dac

Reason for change: Addressed the review comments. Risks: low Priority: P2

Addressed comments

59c3e32

Co-authored-by: Copilot <[email protected]>

mounikapalem force-pushed the topic/RDKEMW-11794 branch from 120b7d0 to 59c3e32 Compare January 28, 2026 06:53

RDKEMW-11794: Inspect multiple web applications

49ba601

Reason for change: Updated the cmake file. Risks: low Priority: P2

Copilot AI review requested due to automatic review settings January 28, 2026 07:34

Copilot started reviewing on behalf of mounikapalem January 28, 2026 07:34 View session

Copilot AI reviewed Jan 28, 2026

View reviewed changes

madanagopalt approved these changes Jan 28, 2026

View reviewed changes

B-Larsen approved these changes Jan 29, 2026

View reviewed changes


		mark_as_advanced(LIBIPTC_LIBRARY LIBIPTC_INCLUDE_DIR)

		if(LIBIPTC_FOUND)

RDKEMW-11794: Inspect multiple web applications #28

Are you sure you want to change the base?

RDKEMW-11794: Inspect multiple web applications #28

Uh oh!

Conversation

mounikapalem commented Jan 6, 2026

Uh oh!

github-actions bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rdkcmf-jenkins commented Jan 6, 2026

Uh oh!

mounikapalem commented Jan 7, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

madanagopalt left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Jan 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 6, 2026 •

edited

Loading