rebase #141

Prathyushakothuru · 2025-06-13T07:32:01Z

No description provided.

github-advanced-security · 2025-07-16T12:12:08Z

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

CLAassistant · 2025-09-01T09:57:51Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
4 out of 5 committers have signed the CLA.

✅ hgfell683
✅ AkshayKumar2794
✅ pahearn73
✅ ramasat
❌ actions-user
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

1.4.13 release 1.4.13

…upport RDKEMW-1008: Add COM-RPC support to AVInput plugin

1.4.14 release 1.4.14

…8-COM-RPC_support Revert "RDKEMW-1008: Add COM-RPC support to AVInput plugin"

1.4.15 release 1.4.15

* RDKEMW-6331 : Fix HdmiCecSink COM-RPC issues Reason for change : COM-RPC Implementation with fixes for - getDeviceList does not return proper json tags in response. Populating powerStatus instead of portNumber. Added RequestAudioDevicePowerStatus API Signed-off-by: smanes0213 <[email protected]> * Update HdmiCecSinkImplementation.cpp * Update HdmiCecSinkImplementation.cpp * Add debug prints * Added additional debug prints * resolved compilation errors * Update HdmiCecSinkImplementation.cpp * Resolved value assignment swap * Update HdmiCecSinkImplementation.cpp * Delete wpeframework.log * update HdmiCecSinkImplementation.h * Delete wpelatest.log * Resolved GetActiveRoute length issue * Add additional logging to check SetActivePath functionality * Remove all the debug prints from the HdmiCecSink Implementation file. * Rename the HdmiCecSinkSuccess structure objects. * Update HdmiCecSinkImplementation.cpp * RDK-55553 : Add L1 & L2 tests for HdmiCecSink plugin Reason for change: Adding L2 test cases for latest COM-RPC supported HdmiCecSink plugin. Test Procedure: Run L2test to verify Risks: Medium Signed-off-by: smanes0213 <[email protected]> * Update L2-tests.yml * Only find CEC package when not building for L2 tests * Update L2-tests.yml * Enable L2 Test * Update L2-tests.yml * Update CMakeLists.txt * Update CMakeLists.txt * Update L2-tests.yml * RDK-55553 : Add L1 & L2 tests for HdmiCecSink plugin Reason for change: Adding L2 test cases for latest COM-RPC supported HdmiCecSink plugin. Test Procedure: Run L2test to verify Risks: Medium Signed-off-by: smanes0213 <[email protected]> * Update HdmiCecSink_L2Test.cpp * Added JSONRPC fixtures and events * Added JSONRPC fixtures * Delete testlogs.txt * Update HdmiCecSink_L2Test.cpp * Add Test Fixtures to cover CEC process * Add Test Fixtures to cover CEC process * Add Test Fixtures to cover CEC process * Move InjectTestFixtures to the end * Update HdmiCecSink_L2Test.cpp * Update HdmiCecSink_L2Test.cpp * Update HdmiCecSink_L2Test.cpp * Update HdmiCecSink_L2Test.cpp * Update HdmiCecSink_L2Test.cpp * Update HdmiCecSink_L2Test.cpp * Update HdmiCecSink_L2Test.cpp * Update HdmiCecSink_L2Test.cpp * Update HdmiCecSink_L2Test.cpp * Update HdmiCecSink_L2Test.cpp * Update HdmiCecSink_L2Test.cpp * Update HdmiCecSink_L2Test.cpp * Update HdmiCecSink_L2Test.cpp * Update HdmiCecSink_L2Test.cpp * Update HdmiCecSink_L2Test.cpp * Resolving L1 Test compilation issues * Update test_HdmiCecSink.cpp * Update L1-tests.yml * Resolve errors in L1 HdmiCecSink test file * Update according to latest PowerManagerMock changes * Update L2-tests.yml * Update HdmiCecSink_L2Test.cpp * Update HdmiCecSink_L2Test.cpp * Update L2-tests.yml * Update HdmiCecSink_L2Test.cpp * Update L2-tests.yml * list the pwrmgr_restarted file in the logs * Add adittional logs for checking presence of ui_settings file * Resolve powerstate issue. * Update HdmiCecSink_L2Test.cpp * Update L2-tests.yml * increase coverage * increase coverage * Update HdmiCecSink_L2Test.cpp * Update HdmiCecSink_L2Test.cpp * Update HdmiCecSink_L2Test.cpp * Update HdmiCecSink_L2Test.cpp * Increase Coverage * Increase Coverage * Increase Coverage * Increase Coverage * Increase Coverage * Increase Coverage * Increase Coverage * Increase Coverage * Increase Coverage * Add description to test fixtures * Add description to test fixtures * Add description to test fixtures * Add description to test fixtures * Add description to test fixtures * Add new implementation changes * Update test_HdmiCecSource.cpp * remove unwanted changes from CMakeLists.txt * Update to latest changes * Update CMakeLists.txt * Update L1-tests.yml * Update L2-tests.yml * Update L2-tests.yml * Update HdmiCecSourceImplementation.h * Update HdmiCecSourceImplementation.h * Update HdmiCecSourceImplementation.h * Update to latest changes * Update HdmiCecSourceImplementation.cpp * Update HdmiCecSourceImplementation.cpp * Update HdmiCecSink.cpp * Update cov_build.sh * Update to latest changes * Rebase the code with new changes and resolve the issues * Update HdmiCecSink_L2Test.cpp * Rebase the code with new changes and resolve the issues * Rebase the code with new changes and resolve the issues * Rebase the code with new changes and resolve the issues * Resolve test failures * Resolve test failures * Add loging for debugging * Add loging for debugging * Resolve test failures * Test Hdmihotplug * Test Hdmihotplug * Add Coverage * Update HdmiCecSink_L2Test.cpp * testframework run * Update L2-tests.yml * Disable HDMICECSOURCE plugin in L1-tests workflow * Update L1-tests.yml * Update branch reference in L1-tests.yml * Update L2-tests.yml * Update L1-tests.yml * Update L2-tests.yml * Update cov_build.sh * Update cov_build.sh * Update build_dependencies.sh * Resolve Coverity issue on HdmiCecSink L1 test file. * Update test_HdmiCecSink.cpp * Update test_HdmiCecSink.cpp * Update build_dependencies.sh * Update L1-tests.yml * Update L2-tests.yml * Update L2-tests.yml * Update L2-tests.yml --------- Signed-off-by: smanes0213 <[email protected]> Co-authored-by: balav08 <[email protected]>

1.5.0 release 1.5.0

Copilot

Pull Request Overview

This PR removes the HdmiInput plugin entirely and adds L2 tests for HdmiCecSink. Key changes include:

Complete removal of HdmiInput plugin files and directories
Addition of comprehensive L2 test suite for HdmiCecSink (3879 lines)
Removal of pluginInterface->AddRef() call in PluginInterfaceBuilder
Updates to build dependencies and test framework documentation
CMakeLists and test configuration updates to support new test structure

Reviewed Changes

Copilot reviewed 48 out of 51 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
helpers/PluginInterfaceBuilder.h	Removed AddRef() call for plugin interface
Tests/L2Tests/tests/HdmiCecSink_L2Test.cpp	Added comprehensive L2 test suite for HdmiCecSink
Tests/L2Tests/tests/test_foo_IN.cpp	Added basic test placeholder
Tests/L2Tests/CMakeLists.txt	Updated to C++14 and restructured test builds
Tests/L1Tests/tests/test_HdmiCecSink.cpp	Refactored L1 tests with mocking improvements
Tests/L1Tests/tests/test_HdmiCecSource.cpp	Removed event handler registration mocks
Tests/L1Tests/tests/test_HdcpProfile.cpp	Cleaned up mock dependencies
Tests/L1Tests/CMakeLists.txt	Removed HdmiInput tests, updated C++14 standard
HdmiInput/*	Complete removal of HdmiInput plugin
build_dependencies.sh	Changed entservices-apis branch and added stub files
cov_build.sh	Added libdrm include path
Tests/README.md	Updated documentation with better formatting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-10-28T20:14:52Z

helpers/PluginInterfaceBuilder.h

            if (pluginInterface) {
-                pluginInterface->AddRef();
                LOGINFO("plugin interface succeed and retry count: %d",count);
                return pluginInterface;
            }


Removing the AddRef() call at line 116 (before the removed line) could lead to premature object destruction. When QueryInterfaceByCallsign returns an interface pointer, the reference count is incremented. Previously, an explicit AddRef() was called to maintain an additional reference. Removing this call without corresponding changes to ensure proper lifetime management may cause the interface to be released prematurely when other holders release their references, potentially leading to use-after-free bugs.

Copilot · 2025-10-28T20:14:52Z

build_dependencies.sh

 git clone --branch R4.4.1 https://github.com/rdkcentral/Thunder.git

-git clone --branch main https://github.com/rdkcentral/entservices-apis.git
+git clone --branch develop https://github.com/rdkcentral/entservices-apis.git


Changing the branch from 'main' to 'develop' for entservices-apis could introduce instability issues as the develop branch may contain untested or unstable code. Consider documenting why this branch change was necessary or reverting to a stable branch/tag for production builds.

Copilot · 2025-10-28T20:14:53Z

Tests/L2Tests/CMakeLists.txt


 set_target_properties(${MODULE_NAME} PROPERTIES
-        CXX_STANDARD 11
+        CXX_STANDARD 14


The C++ standard has been upgraded from C++11 to C++14. Ensure all code in the test suite is compatible with C++14 and that this change aligns with the project's overall C++ standard requirements. If other parts of the codebase still use C++11, this could create inconsistencies.

* RDKEMW-8289 - CEC is not working after an FSR

1.5.1 release 1.5.1

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

* RDKEMW-9750 HdmiCecSource/Sink issues Reason for change: Remove CEC device when there is a ping exception Test Procedure: Unplug the HDMI cable and check if the removeDevice() is called. Risks: None Priority: P1 * Update HdmiCecSourceImplementation.cpp * Update HdmiCecSourceImplementation.cpp * Update HdmiCecSourceImplementation.cpp --------- Co-authored-by: apatel859 <[email protected]>

1.5.2 release 1.5.2

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Prathyushakothuru requested a review from a team as a code owner June 13, 2025 07:32

pahearn73 added 27 commits September 21, 2025 17:40

Bump

fb6368a

Bump

7e5a30f

AVInput COM-RPC Support: WIP

a9560ee

AVInput COM-RPC Support: WIP

3ae42a8

AVInput COM-RPC Support: WIP

52893da

AVInput COM-RPC Support: WIP

ec503eb

AVInput COM-RPC Support: WIP

1b4a7f2

AVInput COM-RPC Support: WIP

993a82c

AVInput COM-RPC Support: WIP

7f5965b

AVInput COM-RPC Support: WIP

c54e20a

AVInput COM-RPC Support: WIP

bcfedaa

AVInput COM-RPC Support: WIP

e1d9232

AVInput COM-RPC Support: WIP

a5f64f1

AVInput COM-RPC Support: WIP

d6273a9

AVInput COM-RPC Support: WIP

d32d6e1

AVInput COM-RPC Support: WIP

b40aea1

AVInput COM-RPC Support: WIP

c29f7a8

AVInput COM-RPC Support: WIP

1c126f6

AVInput COM-RPC Support: WIP

22d895a

AVInput COM-RPC Support: WIP

9e45ed7

AVInput COM-RPC Support: WIP

91d9812

AVInput COM-RPC Support: WIP

20cd018

AVInput COM-RPC Support: WIP

91fef69

AVInput COM-RPC Support: WIP

5c6722b

AVInput COM-RPC Support: WIP

4f40172

Bump

16b1899

AVInput COM-RPC Support: WIP

7246f54

actions-user and others added 13 commits October 20, 2025 21:16

Merge tag '1.4.13' into develop

ad301b0

1.4.13 release 1.4.13

Merge branch 'release/1.4.13'

b6c22c5

Merge branch 'develop' into feature/RDKEMW-1008-COM-RPC_support

5c25bcf

Merge pull request #239 from rdkcentral/feature/RDKEMW-1008-COM-RPC_s…

0fd8062

…upport RDKEMW-1008: Add COM-RPC support to AVInput plugin

1.4.14 release changelog updates

daca60b

Merge branch 'release/1.4.14'

1e95563

Merge tag '1.4.14' into develop

0e03e5b

1.4.14 release 1.4.14

Revert "RDKEMW-1008: Add COM-RPC support to AVInput plugin"

6318efd

Merge pull request #274 from rdkcentral/revert-239-feature/RDKEMW-100…

11ab07e

…8-COM-RPC_support Revert "RDKEMW-1008: Add COM-RPC support to AVInput plugin"

1.4.15 release changelog updates

5fe8e2f

Merge tag '1.4.15' into develop

45974f6

1.4.15 release 1.4.15

Merge branch 'release/1.4.15'

cfd9297

Copilot AI review requested due to automatic review settings October 28, 2025 20:13

actions-user added 3 commits October 28, 2025 20:13

1.5.0 release changelog updates

43ea87a

Merge tag '1.5.0' into develop

57b9740

1.5.0 release 1.5.0

Merge branch 'release/1.5.0'

cfa181f

Copilot AI reviewed Oct 28, 2025

View reviewed changes

hgfell683 and others added 4 commits October 30, 2025 10:17

RDKEMW-8289 - CEC is not working after an FSR (#277)

184da28

* RDKEMW-8289 - CEC is not working after an FSR

1.5.1 release changelog updates

f74ef08

Merge tag '1.5.1' into develop

e9d3419

1.5.1 release 1.5.1

Merge branch 'release/1.5.1'

91344a0

Copilot AI review requested due to automatic review settings October 30, 2025 14:18

Copilot AI reviewed Oct 30, 2025

View reviewed changes

kiruba115 and others added 4 commits November 3, 2025 12:26

1.5.2 release changelog updates

9547f20

Merge branch 'release/1.5.2'

63337bd

Merge tag '1.5.2' into develop

6c107e7

1.5.2 release 1.5.2

Copilot AI review requested due to automatic review settings November 3, 2025 17:27

Copilot AI reviewed Nov 3, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

rebase #141

rebase #141

Uh oh!

Prathyushakothuru commented Jun 13, 2025

Uh oh!

github-advanced-security bot commented Jul 16, 2025

Uh oh!

CLAassistant commented Sep 1, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Oct 28, 2025

Uh oh!

Copilot AI Oct 28, 2025

Uh oh!

Copilot AI Oct 28, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

rebase #141

Are you sure you want to change the base?

rebase #141

Uh oh!

Conversation

Prathyushakothuru commented Jun 13, 2025

Uh oh!

github-advanced-security bot commented Jul 16, 2025

Uh oh!

CLAassistant commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

CLAassistant commented Sep 1, 2025 •

edited

Loading