RDKEMW-6230: Retry logic used dsGetHDMIARCPortId in HdmiCecSink #203
Conversation
Signed-off-by: yuvaramachandran_gurusamy <[email protected]>
Signed-off-by: yuvaramachandran_gurusamy <[email protected]>
Coverity Issue - Waiting while holding a lockCall to "usleep" might sleep while holding lock "lock._M_device". Medium Impact, CWE-667 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Parse warningtype qualifier on return type is meaningless Low Impact, CWE-398 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"hdmiPort" is copied and then passed-by-reference as parameter to STL insertion function "std::vector<WPEFramework::Plugin::HdmiPortMap, std::allocatorWPEFramework::Plugin::HdmiPortMap >::push_back(std::vector<WPEFramework::Plugin::HdmiPortMap, std::allocatorWPEFramework::Plugin::HdmiPortMap >::value_type const &)", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""hdmiPort"")" instead of "hdmiPort". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Uninitialized pointer fieldNon-static class member "msgFrameListener" is not initialized in this constructor nor in any functions that it calls. Medium Impact, CWE-457 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Dereference before null checkNull-checking "this->smConnection" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. Medium Impact, CWE-476 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"audiodescriptor" is passed-by-value as parameter to "WPEFramework::Core::JSON::ArrayTypeWPEFramework::Core::JSON::Variant::ArrayType(WPEFramework::Core::JSON::ArrayTypeWPEFramework::Core::JSON::Variant const &)", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""audiodescriptor"")" instead of "audiodescriptor". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Data race conditionA wait is performed without a loop. If there is a spurious wakeup, the condition may not be satisfied. [Note: The source code implementation of the function has been overridden by a builtin model.] Medium Impact, CWE-none How to fixCheck the wait condition in a loop, with the lock held. The lock must not be released between the condition and the wait. Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Uninitialized scalar variableUsing uninitialized value "hdmiPort". Field "hdmiPort.m_logicalAddr.impl" is uninitialized when calling "push_back". [Note: The source code implementation of the function has been overridden by a builtin model.] High Impact, CWE-457 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Check of thread-shared field evades lock acquisitionThread1 sets "m_currentArcRoutingState" to a new value. Now the two threads have an inconsistent view of "m_currentArcRoutingState" and updates to fields correlated with "m_currentArcRoutingState" may be lost. High Impact, CWE-543 How to fixGuard the modification of "m_currentArcRoutingState" and the read used to decide whether to modify "m_currentArcRoutingState" with the same set of locks. Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
RDKEMW-6230: Retry logic used dsGetHDMIARCPortId in HdmiCecSink
Signed-off-by: yuvaramachandran_gurusamy [email protected]