RDKEMW-6331 : Fix HdmiCecSink COM-RPC issues #217

smanes0213 · 2025-07-31T10:45:41Z

Reason for change : COM-RPC Implementation with fixes for -
getDeviceList does not return proper json tags in response.
Populating powerStatus instead of portNumber.
Added RequestAudioDevicePowerStatus API
Risks: Medium

Reason for change : COM-RPC Implementation with fixes for - getDeviceList does not return proper json tags in response. Populating powerStatus instead of portNumber. Added RequestAudioDevicePowerStatus API Signed-off-by: smanes0213 <[email protected]>

.github/workflows/L1-tests.yml

HdmiCecSink/HdmiCecSinkImplementation.cpp

apatel859 · 2025-08-18T22:38:37Z

HdmiCecSink/HdmiCecSinkImplementation.cpp

+#include "ccec/MessageEncoder.hpp"
+#include "host.hpp"
+#include "UtilsgetRFCConfig.h"
+


Along with comparing the JSON RPC could you also share the custom build with DEV QA to perform the sanity check for HdmiCec feature and make sure no regression observed before we merge. Otherwise im ok with code changes

I have shared the custom build with QA waiting for the results from their side.

rdkcmf-jenkins · 2025-09-17T05:58:23Z

HdmiCecSink/HdmiCecSinkImplementation.cpp

+                            device.osdName = HdmiCecSinkImplementation::_instance->deviceList[route[i]].m_osdName.toString().c_str();
+                            device.vendorID = HdmiCecSinkImplementation::_instance->deviceList[route[i]].m_vendorID.toString().c_str();
+
+                            paths.push_back(device);


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Variable copied when it could be moved

"device" is copied and then passed-by-reference as parameter to STL insertion function "std::vector<WPEFramework::Exchange::IHdmiCecSink::HdmiCecSinkActivePath, std::allocatorWPEFramework::Exchange::IHdmiCecSink::HdmiCecSinkActivePath >::push_back(std::vector<WPEFramework::Exchange::IHdmiCecSink::HdmiCecSinkActivePath, std::allocatorWPEFramework::Exchange::IHdmiCecSink::HdmiCecSinkActivePath >::value_type const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""device"")" instead of "device".

rdkcmf-jenkins · 2025-09-17T05:58:23Z

HdmiCecSink/HdmiCecSinkImplementation.cpp

+        }
+
+
+       const void HdmiCecSinkImplementation::InitializeIARM()


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Parse warning

type qualifier on return type is meaningless

Low Impact, CWE-398
PW.USELESS_TYPE_QUALIFIER_ON_RETURN_TYPE

rdkcmf-jenkins · 2025-09-17T05:58:23Z

HdmiCecSink/HdmiCecSinkImplementation.cpp

+           for (int i = 0; i < m_numofHdmiInput; i++){
+                HdmiPortMap hdmiPort((uint8_t)i);
+                LOGINFO(" Add to vector [%d] \n", i);
+                hdmiInputs.push_back(hdmiPort);


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Variable copied when it could be moved

"hdmiPort" is copied and then passed-by-reference as parameter to STL insertion function "std::vector<WPEFramework::Plugin::HdmiPortMap, std::allocatorWPEFramework::Plugin::HdmiPortMap >::push_back(std::vector<WPEFramework::Plugin::HdmiPortMap, std::allocatorWPEFramework::Plugin::HdmiPortMap >::value_type const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""hdmiPort"")" instead of "hdmiPort".

rdkcmf-jenkins · 2025-09-17T05:58:24Z

HdmiCecSink/HdmiCecSink.cpp

-                       case NUMBER_9:
-                           _instance->smConnection->sendTo(LogicalAddress(logicalAddress), MessageEncoder().encode(UserControlPressed(UICommand::UI_COMMAND_NUM_9)), 100);
-                           break;
+           if(nullptr != _hdmiCecSink)


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Dereference before null check

Null-checking "this->_hdmiCecSink" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.

Medium Impact, CWE-476
REVERSE_INULL

Only dereference the pointer if not NULL.

rdkcmf-jenkins · 2025-09-17T05:58:24Z

HdmiCecSink/HdmiCecSinkImplementation.cpp

+        {
+            audiodescriptor.Add(descriptor);
+        }
+       HdmiCecSinkImplementation::_instance->Send_ShortAudioDescriptor_Event(audiodescriptor);


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Variable copied when it could be moved

"audiodescriptor" is passed-by-value as parameter to "WPEFramework::Core::JSON::ArrayTypeWPEFramework::Core::JSON::Variant::ArrayType(WPEFramework::Core::JSON::ArrayTypeWPEFramework::Core::JSON::Variant const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""audiodescriptor"")" instead of "audiodescriptor".

rdkcmf-jenkins · 2025-09-17T05:58:24Z

HdmiCecSink/HdmiCecSinkImplementation.cpp

+        , _registeredEventHandlers(false)
+       {
+           LOGWARN("Initlaizing HdmiCecSinkImplementation");
+       }


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Uninitialized scalar field

Non-static class member "cecEnableStatus" is not initialized in this constructor nor in any functions that it calls.

Medium Impact, CWE-457
UNINIT_CTOR

rdkcmf-jenkins · 2025-09-17T05:58:24Z

HdmiCecSink/HdmiCecSinkImplementation.cpp

+                stopArc();
+                while(m_currentArcRoutingState != ARC_STATE_ARC_TERMINATED)    
+                {
+                     usleep(500000);


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Waiting while holding a lock

Call to "usleep" might sleep while holding lock "lock._M_device".

Medium Impact, CWE-667
SLEEP

rdkcmf-jenkins · 2025-09-17T05:58:24Z

HdmiCecSink/HdmiCecSinkImplementation.cpp

+                }
+
+                std::unique_lock<std::mutex> lk(_instance->m_pollExitMutex);
+                if ( _instance->m_ThreadExitCV.wait_for(lk, std::chrono::milliseconds(_instance->m_sleepTime)) == std::cv_status::timeout )


Coverity Issue - Data race condition

A wait is performed without a loop. If there is a spurious wakeup, the condition may not be satisfied. [Note: The source code implementation of the function has been overridden by a builtin model.]

Medium Impact, CWE-none
BAD_CHECK_OF_WAIT_COND

How to fix

Check the wait condition in a loop, with the lock held. The lock must not be released between the condition and the wait.

Will resolve this as part of this ticket : https://ccp.sys.comcast.net/browse/RDKEMW-8431

rdkcmf-jenkins · 2025-09-17T05:58:24Z

HdmiCecSink/HdmiCecSinkImplementation.cpp

+            }
+            msgProcessor = new HdmiCecSinkProcessor(*smConnection);
+            msgFrameListener = new HdmiCecSinkFrameListener(*msgProcessor);
+            if(smConnection)


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Dereference before null check

Null-checking "this->smConnection" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.

Medium Impact, CWE-476
REVERSE_INULL

rdkcmf-jenkins · 2025-09-17T05:58:24Z

HdmiCecSink/HdmiCecSinkImplementation.h

+        PowerManagerInterfaceRef _powerManagerPlugin;
+        Core::Sink<PowerManagerNotification> _pwrMgrNotification;
+        bool _registeredEventHandlers;
+        const void InitializeIARM();


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Parse warning

type qualifier on return type is meaningless

Low Impact, CWE-398
PW.USELESS_TYPE_QUALIFIER_ON_RETURN_TYPE

rdkcmf-jenkins · 2025-09-17T16:02:47Z

HdmiCecSink/HdmiCecSinkImplementation.cpp

+            {
+                stopArc();
+                while (m_currentArcRoutingState != ARC_STATE_ARC_TERMINATED) {
+                    usleep(500000);


Coverity Issue - Waiting while holding a lock

Call to "usleep" might sleep while holding lock "lock._M_device".

Medium Impact, CWE-667
SLEEP

Will resolve this as part of this ticket : https://ccp.sys.comcast.net/browse/RDKEMW-8431

rdkcmf-jenkins · 2025-09-18T12:04:29Z

HdmiCecSink/HdmiCecSinkImplementation.cpp

+        , _registeredEventHandlers(false)
+        {
+            LOGWARN("Initializing HdmiCecSinkImplementation");
+        }


Coverity Issue - Uninitialized pointer field

Non-static class member "msgFrameListener" is not initialized in this constructor nor in any functions that it calls.

Medium Impact, CWE-457
UNINIT_CTOR

Will resolve this as part of this ticket : https://ccp.sys.comcast.net/browse/RDKEMW-8431

smanes0213 requested a review from a team as a code owner July 31, 2025 10:45

smanes0213 added 19 commits August 1, 2025 16:14

Update HdmiCecSinkImplementation.cpp

3eca45b

Merge branch 'develop' into feature/RDKEMW-6331

07bfb4d

Update HdmiCecSinkImplementation.cpp

545eac8

Add debug prints

152368f

Merge branch 'develop' into feature/RDKEMW-6331

94abdce

Added additional debug prints

571d5d2

resolved compilation errors

8d0d0c2

Update HdmiCecSinkImplementation.cpp

dcab426

Resolved value assignment swap

6df9055

Update HdmiCecSinkImplementation.cpp

5d0ce2c

Delete wpeframework.log

b12baa5

update HdmiCecSinkImplementation.h

ac4b1c5

Delete wpelatest.log

c487463

Resolved GetActiveRoute length issue

b8a9f0a

Merge branch 'develop' into feature/RDKEMW-6331

194d2c9

Add additional logging to check SetActivePath functionality

83c3ff8

Remove all the debug prints from the HdmiCecSink Implementation file.

c8d85b7

Rename the HdmiCecSinkSuccess structure objects.

678ac0c

Update HdmiCecSinkImplementation.cpp

409910c

apatel859 reviewed Aug 18, 2025

View reviewed changes

.github/workflows/L1-tests.yml Show resolved Hide resolved

apatel859 reviewed Aug 18, 2025

View reviewed changes

HdmiCecSink/HdmiCecSinkImplementation.cpp Outdated Show resolved Hide resolved

apatel859 reviewed Aug 18, 2025

View reviewed changes

smanes0213 added 6 commits August 19, 2025 10:58

Update CMakeLists.txt

fa780ab

Update HdmiCecSink.cpp

4f72771

Update HdmiCecSink.h

86ac62a

Update HdmiCecSinkImplementation.cpp

270f06c

Update HdmiCecSinkImplementation.h

afa7e5d

Update CMakeLists.txt

7125314

smanes0213 added 9 commits September 12, 2025 22:32

Adding CCEC Namespace

991452f

Adding CCEC Namespace

a11f608

Update CCEC namespace

9b76bf0

Create Alias for the conflicting CCEC lib calls

87dfd6c

Update test_HdmiCecSource.cpp

4fc278e

Update HdmiCecSourceImplementation.cpp

b89e125

Update HdmiCecSourceImplementation.cpp

9b7632f

Create Alias for the conflicting CCEC lib calls

b155583

Update CMakeLists.txt

dfa14ff

apatel859 previously approved these changes Sep 16, 2025

View reviewed changes

Update build_dependencies.sh

c545a6d

smanes0213 dismissed apatel859’s stale review via c545a6d September 17, 2025 05:41

rdkcmf-jenkins reviewed Sep 17, 2025

View reviewed changes

smanes0213 added 8 commits September 17, 2025 16:26

Resolve Coverity issues

84199ab

Resolve Coverity issues

be00ea5

Resolve native build errors

a9fadc5

Resolve native build errors

6db7159

Resolve Coverity issues

5023219

Resolve Coverity issues

3aba951

Resolve Coverity issues

7a8d57c

Resolve Coverity issues

91f4498

rdkcmf-jenkins reviewed Sep 17, 2025

View reviewed changes

smanes0213 added 4 commits September 17, 2025 21:38

Resolve Coverity issues

08cacfd

Update Implementation file

96aba90

Update Implementation file

2cfcfff

Update Implementation file

597b41f

rdkcmf-jenkins reviewed Sep 18, 2025

View reviewed changes

smanes0213 added 3 commits September 18, 2025 19:50

Update Implementation file

a82c13b

Update Implementation file

8b6305e

Update Implementation

2ba51af

RDKEMW-6331 : Fix HdmiCecSink COM-RPC issues #217

Are you sure you want to change the base?

RDKEMW-6331 : Fix HdmiCecSink COM-RPC issues #217

Uh oh!

Conversation

smanes0213 commented Jul 31, 2025

Uh oh!

Uh oh!

Uh oh!

apatel859 Aug 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

smanes0213 Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

rdkcmf-jenkins Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Variable copied when it could be moved

How to fix

Uh oh!

rdkcmf-jenkins Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Parse warning

Uh oh!

rdkcmf-jenkins Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Variable copied when it could be moved

How to fix

Uh oh!

rdkcmf-jenkins Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Dereference before null check

Uh oh!

smanes0213 Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

rdkcmf-jenkins Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Variable copied when it could be moved

How to fix

Uh oh!

rdkcmf-jenkins Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Uninitialized scalar field

Uh oh!

rdkcmf-jenkins Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Waiting while holding a lock

Uh oh!

rdkcmf-jenkins Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Data race condition

How to fix

Uh oh!

smanes0213 Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

rdkcmf-jenkins Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Dereference before null check

Uh oh!

rdkcmf-jenkins Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Parse warning

Uh oh!

rdkcmf-jenkins Sep 17, 2025

Choose a reason for hiding this comment

Coverity Issue - Waiting while holding a lock

Uh oh!

apatel859 Aug 18, 2025 •

edited

Loading

rdkcmf-jenkins Sep 17, 2025 •

edited

Loading

rdkcmf-jenkins Sep 17, 2025 •

edited

Loading

rdkcmf-jenkins Sep 17, 2025 •

edited

Loading

rdkcmf-jenkins Sep 17, 2025 •

edited

Loading

rdkcmf-jenkins Sep 17, 2025 •

edited

Loading

rdkcmf-jenkins Sep 17, 2025 •

edited

Loading

rdkcmf-jenkins Sep 17, 2025 •

edited

Loading

rdkcmf-jenkins Sep 17, 2025 •

edited

Loading

rdkcmf-jenkins Sep 17, 2025 •

edited

Loading

rdkcmf-jenkins Sep 17, 2025 •

edited

Loading

rdkcmf-jenkins Sep 18, 2025 •

edited

Loading