Skip to content

RDKEMW-6718 : Add support for plugin specific error codes in entservices-apis #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

RDKEMW-6718 : Add support for plugin specific error codes in entservices-apis #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8f69cc2
RDKEMW-6718 : Update HdcpProfileImplementation.cpp with test code
ssitar583 Aug 12, 2025
e17eda7
RDKEMW-6718: Update HdcpProfile.cpp
ssitar583 Aug 12, 2025
51ac511
RDKEMW-6718: Update HdcpProfile.h
ssitar583 Aug 12, 2025
a837da1
Update HdcpProfile.cpp
ssitar583 Aug 13, 2025
c36fa71
Merge pull request #236 from rdkcentral/develop
ssitar583 Aug 22, 2025
b7f1cfe
Update HdcpProfile.cpp
ssitar583 Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion HdcpProfile/HdcpProfile.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ namespace WPEFramework
SERVICE_REGISTRATION(HdcpProfile, API_VERSION_NUMBER_MAJOR, API_VERSION_NUMBER_MINOR, API_VERSION_NUMBER_PATCH);

HdcpProfile::HdcpProfile()
: _service(nullptr)
: PluginHost::JSONRPCErrorAssessor<PluginHost::JSONRPCErrorAssessorTypes::FunctionCallbackType>(HdcpProfile::OnJSONRPCError)
,_service(nullptr)
, _connectionId(0)
, _hdcpProfile(nullptr)
, _hdcpProfileNotification(this)
Expand Down Expand Up @@ -163,6 +164,16 @@ namespace WPEFramework
return ("This HdcpProfile Plugin facilitates to persist event data for monitoring applications");
}

uint32_t HdcpProfile::OnJSONRPCError(const Core::JSONRPC::Context&, const string& method, const string& parameters, const uint32_t errorcode, string& errormessage) {
LOGINFO("DBG:OnJSONRPCERROR");
if(method == _T("getHDCPStatus") && (errorcode >= static_cast<uint32_t>(ERROR_BASE) && errorcode < static_cast<uint32_t>(MAX_ERROR_CODE) ))
{
LOGINFO("DBG-Inside If");
errormessage = ERROR_MESSAGE(errorcode);
}
return errorcode;
}

void HdcpProfile::Deactivated(RPC::IRemoteConnection *connection)
{
if (connection->Id() == _connectionId)
Expand Down
3 changes: 2 additions & 1 deletion HdcpProfile/HdcpProfile.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ namespace WPEFramework {

namespace Plugin {

class HdcpProfile : public PluginHost::IPlugin, public PluginHost::JSONRPC
class HdcpProfile : public PluginHost::IPlugin, public PluginHost::JSONRPCErrorAssessor<PluginHost::JSONRPCErrorAssessorTypes::FunctionCallbackType>
{
private:
class Notification : public RPC::IRemoteConnection::INotification, public Exchange::IHdcpProfile::INotification
Expand Down Expand Up @@ -97,6 +97,7 @@ namespace WPEFramework {
const string Initialize(PluginHost::IShell* service) override;
void Deinitialize(PluginHost::IShell* service) override;
string Information() const override;
static uint32_t OnJSONRPCError(const Core::JSONRPC::Context& context, const string& method, const string& parameters, const uint32_t errorcode, string& errormessage);

private:
void Deactivated(RPC::IRemoteConnection* connection);
Expand Down
17 changes: 17 additions & 0 deletions HdcpProfile/HdcpProfileImplementation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,23 @@
Core::hresult HdcpProfileImplementation::GetHDCPStatus(HDCPStatus& hdcpstatus,bool& success)
{
success = GetHDCPStatusInternal(hdcpstatus);
if(fopen("/opt/check1.txt","r")!=NULL)
{
return ERROR_FILE_IO;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems we have matching error codes in Thunder: https://github.com/rdkcentral/Thunder/blob/master/Source/core/Portability.h#L926

}
else if(fopen("/opt/check2.txt","r")!=NULL)
{
return ERROR_PERMISSION_DENIED;
}
else if(fopen("/opt/check3.txt","r")!=NULL)
{
return ERROR_BASE;
}
else if(fopen("/opt/check4.txt","r")!=NULL)
{
return MAX_ERROR_CODE;
}
return Core::ERROR_NONE;
return Core::ERROR_NONE;
}

Expand Down
Loading