[RDKEMW-6163] [RDKEMW-6164] CEC source and sink changes #244

karuppaiyak · 2025-09-04T12:12:38Z

No description provided.

* RDKEMW-7169 - Gtest Add missing empty files * RDKEMW-7169 - Gtest Add missing empty files * RDKEMW-7169 - Gtest Add missing empty files * RDKEMW-7169 - Gtest Add missing empty files * RDKEMW-7169 - Gtest Add missing empty files --------- Co-authored-by: Srikanth <[email protected]>

1.4.6 release 1.4.6

skamath

Make sure to remove dsMgr.h and other unused header from all plugins.

skamath · 2025-09-05T05:50:07Z

HdmiCecSource/HdmiCecSourceImplementation.cpp

@@ -418,6 +425,11 @@ namespace WPEFramework
            {
                //TODO(MROLLINS) this is probably per process so we either need to be running in our own process or be carefull no other plugin is calling it
                device::Manager::Initialize();
+
+#ifndef IO_HCEC_ENABLE_IARM
+                device::Host::getInstance().Register(this, "WPE[HdmiCecSource]");


better to truncate clientName to less than 11 chars so that, small string optimization is used, take care at all instances. Also I see in other PR's WPE:: convention is used.

HdmiCecSource/HdmiCecSourceImplementation.cpp

skamath · 2025-09-05T06:09:07Z

HdmiCecSink/HdmiCecSink.cpp

           InitializeIARM();
+#else
+           device::Host::getInstance().Register(this, "WPE[HdmiCecSink]");


Is device::manager::Initialize() called before register ?

Copilot

Pull Request Overview

This PR introduces HdmiCecSource and HdmiCecSink changes that provide alternative implementations for HDMI event handling by adding support for direct device host interfaces alongside existing IARM-based implementations.

Key changes include:

Addition of conditional compilation support via IO_HCEC_ENABLE_IARM preprocessor flag
Implementation of device::Host event interface callbacks as alternatives to IARM event handlers
Enhanced error handling and initialization logic for device manager components

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
HdmiCecSource/HdmiCecSourceImplementation.h	Adds IDisplayDeviceEvents interface inheritance and OnDisplayHDMIHotPlug declaration
HdmiCecSource/HdmiCecSourceImplementation.cpp	Implements conditional IARM vs device::Host event handling with preprocessor guards
HdmiCecSink/HdmiCecSink.h	Adds IHdmiInEvents interface inheritance and OnHdmiInEventHotPlug declaration
HdmiCecSink/HdmiCecSink.cpp	Refactors initialization with device manager setup and conditional IARM/device::Host implementations

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-09T12:02:03Z

HdmiCecSink/HdmiCecSink.cpp

+#if 0 //just to verify compilation
+          device::HdmiInput::getInstance().getHDMIARCPortId(&portId);
+#else
+          portId = 0;
+#endif


The commented-out code with #if 0 suggests unfinished implementation. This hardcoded portId = 0 assignment bypasses the actual device API call and could lead to incorrect behavior in production. Either implement the proper API call or add a TODO comment explaining why this is temporarily disabled.

Suggested change

#if 0 //just to verify compilation

device::HdmiInput::getInstance().getHDMIARCPortId(&portId);

#else

portId = 0;

#endif

// TODO: Replace hardcoded portId assignment with actual device API call when available.

// device::HdmiInput::getInstance().getHDMIARCPortId(&portId);

portId = 0;

Copilot · 2025-09-09T12:02:03Z

HdmiCecSink/HdmiCecSink.cpp

+                   LOGINFO("Number of Inputs [%d] \n", hdmiInput.numHdmiInputs );
+                   m_numofHdmiInput = hdmiInput.numHdmiInputs;
+              }else{
+                   LOGINFO("Not able to get Numebr of inputs so defaulting to 3 \n");


"Numebr" is misspelled and should be "Number".

Suggested change

LOGINFO("Not able to get Numebr of inputs so defaulting to 3 \n");

LOGINFO("Not able to get Number of inputs so defaulting to 3 \n");

RDKEMW-7712: Sync low latency for AVOutput initialization (#6338)

1.4.7 release 1.4.7

Copilot

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

HdmiCecSource/HdmiCecSourceImplementation.cpp

HdmiCecSink/HdmiCecSink.cpp

Copilot · 2025-09-17T09:01:16Z

HdmiCecSink/HdmiCecSink.cpp

-						isAnyPortConnected = true;
-					}
+                LOGINFO("update Port Status [%d] \n", i);
+                hdmiInputs[i].update(device::HdmiInput::getInstance().isPortConnected(i));


The isPortConnected call could throw an exception if the port index is invalid or the HdmiInput instance is not properly initialized. Consider adding bounds checking and exception handling around this call.

Suggested change

hdmiInputs[i].update(device::HdmiInput::getInstance().isPortConnected(i));

bool isConnected = false;

try {

// If HdmiInput provides a method to get the number of ports, use it for bounds checking

int numPorts = device::HdmiInput::getInstance().getNumberOfPorts();

if (i >= 0 && i < numPorts) {

isConnected = device::HdmiInput::getInstance().isPortConnected(i);

} else {

LOGERR("Port index [%d] is out of range [0, %d)", i, numPorts);

}

} catch (const std::exception& ex) {

LOGERR("Exception in isPortConnected(%d): %s", i, ex.what());

} catch (...) {

LOGERR("Unknown exception in isPortConnected(%d)", i);

}

hdmiInputs[i].update(isConnected);

Copilot · 2025-09-17T09:01:16Z

HdmiCecSink/HdmiCecSink.cpp

+			do {
+				usleep(50000); // Sleep for 50ms before retrying
+				portId = -1;
+				device::HdmiInput::getInstance().getHDMIARCPortId(&portId);


The getHDMIARCPortId call lacks error handling. If this method throws an exception or fails, the retry logic may not work as expected. Consider wrapping this in a try-catch block to handle potential failures gracefully.

Suggested change

device::HdmiInput::getInstance().getHDMIARCPortId(&portId);

try {

device::HdmiInput::getInstance().getHDMIARCPortId(&portId);

} catch (const std::exception& ex) {

LOGERR("Exception in getHDMIARCPortId: %s (retry count[%d])", ex.what(), retryCount);

// Continue to next retry

} catch (...) {

LOGERR("Unknown exception in getHDMIARCPortId (retry count[%d])", retryCount);

// Continue to next retry

}

skamath · 2025-09-17T09:08:18Z

HdmiCecSink/HdmiCecSink.cpp

-				LOGINFO(" Add to vector [%d] \n", i);
-				hdmiInputs.push_back(hdmiPort);
-			}
+               m_numofHdmiInput = device::HdmiInput::getInstance().getNumberOfInputs();


This can throw exception, see

CLAassistant · 2025-09-17T15:05:46Z

All committers have signed the CLA.

karuppaiyak requested a review from a team as a code owner September 4, 2025 12:12

hgfell683 and others added 4 commits September 4, 2025 11:29

1.4.6 release changelog updates

7a0d569

Merge tag '1.4.6' into develop

bef0aa3

1.4.6 release 1.4.6

Merge branch 'release/1.4.6'

7c031cf

skamath requested a review from Copilot September 5, 2025 05:52

This comment was marked as outdated.

Sign in to view

skamath reviewed Sep 5, 2025

View reviewed changes

skamath requested a review from Copilot September 9, 2025 12:01

Copilot AI reviewed Sep 9, 2025

View reviewed changes

arjunbinu and others added 5 commits September 9, 2025 16:40

RDKEMW-7712: Sync low latency for AVOutput initialization (#6338)

b334b82

Merge pull request #249 from rdkcentral/feature/RDKEMW-7712

81cc8f5

RDKEMW-7712: Sync low latency for AVOutput initialization (#6338)

1.4.7 release changelog updates

5979423

Merge branch 'release/1.4.7'

2bf6395

Merge tag '1.4.7' into develop

1ea0522

1.4.7 release 1.4.7

skamath requested a review from Copilot September 17, 2025 08:59

Copilot AI reviewed Sep 17, 2025

View reviewed changes

skamath reviewed Sep 17, 2025

View reviewed changes

karuppaiyak force-pushed the feature/RDKEMW-6163-c1 branch from bc803aa to 95d7e4f Compare September 17, 2025 15:05

karuppaiyak force-pushed the feature/RDKEMW-6163-c1 branch 8 times, most recently from e34b4c5 to 73a1113 Compare September 19, 2025 13:01

karuppaiyak added 2 commits September 19, 2025 18:31

CEC source and sink changes

919f2de

added host.hpp

4d59de8

karuppaiyak added 15 commits September 19, 2025 18:31

base interface template change

54daae7

copilot warnings

8a169f8

review comments added

2965ff4

moved device setting init to plugin init

b45107c

reverted changes in HdmiCecSource/HdmiCecSource.cpp

8606999

reverted init failure

1ba78d1

test1

1bcbf2b

compilation fixed

cfc3f0c

added exception handling

ff9fcdb

corrected reference

dee3405

handled return value

39b9eef

unit test addition

f41b6f4

removed tests-trigger changes

1e0b57c

L1 unit test for source

5797322

instance pb

0951d07

karuppaiyak force-pushed the feature/RDKEMW-6163-c1 branch from 73a1113 to 0951d07 Compare September 19, 2025 13:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[RDKEMW-6163] [RDKEMW-6164] CEC source and sink changes #244

[RDKEMW-6163] [RDKEMW-6164] CEC source and sink changes #244

Uh oh!

karuppaiyak commented Sep 4, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

skamath left a comment

Uh oh!

skamath Sep 5, 2025

Uh oh!

Uh oh!

Uh oh!

skamath Sep 5, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Sep 9, 2025

Uh oh!

Copilot AI Sep 9, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Sep 17, 2025

Uh oh!

Copilot AI Sep 17, 2025

Uh oh!

skamath Sep 17, 2025

Uh oh!

CLAassistant commented Sep 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

	LOGINFO("Not able to get Numebr of inputs so defaulting to 3 \n");
	LOGINFO("Not able to get Number of inputs so defaulting to 3 \n");

-                hdmiInputs[i].update(device::HdmiInput::getInstance().isPortConnected(i));
+                bool isConnected = false;
+                try {
+                    // If HdmiInput provides a method to get the number of ports, use it for bounds checking
+                    int numPorts = device::HdmiInput::getInstance().getNumberOfPorts();
+                    if (i >= 0 && i < numPorts) {
+                        isConnected = device::HdmiInput::getInstance().isPortConnected(i);
+                    } else {
+                        LOGERR("Port index [%d] is out of range [0, %d)", i, numPorts);
+                    }
+                } catch (const std::exception& ex) {
+                    LOGERR("Exception in isPortConnected(%d): %s", i, ex.what());
+                } catch (...) {
+                    LOGERR("Unknown exception in isPortConnected(%d)", i);
+                }
+                hdmiInputs[i].update(isConnected);

[RDKEMW-6163] [RDKEMW-6164] CEC source and sink changes #244

Are you sure you want to change the base?

[RDKEMW-6163] [RDKEMW-6164] CEC source and sink changes #244

Uh oh!

Conversation

karuppaiyak commented Sep 4, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

skamath left a comment

Choose a reason for hiding this comment

Uh oh!

skamath Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

skamath Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

skamath Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

CLAassistant commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

CLAassistant commented Sep 17, 2025 •

edited

Loading