[RDKEMW-6168] Update AVInput with libds client library notifications #248
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the AVInput plugin to replace IARM-based event handling with the libds client library notification system. This modernizes the event handling architecture to use direct device library callbacks instead of bus-based events.
- Replaces IARM event registration with device library interface implementation
- Implements callback methods for HDMI and Composite input events
- Migrates from InitializeIARM/DeinitializeIARM to device::Manager initialization
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| AVInput/AVInput.h | Adds inheritance from device event interfaces and declares new callback methods |
| AVInput/AVInput.cpp | Replaces IARM initialization with device manager and implements libds callbacks |
| .github/workflows/tests-trigger.yml | Adds feature branch to CI workflow triggers |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
That is legacy code, which was already exist , so I added the same |
AVInput/AVInput.h
Outdated
| void OnCompositeInHotPlug(dsCompositeInPort_t port, bool isConnected) override; | ||
| void OnCompositeInSignalStatus(dsCompositeInPort_t port, dsCompInSignalStatus_t signalStatus) override; | ||
| void OnCompositeInStatus(dsCompositeInPort_t activePort, bool isPresented) override; | ||
| void OnCompositeInVideoModeUpdate(dsCompositeInPort_t activePort, dsVideoPortResolution_t videoResolution) ; |
There was a problem hiding this comment.
still override is missing for OnHdmiInEventStatus and OnCompositeInVideoModeUpdate. pls correct it.
AVInput/AVInput.cpp
Outdated
| LOGINFO("device::Manager::Initialize success"); | ||
| if (!_registeredDsEventHandlers) { | ||
| _registeredDsEventHandlers = true; | ||
| device::Host::getInstance().Register(baseInterface<device::Host::IHdmiInEvents>(), "WPE::HdmiInEvents"); |
There was a problem hiding this comment.
this should be client name for example WPE::AVInputHdmi and WPE::AVInputComp for both hdmi and composite or shorter version of this.
AVInput/AVInput.cpp
Outdated
| { | ||
| LOGINFO("device::Manager::Initialize failed"); | ||
| LOG_DEVICE_EXCEPTION0(); | ||
| return std::string("AVInput: Initialization failed"); |
There was a problem hiding this comment.
return will fail the plugin initialization. i think as per the latest discussion, we sshould continue plugin init though device::Manager::Initialize() fails. you can discuss with dixit for double confirmation if u want.
AVInput/AVInput.cpp
Outdated
| try | ||
| { | ||
| device::Manager::DeInitialize(); | ||
| LOGINFO("device::Manager::DeInitialize success"); |
There was a problem hiding this comment.
correct the try-catch block alignment wrt other places where it is already used.
No description provided.