-
Notifications
You must be signed in to change notification settings - Fork 3
RDKEMW-9633: Advanced PQ AVOutput #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Rebase with develop
RDKEMW-5197 : Advance PQParams MW Changes
… GetCMSCaps implementation
… missing GetCMSCaps implementation" This reverts commit d229924.
RDKEMW-5197 : Add Missed out changes in support/pq_dvt1.1
RDKEMW-5197 : Enable CMS sync
RDKEMW-5197 : Add Changes for getVideoSource and getVideoFormat Caps
|
skk451 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds advanced PQ (Picture Quality) parameters support to the AVOutput RDK Service by implementing a V2 interface with JSON-based parameter handling. The key changes include introducing new methods for advanced PQ parameters (AI Super Resolution, MEMC, SDR Gamma, etc.), refactoring parameter storage/retrieval to use context-based capabilities, and adding a worker thread for efficient multi-context parameter updates.
- JSON-based V2 API for context-aware PQ parameter management
- New advanced PQ parameters: AISuperResolution, PrecisionDetail, LocalContrastEnhancement, MPEGNoiseReduction, DigitalNoiseReduction, MEMC, SDRGamma
- Worker thread architecture for efficient batch parameter updates
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| AVOutput/CHANGELOG.md | Added version 1.2.0 entry for Advanced PQ Params feature and removed merge conflict marker |
| AVOutput/AVOutputTVHelper.cpp | Implemented V2 parameter handling with context-based capabilities, JSON parsing, worker thread for batch updates, and new helper functions for advanced PQ parameters |
| AVOutput/AVOutputTV.h | Added V2 API declarations, worker thread members, capability members for new PQ parameters, and static mapping tables for parameter conversions |
| AVOutput/AVOutput.cpp | Updated service registration to use versioned metadata with version 1.1.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.