Skip to content

Conversation

@utkarshece14
Copy link
Contributor

No description provided.

aktamilbe and others added 18 commits August 18, 2025 13:19
RDKEMW-5197 : Advance PQParams MW Changes
… missing GetCMSCaps implementation"

This reverts commit d229924.
RDKEMW-5197 : Add Missed out changes in support/pq_dvt1.1
RDKEMW-5197 : Enable CMS sync
RDKEMW-5197 : Add Changes for getVideoSource and getVideoFormat Caps
@utkarshece14 utkarshece14 requested a review from a team as a code owner October 23, 2025 14:53
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ aktamilbe
✅ utkarshece14
❌ skk451


skk451 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot AI review requested due to automatic review settings November 5, 2025 14:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds advanced PQ (Picture Quality) parameters support to the AVOutput RDK Service by implementing a V2 interface with JSON-based parameter handling. The key changes include introducing new methods for advanced PQ parameters (AI Super Resolution, MEMC, SDR Gamma, etc.), refactoring parameter storage/retrieval to use context-based capabilities, and adding a worker thread for efficient multi-context parameter updates.

  • JSON-based V2 API for context-aware PQ parameter management
  • New advanced PQ parameters: AISuperResolution, PrecisionDetail, LocalContrastEnhancement, MPEGNoiseReduction, DigitalNoiseReduction, MEMC, SDRGamma
  • Worker thread architecture for efficient batch parameter updates

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 6 comments.

File Description
AVOutput/CHANGELOG.md Added version 1.2.0 entry for Advanced PQ Params feature and removed merge conflict marker
AVOutput/AVOutputTVHelper.cpp Implemented V2 parameter handling with context-based capabilities, JSON parsing, worker thread for batch updates, and new helper functions for advanced PQ parameters
AVOutput/AVOutputTV.h Added V2 API declarations, worker thread members, capability members for new PQ parameters, and static mapping tables for parameter conversions
AVOutput/AVOutput.cpp Updated service registration to use versioned metadata with version 1.1.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@utkarshece14 utkarshece14 merged commit 0773b01 into develop Nov 5, 2025
18 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants