L1run #105
L1run #105
Conversation
Coverity Issue - Uninitialized scalar variableUsing uninitialized value "result". High Impact, CWE-457 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Logically dead codeExecution cannot reach this statement: "this->m_statusMutex.lock();". Medium Impact, CWE-561 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Resource leakVariable "fp" going out of scope leaks the storage it points to. High Impact, CWE-404 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Data race conditionAccessing "this->g_task_status" without holding lock "WPEFramework::Plugin::MaintenanceManager.m_statusMutex". Elsewhere, "WPEFramework::Plugin::MaintenanceManager.g_task_status" is written to with "MaintenanceManager.m_statusMutex" held 13 out of 16 times. Medium Impact, CWE-366 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Data race conditionAccessing "this->m_task_map" without holding lock "WPEFramework::Plugin::MaintenanceManager.m_statusMutex". Elsewhere, "WPEFramework::Plugin::MaintenanceManager.m_task_map" is written to with "MaintenanceManager.m_statusMutex" held 11 out of 15 times. Medium Impact, CWE-366 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Unchecked return valueCalling "Invoke" without checking return value (as is done elsewhere 1 out of 1 times). Medium Impact, CWE-252 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Logically dead codeExecution cannot reach this statement: "exitOnNoNetwork = true;". Medium Impact, CWE-561 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Variable copied when it could be moved"joGetResult" is passed-by-value as parameter to "WPEFramework::Core::JSON::VariantContainer::VariantContainer(WPEFramework::Core::JSON::VariantContainer const &)", when it could be moved instead. Low Impact, CWE-none How to fixUse "std::move(""joGetResult"")" instead of "joGetResult". Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
| TEST_F(MaintenanceManagerTest, IarmEventHandler_RFCComplete_TaskActive_CompletesTask) { | ||
| plugin_->m_abort_flag = false; | ||
| plugin_->m_notify_status = MAINTENANCE_STARTED; | ||
| plugin_->m_task_map[WPEFramework::Plugin::task_names_foreground[TASK_RFC].c_str()] = true; |
There was a problem hiding this comment.
Coverity Issue - Data race condition
Accessing "this->plugin_->m_task_map" without holding lock "WPEFramework::Plugin::MaintenanceManager.m_statusMutex". Elsewhere, "WPEFramework::Plugin::MaintenanceManager.m_task_map" is written to with "MaintenanceManager.m_statusMutex" held 11 out of 15 times.
Medium Impact, CWE-366
MISSING_LOCK
| IARM_Bus_MaintMGR_EventData_t eventData{}; | ||
| eventData.data.maintenance_module_status.status = MAINT_RFC_COMPLETE; | ||
|
|
||
| plugin_->m_task_map[WPEFramework::Plugin::task_names_foreground[TASK_RFC]] = true; |
There was a problem hiding this comment.
Coverity issue no longer present as of: undefined
Show issue
Coverity Issue - Data race condition
Accessing "this->plugin_->m_task_map" without holding lock "WPEFramework::Plugin::MaintenanceManager.m_statusMutex". Elsewhere, "WPEFramework::Plugin::MaintenanceManager.m_task_map" is written to with "MaintenanceManager.m_statusMutex" held 11 out of 15 times.
Medium Impact, CWE-366
MISSING_LOCK
No description provided.