Skip to content

Rdkemw 4719 upto date validation l1 v1 #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Rdkemw 4719 upto date validation l1 v1 #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ffee82e
RDKEMW-4719 Return an error message for firmware upto date validation
ramkumarpraba Jun 17, 2025
79808dd
Update L2-tests.yml
ramkumarpraba Jun 17, 2025
7d0a012
Update build_dependencies.sh
ramkumarpraba Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/L2-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ jobs:
with:
repository: rdkcentral/entservices-testframework
path: entservices-testframework
ref: develop
ref: RDKEMW-4719_upto_date_validation_L1
token: ${{ secrets.RDKCM_RDKE }}

- name: Checkout googletest
Expand Down
12 changes: 0 additions & 12 deletions Tests/L1Tests/tests/test_FirmwareUpdate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,17 +153,13 @@ TEST_F(FirmwareUpdateTest, EmptyFirmwareFilepath)
{

EXPECT_EQ(Core::ERROR_INVALID_PARAMETER, handler.Invoke(connection, _T("updateFirmware"), _T("{\"firmwareFilepath\":\"\" ,\"firmwareType\":\"PCI\"}"), response));
EXPECT_EQ(Core::ERROR_NONE, handler.Invoke(connection, _T("getUpdateState"), _T("{}"), response));
EXPECT_EQ(response, string("{\"state\":\"VALIDATION_FAILED\",\"substate\":\"FIRMWARE_NOT_FOUND\"}"));
}

TEST_F(FirmwareUpdateTest, FirmwareFilepath_not_exist)
{
const char* filePath = "/tmp/ELTE11MWR_MIDDLEWARE_DEV_default_20241122145614.bin";
std::remove(filePath);
EXPECT_EQ(Core::ERROR_INVALID_PARAMETER, handler.Invoke(connection, _T("updateFirmware"), _T("{\"firmwareFilepath\":\"/tmp/ELTE11MWR_MIDDLEWARE_DEV_default_20241122145614.bin\" ,\"firmwareType\":\"PCI\"}"), response));
EXPECT_EQ(Core::ERROR_NONE, handler.Invoke(connection, _T("getUpdateState"), _T("{}"), response));
EXPECT_EQ(response, string("{\"state\":\"VALIDATION_FAILED\",\"substate\":\"FIRMWARE_NOT_FOUND\"}"));
}

TEST_F(FirmwareUpdateTest, EmptyFirmwareType)
Expand All @@ -172,10 +168,6 @@ TEST_F(FirmwareUpdateTest, EmptyFirmwareType)
if (outfile.is_open()) {

EXPECT_EQ(Core::ERROR_INVALID_PARAMETER, handler.Invoke(connection, _T("updateFirmware"), _T("{\"firmwareFilepath\":\"/tmp/ELTE11MWR_MIDDLEWARE_DEV_default_20241122145614.bin\" ,\"firmwareType\":\"\"}"), response));


EXPECT_EQ(Core::ERROR_NONE, handler.Invoke(connection, _T("getUpdateState"), _T("{}"), response));
EXPECT_EQ(response, string("{\"state\":\"VALIDATION_FAILED\",\"substate\":\"NOT_APPLICABLE\"}"));
}
}

Expand All @@ -185,10 +177,6 @@ TEST_F(FirmwareUpdateTest, InvalidFirmwareType)
if (outfile.is_open()) {

EXPECT_EQ(Core::ERROR_INVALID_PARAMETER, handler.Invoke(connection, _T("updateFirmware"), _T("{\"firmwareFilepath\":\"/tmp/ELTE11MWR_MIDDLEWARE_DEV_default_20241122145614.bin\" ,\"firmwareType\":\"ABC\"}"), response));


EXPECT_EQ(Core::ERROR_NONE, handler.Invoke(connection, _T("getUpdateState"), _T("{}"), response));
EXPECT_EQ(response, string("{\"state\":\"VALIDATION_FAILED\",\"substate\":\"NOT_APPLICABLE\"}"));
}
}

2 changes: 1 addition & 1 deletion build_dependencies.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ git clone --branch R4.4.1 https://github.com/rdkcentral/Thunder.git

git clone --branch main https://github.com/rdkcentral/entservices-apis.git

git clone https://[email protected]/rdkcentral/entservices-testframework.git
git clone --branch RDKEMW-4719_upto_date_validation_L1 https://[email protected]/rdkcentral/entservices-testframework.git

############################
# Build Thunder-Tools
Expand Down
Loading