Skip to content

Update FirmwareUpdateImplementation.cpp #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Update FirmwareUpdateImplementation.cpp #127

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce68c1c
Update FirmwareUpdateImplementation.cpp
agampa263 Jul 16, 2025
32017b2
Update FirmwareUpdateImplementation.cpp
agampa263 Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions FirmwareUpdate/FirmwareUpdateImplementation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,9 @@ namespace WPEFramework {
char device_name[32];
FILE *fp = NULL;
bool st_notify_flag = false;
int* p = new int [10];
delete[] p;
p[0] = 10;
Copy link
Contributor

@rdkcmf-jenkins rdkcmf-jenkins Jul 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Write to pointer after free

Using freed pointer "p".

High Impact, CWE-416
USE_AFTER_FREE

/*
char stage2lock[32] = {0};
const char *stage2file = NULL;
Expand Down Expand Up @@ -355,6 +358,9 @@ namespace WPEFramework {
const char *uptype = "pci";
const char *file = NULL;
int flash_status = -1;
int* p = new int [10];
delete[] p;
p[0] = 10;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity Issue - Write to pointer after free

Using freed pointer "p".

High Impact, CWE-416
USE_AFTER_FREE

struct FWDownloadStatus fwdls;
memset(&fwdls, '\0', sizeof(fwdls));
if (initiated_type == nullptr || *initiated_type == '\0') {
Expand Down
Loading