Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates GoogleTest fixture class names to be unique across unit and component test binaries, avoiding naming collisions (e.g., in unity/jumbo builds or when linking tests together).
Changes:
- Rename unit test fixtures from
*Testto*UTest(and update correspondingTEST_Fusages). - Rename component test fixtures from
*Testto*CTest(and update correspondingTEST_Fusages). - Apply the renaming consistently across multiple feature test suites (TextToSpeech, Metrics, Network, etc.).
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/unit/textToSpeechTest.cpp | Renames fixture to TextToSpeechUTest and updates all TEST_F references. |
| test/unit/statsTest.cpp | Renames fixture to StatsUTest and updates TEST_F references. |
| test/unit/presentationTest.cpp | Renames fixture to PresentationUTest and updates TEST_F references. |
| test/unit/networkTest.cpp | Renames fixture to NetworkUTest and updates TEST_F references. |
| test/unit/metricsTest.cpp | Renames fixture to MetricsUTest and updates TEST_F references. |
| test/unit/lifecycleTest.cpp | Renames fixture to LifecycleUTest and updates TEST_F references. |
| test/unit/displayTest.cpp | Renames fixture to DisplayUTest and updates TEST_F references. |
| test/unit/discoveryTest.cpp | Renames fixture to DiscoveryUTest and updates TEST_F references. |
| test/unit/deviceTest.cpp | Renames fixture to DeviceUTest and updates TEST_F references. |
| test/unit/advertisingTest.cpp | Renames fixture to AdvertisingUTest and updates TEST_F references. |
| test/unit/accessibilityTest.cpp | Renames fixture to AccessibilityUTest and updates TEST_F references. |
| test/component/textToSpeechTest.cpp | Renames fixture to TextToSpeechCTest and updates all TEST_F references. |
| test/component/statsTest.cpp | Renames fixture to StatsCTest and updates TEST_F references. |
| test/component/presentationTest.cpp | Renames fixture to PresentationCTest and updates TEST_F references. |
| test/component/networkTest.cpp | Renames fixture to NetworkCTest and updates TEST_F references. |
| test/component/metricsTest.cpp | Renames fixture to MetricsCTest and updates TEST_F references. |
| test/component/localizationTest.cpp | Renames fixture to LocalizationCTest and updates TEST_F references. |
| test/component/lifecycleTest.cpp | Renames fixture to LifecycleCTest and updates TEST_F references. |
| test/component/displayTest.cpp | Renames fixture to DisplayCTest and updates TEST_F references. |
| test/component/discoveryTest.cpp | Renames fixture to DiscoveryCTest and updates TEST_F references. |
| test/component/deviceTest.cpp | Renames fixture to DeviceCTest and updates TEST_F references. |
| test/component/advertisingTest.cpp | Renames fixture to AdvertisingCTest and updates TEST_F references. |
| test/component/accessibilityTest.cpp | Renames fixture to AccessibilityCTest and updates TEST_F references. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vladimir-rangelov
approved these changes
Mar 12, 2026
Contributor
Author
|
🎉 This PR is included in version 0.5.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.