Skip to content

test: Make test class names uniq #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomasz-blasz merged 1 commit into from
Mar 12, 2026
Merged

test: Make test class names uniq #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions test/component/accessibilityTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
#include "utils.h"
#include <gtest/gtest.h>

class AccessibilityTest : public ::testing::Test
class AccessibilityCTest : public ::testing::Test
{
protected:
void SetUp() override { eventReceived = false; }
Expand All @@ -34,7 +34,7 @@ class AccessibilityTest : public ::testing::Test
JsonEngine jsonEngine;
};

TEST_F(AccessibilityTest, AudioDescription)
TEST_F(AccessibilityCTest, AudioDescription)
{
auto expectedValue = jsonEngine.get_value("Accessibility.audioDescription");
auto result = Firebolt::IFireboltAccessor::Instance().AccessibilityInterface().audioDescription();
Expand All @@ -44,7 +44,7 @@ TEST_F(AccessibilityTest, AudioDescription)
EXPECT_EQ(*result, expectedValue);
}

TEST_F(AccessibilityTest, SubscribeOnAudioDescriptionChanged)
TEST_F(AccessibilityCTest, SubscribeOnAudioDescriptionChanged)
{
auto id = Firebolt::IFireboltAccessor::Instance().AccessibilityInterface().subscribeOnAudioDescriptionChanged(

Expand All @@ -69,7 +69,7 @@ TEST_F(AccessibilityTest, SubscribeOnAudioDescriptionChanged)
verifyUnsubscribeResult(result);
}

TEST_F(AccessibilityTest, ClosedCaptionsSettings)
TEST_F(AccessibilityCTest, ClosedCaptionsSettings)
{
auto expectedValue = jsonEngine.get_value("Accessibility.closedCaptionsSettings");
auto result = Firebolt::IFireboltAccessor::Instance().AccessibilityInterface().closedCaptionsSettings();
Expand All @@ -78,7 +78,7 @@ TEST_F(AccessibilityTest, ClosedCaptionsSettings)
EXPECT_EQ((*result).preferredLanguages, expectedValue.at("preferredLanguages").get<std::vector<std::string>>());
}

TEST_F(AccessibilityTest, SubscribeOnClosedCaptionsSettingsChanged)
TEST_F(AccessibilityCTest, SubscribeOnClosedCaptionsSettingsChanged)
{
auto id = Firebolt::IFireboltAccessor::Instance().AccessibilityInterface().subscribeOnClosedCaptionsSettingsChanged(
[&](const Firebolt::Accessibility::ClosedCaptionsSettings& settings)
Expand Down Expand Up @@ -112,7 +112,7 @@ TEST_F(AccessibilityTest, SubscribeOnClosedCaptionsSettingsChanged)
verifyUnsubscribeResult(result);
}

TEST_F(AccessibilityTest, HighContrastUI)
TEST_F(AccessibilityCTest, HighContrastUI)
{
auto expectedValue = jsonEngine.get_value("Accessibility.highContrastUI");
auto result = Firebolt::IFireboltAccessor::Instance().AccessibilityInterface().highContrastUI();
Expand All @@ -121,7 +121,7 @@ TEST_F(AccessibilityTest, HighContrastUI)
EXPECT_EQ(*result, expectedValue);
}

TEST_F(AccessibilityTest, SubscribeOnHighContrastUIChanged)
TEST_F(AccessibilityCTest, SubscribeOnHighContrastUIChanged)
{
auto id = Firebolt::IFireboltAccessor::Instance().AccessibilityInterface().subscribeOnHighContrastUIChanged(
[&](const bool& enabled)
Expand All @@ -145,7 +145,7 @@ TEST_F(AccessibilityTest, SubscribeOnHighContrastUIChanged)
verifyUnsubscribeResult(result);
}

TEST_F(AccessibilityTest, VoiceGuidanceSettings)
TEST_F(AccessibilityCTest, VoiceGuidanceSettings)
{
auto expectedValue = jsonEngine.get_value("Accessibility.voiceGuidanceSettings");
auto result = Firebolt::IFireboltAccessor::Instance().AccessibilityInterface().voiceGuidanceSettings();
Expand All @@ -156,7 +156,7 @@ TEST_F(AccessibilityTest, VoiceGuidanceSettings)
EXPECT_EQ((*result).navigationHints, expectedValue.at("navigationHints").get<bool>());
}

TEST_F(AccessibilityTest, SubscribeOnVoiceGuidanceSettingsChanged)
TEST_F(AccessibilityCTest, SubscribeOnVoiceGuidanceSettingsChanged)
{
auto id = Firebolt::IFireboltAccessor::Instance().AccessibilityInterface().subscribeOnVoiceGuidanceSettingsChanged(
[&](const Firebolt::Accessibility::VoiceGuidanceSettings& settings)
Expand Down
4 changes: 2 additions & 2 deletions test/component/advertisingTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@
#include "json_engine.h"
#include <gtest/gtest.h>

class AdvertisingTest : public ::testing::Test
class AdvertisingCTest : public ::testing::Test
{

protected:
JsonEngine jsonEngine;
};

TEST_F(AdvertisingTest, AdvertisingId)
TEST_F(AdvertisingCTest, AdvertisingId)
{
auto expectedValue = jsonEngine.get_value("Advertising.advertisingId");
auto result = Firebolt::IFireboltAccessor::Instance().AdvertisingInterface().advertisingId();
Expand Down
16 changes: 8 additions & 8 deletions test/component/deviceTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
#include <gtest/gtest.h>
#include <iostream>

class DeviceTest : public ::testing::Test
class DeviceCTest : public ::testing::Test
{
protected:
void SetUp() override { eventReceived = false; }
Expand All @@ -35,23 +35,23 @@ class DeviceTest : public ::testing::Test
JsonEngine jsonEngine;
};

TEST_F(DeviceTest, ChipsetId)
TEST_F(DeviceCTest, ChipsetId)
{
auto expectedValue = jsonEngine.get_value("Device.chipsetId");
auto result = Firebolt::IFireboltAccessor::Instance().DeviceInterface().chipsetId();
ASSERT_TRUE(result) << "DeviceImpl::chipsetId() returned an error";
EXPECT_EQ(*result, expectedValue);
}

TEST_F(DeviceTest, DeviceClass)
TEST_F(DeviceCTest, DeviceClass)
{
auto expectedValue = jsonEngine.get_value("Device.deviceClass");
auto result = Firebolt::IFireboltAccessor::Instance().DeviceInterface().deviceClass();
ASSERT_TRUE(result) << "DeviceImpl::deviceClass() returned an error";
EXPECT_EQ(static_cast<int>(*result), static_cast<int>(Firebolt::Device::JsonData::DeviceClassEnum.at(expectedValue)));
}

TEST_F(DeviceTest, Hdr)
TEST_F(DeviceCTest, Hdr)
{
auto expectedValue = jsonEngine.get_value("Device.hdr");
auto result = Firebolt::IFireboltAccessor::Instance().DeviceInterface().hdr();
Expand All @@ -62,7 +62,7 @@ TEST_F(DeviceTest, Hdr)
EXPECT_EQ(result->hlg, expectedValue["hlg"].get<bool>());
}

TEST_F(DeviceTest, TimeInActiveState)
TEST_F(DeviceCTest, TimeInActiveState)
{
auto expectedValue = jsonEngine.get_value("Device.timeInActiveState");
auto result = Firebolt::IFireboltAccessor::Instance().DeviceInterface().timeInActiveState();
Expand All @@ -75,15 +75,15 @@ TEST_F(DeviceTest, TimeInActiveState)
EXPECT_EQ(*result, expectedValue);
}

TEST_F(DeviceTest, Uid)
TEST_F(DeviceCTest, Uid)
{
auto expectedValue = jsonEngine.get_value("Device.uid");
auto result = Firebolt::IFireboltAccessor::Instance().DeviceInterface().uid();
ASSERT_TRUE(result) << "DeviceImpl::uid() returned an error";
EXPECT_EQ(*result, expectedValue);
}

TEST_F(DeviceTest, Uptime)
TEST_F(DeviceCTest, Uptime)
{
auto expectedValue = jsonEngine.get_value("Device.uptime");
auto result = Firebolt::IFireboltAccessor::Instance().DeviceInterface().uptime();
Expand All @@ -96,7 +96,7 @@ TEST_F(DeviceTest, Uptime)
EXPECT_EQ(*result, expectedValue);
}

TEST_F(DeviceTest, SubscribeOnHdrChanged)
TEST_F(DeviceCTest, SubscribeOnHdrChanged)
{
auto id = Firebolt::IFireboltAccessor::Instance().DeviceInterface().subscribeOnHdrChanged(
[&](const Firebolt::Device::HDRFormat& value)
Expand Down
4 changes: 2 additions & 2 deletions test/component/discoveryTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@
#include "firebolt/firebolt.h"
#include "json_engine.h"

class DiscoveryTest : public ::testing::Test
class DiscoveryCTest : public ::testing::Test
{
protected:
JsonEngine jsonEngine;
};

TEST_F(DiscoveryTest, Watched)
TEST_F(DiscoveryCTest, Watched)
{
auto result = Firebolt::IFireboltAccessor::Instance().DiscoveryInterface().watched("entity123", 0.75f, true,
"2024-10-01T12:00:00Z",
Expand Down
8 changes: 4 additions & 4 deletions test/component/displayTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@
#include "json_engine.h"
#include <gtest/gtest.h>

class DisplayTest : public ::testing::Test
class DisplayCTest : public ::testing::Test
{
protected:
JsonEngine jsonEngine;
};

TEST_F(DisplayTest, Edid)
TEST_F(DisplayCTest, Edid)
{
auto expectedValue = jsonEngine.get_value("Display.edid");
auto result = Firebolt::IFireboltAccessor::Instance().DisplayInterface().edid();
Expand All @@ -35,7 +35,7 @@ TEST_F(DisplayTest, Edid)
EXPECT_EQ(*result, expectedValue.get<std::string>());
}

TEST_F(DisplayTest, MaxResolution)
TEST_F(DisplayCTest, MaxResolution)
{
auto expectedValue = jsonEngine.get_value("Display.maxResolution");

Expand All @@ -46,7 +46,7 @@ TEST_F(DisplayTest, MaxResolution)
EXPECT_EQ(result->width, expectedValue.at("width").get<uint32_t>());
}

TEST_F(DisplayTest, Size)
TEST_F(DisplayCTest, Size)
{
auto expectedValue = jsonEngine.get_value("Display.size");
auto result = Firebolt::IFireboltAccessor::Instance().DisplayInterface().size();
Expand Down
10 changes: 5 additions & 5 deletions test/component/lifecycleTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
#include <iostream>
#include <mutex>

class LifecycleTest : public ::testing::Test
class LifecycleCTest : public ::testing::Test
{
protected:
void SetUp() override { eventReceived = false; }
Expand All @@ -36,15 +36,15 @@ class LifecycleTest : public ::testing::Test
JsonEngine jsonEngine;
};

TEST_F(LifecycleTest, close)
TEST_F(LifecycleCTest, close)

{
auto result =
Firebolt::IFireboltAccessor::Instance().LifecycleInterface().close(Firebolt::Lifecycle::CloseType::DEACTIVATE);
ASSERT_TRUE(result) << "Error on calling LifecycleInterface.close() method";
}

TEST_F(LifecycleTest, state)
TEST_F(LifecycleCTest, state)
{
Firebolt::Result<Firebolt::Lifecycle::LifecycleState> result =
Firebolt::IFireboltAccessor::Instance().LifecycleInterface().state();
Expand All @@ -54,7 +54,7 @@ TEST_F(LifecycleTest, state)
EXPECT_EQ(*result, Firebolt::Lifecycle::LifecycleState::ACTIVE);
}

TEST_F(LifecycleTest, subscribeOnState_JSON_RPC_compliant)
TEST_F(LifecycleCTest, subscribeOnState_JSON_RPC_compliant)
{
auto id = Firebolt::IFireboltAccessor::Instance().LifecycleInterface().subscribeOnStateChanged(
[&](const std::vector<Firebolt::Lifecycle::StateChange>& changes)
Expand Down Expand Up @@ -86,7 +86,7 @@ TEST_F(LifecycleTest, subscribeOnState_JSON_RPC_compliant)
verifyUnsubscribeResult(result);
}

TEST_F(LifecycleTest, subscribeOnState_noValue)
TEST_F(LifecycleCTest, subscribeOnState_noValue)
{
auto id = Firebolt::IFireboltAccessor::Instance().LifecycleInterface().subscribeOnStateChanged(
[&](const std::vector<Firebolt::Lifecycle::StateChange>& changes)
Expand Down
14 changes: 7 additions & 7 deletions test/component/localizationTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
#include "utils.h"
#include "gtest/gtest.h"

class LocalizationTest : public ::testing::Test
class LocalizationCTest : public ::testing::Test
{
protected:
void SetUp() override { eventReceived = false; }
Expand All @@ -34,7 +34,7 @@ class LocalizationTest : public ::testing::Test
JsonEngine jsonEngine;
};

TEST_F(LocalizationTest, CountryCode)
TEST_F(LocalizationCTest, CountryCode)
{
auto result = Firebolt::IFireboltAccessor::Instance().LocalizationInterface().country();
ASSERT_TRUE(result) << "error on get";
Expand All @@ -43,7 +43,7 @@ TEST_F(LocalizationTest, CountryCode)
EXPECT_EQ(*result, expectedValue);
}

TEST_F(LocalizationTest, PreferredAudioLanguages)
TEST_F(LocalizationCTest, PreferredAudioLanguages)
{
auto result = Firebolt::IFireboltAccessor::Instance().LocalizationInterface().preferredAudioLanguages();
ASSERT_TRUE(result) << "error on get";
Expand All @@ -54,7 +54,7 @@ TEST_F(LocalizationTest, PreferredAudioLanguages)
EXPECT_EQ(resultSet, expectedSet);
}

TEST_F(LocalizationTest, PresentationLanguage)
TEST_F(LocalizationCTest, PresentationLanguage)
{
auto result = Firebolt::IFireboltAccessor::Instance().LocalizationInterface().presentationLanguage();
ASSERT_TRUE(result) << "error on get";
Expand All @@ -63,7 +63,7 @@ TEST_F(LocalizationTest, PresentationLanguage)
EXPECT_EQ(*result, expectedValue);
}

TEST_F(LocalizationTest, subscribeOnCountryCodeChanged)
TEST_F(LocalizationCTest, subscribeOnCountryCodeChanged)
{
auto id = Firebolt::IFireboltAccessor::Instance().LocalizationInterface().subscribeOnCountryChanged(
[&](const std::string& code)
Expand Down Expand Up @@ -91,7 +91,7 @@ TEST_F(LocalizationTest, subscribeOnCountryCodeChanged)
ASSERT_TRUE(result) << "error on unsubscribe ";
}

TEST_F(LocalizationTest, subscribeOnPreferredAudioLanguagesChanged)
TEST_F(LocalizationCTest, subscribeOnPreferredAudioLanguagesChanged)
{
auto id = Firebolt::IFireboltAccessor::Instance().LocalizationInterface().subscribeOnPreferredAudioLanguagesChanged(
[&](const std::vector<std::string>& languages)
Expand Down Expand Up @@ -122,7 +122,7 @@ TEST_F(LocalizationTest, subscribeOnPreferredAudioLanguagesChanged)
ASSERT_TRUE(result) << "error on unsubscribe ";
}

TEST_F(LocalizationTest, subscribeOnPreferredPresentationLanguageChanged)
TEST_F(LocalizationCTest, subscribeOnPreferredPresentationLanguageChanged)
{
auto id = Firebolt::IFireboltAccessor::Instance().LocalizationInterface().subscribeOnPresentationLanguageChanged(
[&](const std::string& language)
Expand Down
Loading
Loading