Conversation
There was a problem hiding this comment.
Pull request overview
This is a release PR for version 0.2.1 that primarily focuses on code quality improvements and dependency updates. The changes align naming conventions throughout the codebase, update the transport dependency to v1.0.0-next.25, and improve build system configuration.
Key changes include:
- Updated transport dependency from firebolt-native-transport to firebolt-cpp-transport v1.0.0-next.25
- Fixed spelling errors and standardized documentation formatting across header files
- Enhanced build script to support separate build directories for development and production builds
Reviewed changes
Copilot reviewed 17 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| CHANGELOG.md | Added release notes for v0.2.1 with bug fixes and transport update |
| .transport.version | Updated transport version from 1.0.0-next.23 to 1.0.0-next.25 |
| CMakeLists.txt | Updated transport dependency URLs and added SHA256 hash verification |
| .github/Dockerfile | Updated transport dependency references from firebolt-native-transport to firebolt-cpp-transport |
| build.sh | Enhanced build script with separate build directories, improved clean handling, and conditional install logic |
| .gitignore | Added pattern to ignore build-* directories |
| test/CMakeLists.txt | Added DISCOVERY_MODE PRE_TEST to gtest discovery for both unit and component tests |
| test/utils.cpp | Made EventWaitTime type more explicit by using std::chrono::seconds |
| test/unit/deviceTest.cpp | Fixed typo in test name from "GetClassBadRespons_Test" to "GetClassBadResponse_Test" |
| test/component/deviceTest.cpp | Fixed spelling errors in console output messages ("recived" → "received") |
| include/firebolt/firebolt.h | Removed malformed comment block and fixed spelling of "Accessibility" |
| include/firebolt/stats.h | Removed unused includes and duplicate documentation line |
| include/firebolt/display.h | Removed unused includes |
| include/firebolt/device.h | Removed unused includes |
| include/firebolt/advertising.h | Removed unused includes |
| include/firebolt/accessibility.h | Removed unused include and standardized parameter documentation formatting |
| include/firebolt/lifecycle.h | Removed unused include and standardized parameter documentation formatting |
| include/firebolt/localization.h | Removed unused includes, comment sections, and standardized parameter documentation formatting |
| include/firebolt/presentation.h | Standardized parameter documentation formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| -i | --install) do_install=true;; | ||
| +tests) params+=" -DENABLE_TESTS=ON";; | ||
| +tests) params+=" -DENABLE_TESTS=ON"; bdir="build-dev";; | ||
| +demo) params+=" -DENABLE_DEMO_APP=ON";; |
There was a problem hiding this comment.
The +demo option doesn't set bdir to "build-dev" like the +tests option does. This could cause inconsistent behavior where +demo uses "build" directory but +tests uses "build-dev". Consider whether +demo should also use "build-dev" for consistency, or if there's a specific reason for this difference.
| +demo) params+=" -DENABLE_DEMO_APP=ON";; | |
| +demo) params+=" -DENABLE_DEMO_APP=ON"; bdir="build-dev";; |
|
🎉 This PR is included in version 0.2.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.