test: Allow protocol selection in api-test app#57
Merged
tomasz-blasz merged 1 commit intomainfrom Mar 9, 2026
Merged
Conversation
tomasz-blasz
force-pushed
the
topic/api-test-select-protocol
branch
from
44f9626 to
ff0b392
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds command-line flags to the api-test-app demo utility to let users override the default RPC protocol mode (legacy vs JSON-RPC v2), and updates the documentation/changelog accordingly.
Changes:
- Added
--legacy/--rpc-v2CLI flags to select the protocol mode. - Updated API test app README usage/options to document the new flags.
- Added an Unreleased changelog entry describing the new protocol-selection flags.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
test/api_test_app/main.cpp |
Parses new protocol-selection flags and applies them to the Firebolt connection config. |
test/api_test_app/README.md |
Documents the new --legacy / --rpc-v2 command-line options. |
CHANGELOG.md |
Notes the new protocol-selection capability for the API test app under Unreleased. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vladimir-rangelov
approved these changes
Mar 9, 2026
Contributor
Author
|
🎉 This PR is included in version 0.5.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.