Skip to content

fix: Add RPCv2 endpoint to ws connection #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vladimir-rangelov merged 3 commits into from
Jul 29, 2025
Merged

fix: Add RPCv2 endpoint to ws connection #255

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c79650
fix: Add RPCv2 endpoint to ws connection
ksentak Apr 15, 2025
f96846a
fix: Spelling error
ksentak Apr 16, 2025
83bf44e
Merge branch 'next-bidirectional' into fix/js-bidirectional-query-param
vladimir-rangelov Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion languages/javascript/src/shared/Transport/index.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,12 @@ function getImplementation() {
implementation = win.__firebolt.transport
}
else if (win.__firebolt.endpoint) {
implementation = new WebsocketTransport(win.__firebolt.endpoint)
// Only adds RPCv2=true query parameter when using bidirectional SDK.
// This parameter will not be present when using unidirectional SDK.
// Unidirectional endpoint is handled in Gateway/Unidirectional.mjs
const endpoint = win.__firebolt.endpoint
const url = endpoint + (endpoint.includes('?') ? '&' : '?') + 'RPCv2=true'
implementation = new WebsocketTransport(url)
}
else {
implementation = MockTransport
Expand Down
Loading