Fix regressions in generated documentation#279
Merged
vladimir-rangelov merged 7 commits intonext-bidirectionalfrom Oct 8, 2025
Merged
Fix regressions in generated documentation#279vladimir-rangelov merged 7 commits intonext-bidirectionalfrom
vladimir-rangelov merged 7 commits intonext-bidirectionalfrom
Conversation
…irectly referenced
tomasz-blasz
reviewed
Oct 7, 2025
src/macrofier/index.mjs
Outdated
| getLocalSchemas(document).forEach((path) => { | ||
| const parts = path.split('/') | ||
| // Drop the grouping path element, since we've pulled this schema out into it's own document | ||
| if (parts.length === 4 && path.startsWith('#/x-schemas/' + document.info.title + '/')) { |
Contributor
There was a problem hiding this comment.
please, comment on why there is a 4 — or even better, extract it as a const. It’ll make our lives much happier when inspecting the code later 😉
applies to line 299 as well
tomasz-blasz
reviewed
Oct 7, 2025
Contributor
tomasz-blasz
left a comment
tomasz-blasz
left a comment
There was a problem hiding this comment.
all good apart from mysterious '4'
vladimir-rangelov
changed the title
tomasz-blasz
approved these changes
Oct 8, 2025
vladimir-rangelov
deleted the
fix/regressions_in_generated_documentation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completely rewrite removeUnusedSchemas and add unit tests for it.