Skip to content

Conversation

@paulpandian25
Copy link
Contributor

Reason for Change: Reintroduced the condition check before calling clear() in clearDrmSession. This was lost during DRM refactoring and was causing increase in PLTV XSTPP-999 failures.

Changes:

  • Added getFailedKeyIdStatus() method to DrmSessionManager
  • Modified clearDrmSession() in AampDRMLicenseManager to add condition checks
  • Only clear license downloader when conditions are met

Reason for Change: Reintroduced the condition check before calling clear()
in clearDrmSession. This was lost during DRM refactoring and was causing
increase in PLTV XSTPP-999 failures.

Changes:
- Added getFailedKeyIdStatus() method to DrmSessionManager
- Modified clearDrmSession() in AampDRMLicenseManager to add condition checks
- Only clear license downloader when conditions are met
@paulpandian25 paulpandian25 requested review from a team as code owners November 3, 2025 20:14
Copilot AI review requested due to automatic review settings November 3, 2025 20:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the AAMP (Adaptive Audio and Media Player) package to version 2.7.1.5 by updating both the source revision (SRCREV) and package version (PV) references.

  • Updated SRCREV_aamp to point to a new commit hash
  • Incremented package version from 2.7.1.4 to 2.7.1.5

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
conf/include/generic-srcrev.inc Updated SRCREV_aamp commit hash to the new version
conf/include/generic-pkgrev.inc Bumped PV:pn-aamp package version from 2.7.1.4 to 2.7.1.5

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings November 4, 2025 14:17
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI review requested due to automatic review settings November 4, 2025 14:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Reason for Change: Reintroduced the condition check before calling clear()
in clearDrmSession. This was lost during DRM refactoring and was causing
increase in PLTV XSTPP-999 failures.

Changes:
- Added getFailedKeyIdStatus() method to DrmSessionManager
- Modified clearDrmSession() in AampDRMLicenseManager to add condition checks
- Only clear license downloader when conditions are met
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants