RDKEMW-9015: Bump TextTrack to opensource #2110
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds conditional support for the texttrack package in the middleware layer based on a distro feature flag. The changes ensure that the texttrack package is only included when the corresponding distro feature is enabled, and bump the package revision to reflect the update.
- Adds conditional inclusion of
texttrackpackage based onDISTRO_FEATURES - Increments package revision for
thunderstartupservices
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| recipes-core/packagegroups/packagegroup-middleware-layer.bb | Adds conditional runtime dependency on texttrack package when the distro feature is enabled |
| conf/include/generic-pkgrev.inc | Bumps PR (package revision) for thunderstartupservices from r0 to r1 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
thellef
force-pushed
the
feature/rdkemw-9015
branch
from
5281e74 to
4d5895a
Compare
thellef
force-pushed
the
feature/rdkemw-9015
branch
from
4d5895a to
e514a63
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| sysint \ | ||
| systimemgr \ | ||
| telemetry \ | ||
| ${@bb.utils.contains('DISTRO_FEATURES', 'texttrack', 'texttrack', '', d)} \ |
There was a problem hiding this comment.
[nitpick] Inconsistent spacing in the conditional expression. The pattern at line 34 and 49 uses double spaces after the comma and space before closing parenthesis ('enable_ripple', \"virtual/firebolt \"), line 50 uses single quotes with no trailing space ('memcapture', 'memcapture', ''), while line 71 uses single quotes ('DAC_SUPPORT', 'entservices-lisa', ''). The new line at 82 should follow the predominant pattern in the file. Consider aligning with line 50's pattern: ${@bb.utils.contains('DISTRO_FEATURES', 'texttrack', 'texttrack', '', d)}.
|
|
Move installation wish to packagegroup-middleware-layer main file rather than a bbappend under cspc. Bump PR of thunderstartupservices because we modify the recipe to install texttrack's service file. Change-Id: I8ec2b5228d7f10872f63caab769e3d524e782242
thellef
force-pushed
the
feature/rdkemw-9015
branch
from
e514a63 to
c6e2d86
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The opensourcing is postponed for now. |
RDKEMW-9015: Bump TextTrack to opensource
Move installation wish to packagegroup-middleware-layer main file rather than a bbappend under cspc.
Bump PR of thunderstartupservices because we modify the recipe to install texttrack's service file.