Skip to content

Conversation

@nhanasi
Copy link
Contributor

@nhanasi nhanasi commented Dec 3, 2025

RDKEMW-11090 : Update PV and PR

Copilot AI review requested due to automatic review settings December 3, 2025 14:53
@nhanasi nhanasi requested review from a team as code owners December 3, 2025 14:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the source revision (SRCREV) and package version (PV) for the tr69hostif and tr69hostif-headers components, bringing changes from RDKTV-39100 into the RDK middleware support/2.16.0 branch.

Key changes:

  • Updates tr69hostif SRCREV from 33a8e14917760eefb42356b680db245c88a871ef to 32d734d2786262492205a580316c4252902a01fb
  • Bumps tr69hostif package version from 1.1.9v5 to 1.1.9v6

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
conf/include/generic-srcrev.inc Updates source revision commit hashes for tr69hostif and tr69hostif-headers packages
conf/include/generic-pkgrev.inc Increments package version from 1.1.9v5 to 1.1.9v6 for tr69hostif and tr69hostif-headers packages

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

SRCREV_tr69hostif = "32d734d2786262492205a580316c4252902a01fb"
SRCREV:pn-hdmicecheader = "5201b2f759b4ca8fd2a6f5db838d528f6477db0c"
SRCREV:pn-tr69hostif-headers = "33a8e14917760eefb42356b680db245c88a871ef"
SRCREV:pn-tr69hostif-headers = "32d734d2786262492205a580316c4252902a01fb"
Copy link

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tr69hostif-headers package should reference ${SRCREV_tr69hostif} instead of duplicating the commit hash. This follows the established pattern in this file where header packages reference their parent package's SRCREV variable (see lines 5, 7, 30, 31, 38, 42, 44).

Suggested change:

SRCREV:pn-tr69hostif-headers = "${SRCREV_tr69hostif}"

This ensures consistency and makes future updates easier by only requiring a change in one place.

Suggested change
SRCREV:pn-tr69hostif-headers = "32d734d2786262492205a580316c4252902a01fb"
SRCREV:pn-tr69hostif-headers = "${SRCREV_tr69hostif}"

Copilot uses AI. Check for mistakes.
@divyang-public divyang-public merged commit da9c420 into support/2.16.0 Dec 4, 2025
8 checks passed
@divyang-public divyang-public deleted the feature/rdkemw-11090 branch December 4, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants