RDKEMW-13366: Add game controllerdb dependency to wpe-backend#542
RDKEMW-13366: Add game controllerdb dependency to wpe-backend#542ganeshprasads wants to merge 2 commits intodevelopfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds the libmanette controller database as a dependency for the wpe-backend-rdk Yocto recipe when the manettegamepad PACKAGECONFIG is enabled, aiming to ensure gamepad mappings are available at runtime.
Changes:
- Extends
PACKAGECONFIG[manettegamepad]to include a controller DB runtime dependency. - Updates
wpe-backend-rdk_0.5.bbrecipe configuration for manette-based gamepad support.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| PACKAGECONFIG[gamepad] = "-DUSE_GENERIC_GAMEPAD=ON,-DUSE_GENERIC_GAMEPAD=OFF," | ||
| PACKAGECONFIG[headless] = "-DUSE_BACKEND_HEADLESS=ON -DUSE_INPUT_LIBINPUT=OFF,-DUSE_BACKEND_HEADLESS=OFF," | ||
| PACKAGECONFIG[manettegamepad] = "-DUSE_LIBMANETTE_GAMEPAD=ON, -DUSE_LIBMANETTE_GAMEPAD=OFF, libmanette" | ||
| PACKAGECONFIG[manettegamepad] = "-DUSE_LIBMANETTE_GAMEPAD=ON, -DUSE_LIBMANETTE_GAMEPAD=OFF, libmanette, libmanette-controllerdb" |
There was a problem hiding this comment.
PACKAGECONFIG[manettegamepad] runtime deps (the 4th field) are applied to RDEPENDS:${PN}. However the image/packagegroup pulls in wpe-backend-rdk-platform-plugin (not ${PN}), and ${PN} is allowed to be empty here. As a result, libmanette-controllerdb may not be installed at runtime when only the platform-plugin package is installed. Consider adding libmanette-controllerdb to RDEPENDS:${PN}-platform-plugin (conditionally when manettegamepad is enabled) instead of (or in addition to) using the 4th PACKAGECONFIG field.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2 participants
Reason for change: Add game controller database as runtime dependency for wpe-backend package configuration
Test Procedure: Verify functionality with gamepad test app
Risks: Low
Priority: P2
Signed-off-by: Ganesh prasad Sahu [email protected]