-
Notifications
You must be signed in to change notification settings - Fork 14
rebase #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ANANTHMARIMUTHU
wants to merge
14
commits into
RDKOSS-615-test
Choose a base branch
from
develop
base: RDKOSS-615-test
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
rebase #560
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
99f7d62
RDK-57502 : Migrate Operation Support Log Upload Related Scripts To C…
Abhinavpv28 595555b
RDK-60607: Upgrade RBUS to 2.11.0 (#513)
dshett549 bcc0dae
RDKEMW-12842: Include meta-clang needed for secclient-rs (#494)
maniselva006c 17fc538
RDK-59955: Migrate Upload Dumps Functionality from Shell Script to C …
gomathishankar37 68aafa7
RDK-60312: Telemetry Release 1.8.0 (#533)
yogeswaransky f8c3c55
Update rfc_git.bb (#534)
nhanasi db05fe2
RDK-60065:Implement Firmware Download & Install API for Event-Driven …
mkadinti d765e20
Update SRCREV to new commit hash
Abhinavpv28 0e8569d
Update SRCREV to new commit hash
Abhinavpv28 c7fce5a
Update dcmd.bb
Abhinavpv28 7fef63d
Update dcmd.bb
Abhinavpv28 d6c1ba3
Update dcmd.bb
Abhinavpv28 df0873a
Merge pull request #541 from rdkcentral/feature/RDK-59919_release
nhanasi df1e216
Update dcmd.bb (#546)
Abhinavpv28 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,61 +1,81 @@ | ||
| SUMMARY = "Crashupload application" | ||
| SUMMARY = "Crash Upload Utility for RDK Platforms" | ||
| SECTION = "console/utils" | ||
|
|
||
| LICENSE = "Apache-2.0" | ||
| LIC_FILES_CHKSUM = "file://LICENSE;md5=175792518e4ac015ab6696d16c4f607e" | ||
| LIC_FILES_CHKSUM = "file://../LICENSE;md5=175792518e4ac015ab6696d16c4f607e" | ||
|
|
||
| PV = "1.0.7" | ||
| PV = "2.0.0" | ||
| PR = "r0" | ||
| PACKAGE_ARCH = "${MIDDLEWARE_ARCH}" | ||
|
|
||
| # To have a possibility to override SRC_URI later, we are introducing the following workaround: | ||
| CRASHUPLOAD_SRC_URI ?= "${RDK_GENERIC_ROOT_GIT}/crashupload/generic;module=.;protocol=${RDK_GIT_PROTOCOL};branch=${RDK_GIT_BRANCH}" | ||
| SRCREV = "8e7e22d2cb988ea58b9ba9d85b8b0812c6dc77d2" | ||
| SRC_URI = "${CMF_GITHUB_ROOT}/crashupload;${CMF_GITHUB_SRC_URI_SUFFIX};module=." | ||
| S = "${WORKDIR}/git" | ||
| SRC_URI = "${CMF_GITHUB_ROOT}/${BPN}.git;nobranch=1;protocol=${CMF_GIT_PROTOCOL}" | ||
| SRCREV = "e4b80deef60735bfa3ed3cfe2766554c97a91e0b" | ||
|
|
||
| S = "${WORKDIR}/git/c_sourcecode" | ||
|
|
||
| DEPENDS = "glib-2.0 libsyswrapper" | ||
|
|
||
| export LINK = "${LD}" | ||
|
|
||
| CFLAGS += " \ | ||
| -I=${libdir}/glib-2.0/include \ | ||
| -I=${includedir}/glib-2.0 \ | ||
| " | ||
| CFLAGS:append = " \ | ||
| -I=${libdir}/glib-2.0/include \ | ||
| -I=${includedir}/glib-2.0 \ | ||
| -DRFC_API_ENABLED \ | ||
| -DT2_EVENT_ENABLED \ | ||
| -DRDK_LOGGER \ | ||
| -DUSE_EXTENDED_LOGGER_INIT \ | ||
| " | ||
|
|
||
| export GLIBS = "-lglib-2.0 -lz" | ||
| export USE_DBUS = "y" | ||
|
|
||
| LDFLAGS += "-Wl,-O1" | ||
| LDFLAGS:append = " -Wl,-O1" | ||
|
|
||
| inherit autotools systemd coverity pkgconfig | ||
|
|
||
| inherit coverity | ||
| inherit systemd | ||
| DEPENDS:append:client = " \ | ||
| openssl \ | ||
| libarchive \ | ||
| rdk-logger \ | ||
| commonutilities \ | ||
| rfc \ | ||
| telemetry \ | ||
| " | ||
|
|
||
| do_install() { | ||
| install -d ${D}${base_libdir}/rdk | ||
| install -d ${D}${sysconfdir} ${D}${sysconfdir}/rfcdefaults | ||
| install -m 0755 ${S}/uploadDumps.sh ${D}${base_libdir}/rdk | ||
| install -m 0755 ${WORKDIR}/git/uploadDumps.sh ${D}${base_libdir}/rdk | ||
| install -m 0755 ${WORKDIR}/git/runDumpUpload.sh ${D}${base_libdir}/rdk | ||
| } | ||
|
|
||
| do_install:append:client() { | ||
| install -d ${D}${bindir} | ||
| install -m 0755 ${B}/src/crashupload ${D}${bindir}/crashupload | ||
| } | ||
|
|
||
| do_install:append:broadband() { | ||
| use_sysv="${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'false', 'true', d)}" | ||
| $use_sysv || install -d ${D}${systemd_unitdir}/system | ||
| $use_sysv || install -m 0644 ${S}/coredump-upload.service ${D}${systemd_unitdir}/system/ | ||
| $use_sysv || install -m 0644 ${S}/coredump-upload.path ${D}${systemd_unitdir}/system/ | ||
| $use_sysv || install -m 0644 ${S}/minidump-on-bootup-upload.service ${D}${systemd_unitdir}/system/ | ||
| $use_sysv || install -m 0644 ${S}/minidump-on-bootup-upload.timer ${D}${systemd_unitdir}/system/ | ||
| $use_sysv || install -m 0644 ${WORKDIR}/git/coredump-upload.service ${D}${systemd_unitdir}/system/ | ||
| $use_sysv || install -m 0644 ${WORKDIR}/git/coredump-upload.path ${D}${systemd_unitdir}/system/ | ||
| $use_sysv || install -m 0644 ${WORKDIR}/git/minidump-on-bootup-upload.service ${D}${systemd_unitdir}/system/ | ||
| $use_sysv || install -m 0644 ${WORKDIR}/git/minidump-on-bootup-upload.timer ${D}${systemd_unitdir}/system/ | ||
| install -d ${D}${sysconfdir} | ||
| install -m 0755 ${S}/uploadDumpsUtils.sh ${D}${base_libdir}/rdk | ||
| install -m 0755 ${WORKDIR}/git/uploadDumpsUtils.sh ${D}${base_libdir}/rdk | ||
| } | ||
|
|
||
| SYSTEMD_SERVICE:${PN}:append:broadband = " coredump-upload.service \ | ||
| coredump-upload.path \ | ||
| minidump-on-bootup-upload.service \ | ||
| minidump-on-bootup-upload.timer \ | ||
| " | ||
| RDEPENDS:${PN} += "busybox" | ||
| " | ||
|
|
||
| RDEPENDS:${PN} += "busybox commonutilities" | ||
|
|
||
| PACKAGE_BEFORE_PN += "${PN}-conf" | ||
|
|
||
| FILES:${PN} += "${base_libdir}/rdk/uploadDumps.sh" | ||
| FILES:${PN}:append:client = " ${bindir}/crashupload" | ||
| FILES:${PN}:append = " ${base_libdir}/rdk/uploadDumps.sh" | ||
| FILES:${PN}:append = " ${base_libdir}/rdk/runDumpUpload.sh" | ||
| FILES:${PN}:append:broadband = " ${base_libdir}/rdk/uploadDumpsUtils.sh" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When PV (package version) is updated, PR (package revision) should typically be reset to "r0". Here PV changed from 1.5.0 to 1.5.1, but PR was incremented to "r1" instead of being reset to "r0". This is inconsistent with the pattern used in other files in this PR (telemetry, rbus, dcmd, crashupload) where PR is reset to "r0" when PV changes.