Skip to content

Conversation

@leenaS-d
Copy link

No description provided.

Copilot AI review requested due to automatic review settings November 10, 2025 00:46
@leenaS-d leenaS-d requested a review from a team as a code owner November 10, 2025 00:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the WiFi connection logic to add special handling for open networks (no security) with empty passphrases.

  • Adds a conditional check to differentiate between open networks and secured networks
  • For open networks with no passphrase, attempts to activate a known connection profile before falling back to the standard connection method
  • Maintains backward compatibility by falling back to the existing wifiConnect method for all other scenarios

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings November 10, 2025 00:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

{
if(wifi->wifiConnect(ssid))
rc = Core::ERROR_NONE;
if(ssid.passphrase.empty() && (ssid.security == Exchange::INetworkManager::WIFI_SECURITY_NONE))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If WIFIConnect() is called for the first time but to connect to Open SSID (un-secure SSID) this API will fail as there is nothing to activate.

So, first we have to check whether the given SSID is in active connection list and then call for activate.

@karuna2git
Copy link
Contributor

karuna2git commented Nov 11, 2025

Please use proper RDK/RDKEMW ticket in the title and the give details in the description on what the change is all about for readability/awareness

@leenaS-d leenaS-d changed the title wificonnect by specifying SSID of a known network RDKEMW-8042: wificonnect by specifying SSID of a known network Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants