-
Notifications
You must be signed in to change notification settings - Fork 10
RDKEMW-8042: wificonnect by specifying SSID of a known network #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modifies the WiFi connection logic to add special handling for open networks (no security) with empty passphrases.
- Adds a conditional check to differentiate between open networks and secured networks
- For open networks with no passphrase, attempts to activate a known connection profile before falling back to the standard connection method
- Maintains backward compatibility by falling back to the existing
wifiConnectmethod for all other scenarios
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { | ||
| if(wifi->wifiConnect(ssid)) | ||
| rc = Core::ERROR_NONE; | ||
| if(ssid.passphrase.empty() && (ssid.security == Exchange::INetworkManager::WIFI_SECURITY_NONE)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If WIFIConnect() is called for the first time but to connect to Open SSID (un-secure SSID) this API will fail as there is nothing to activate.
So, first we have to check whether the given SSID is in active connection list and then call for activate.
|
Please use proper RDK/RDKEMW ticket in the title and the give details in the description on what the change is all about for readability/awareness |
No description provided.