Skip to content

gh #358 signalEOS() description update #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hari22yuva wants to merge 6 commits into
base: develop
Choose a base branch
from
+15 −6
Open

gh #358 signalEOS() description update #359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f7998dd
gh #358 signalEOS() description update
hari22yuva Mar 19, 2026
d5e2847
Apply suggestions from code review
Ulrond Mar 19, 2026
a22f4cf
gh #358 Updated EOS metadata information in framemetadata
Anbukannadhasan Apr 9, 2026
50ddfcf
gh #258 added EOS-only callback details in the spec
Anbukannadhasan Apr 9, 2026
d93c3c7
gh #358 corrected the review points
Anbukannadhasan Apr 9, 2026
08b1b55
gh #358 Corrected review comments
Anbukannadhasan Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions audiodecoder/current/com/rdk/hal/audiodecoder/FrameMetadata.aidl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ parcelable FrameMetadata {
* The buffer contains Dolby Atmos audio and metadata.
*/
boolean isDolbyAtmos;

/**
* Audio trimming to use on presentation.
*/
Expand All @@ -59,7 +59,10 @@ parcelable FrameMetadata {
boolean lowLatency;

/**
* End of stream indicator.
* End of stream flag for decoder output.
* Set to true on the final frame output callback after IAudioDecoderController.signalEOS() has been invoked, once all queued frames have been output.
* On an EOS-only callback (where the frame buffer handle is invalid), only this field is guaranteed to be meaningful.
* All other metadata fields are undefined and must not be interpreted by the client on such a callback.
*/
boolean endOfStream;

Expand Down
5 changes: 3 additions & 2 deletions audiodecoder/current/com/rdk/hal/audiodecoder/IAudioDecoderController.aidl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ interface IAudioDecoderController {
*
* @returns boolean
* @retval true Buffer successfully queued for decoding. Buffer ownership transfers to HAL.
* @retval false Internal decode buffer queue is full. Buffer ownership remains with caller.
* @retval false Internal decode buffer queue is full or signalEOS is called. Buffer ownership remains with caller.
*
* @exception binder::Status::Exception::EX_NONE for success
* @exception binder::Status::Exception::EX_ILLEGAL_STATE
Expand Down Expand Up @@ -156,7 +156,8 @@ interface IAudioDecoderController {
* The audio decoder must be in a state of `STARTED`.
* Any frames held by the decoder should continue to be decoded and output.
* No more audio buffers are expected to be delivered to the audio decoder after
* `signalEOS()` has been called unless the decoder is first flushed or stopped and started again.
* `signalEOS()` has been called unless the decoder is first flushed or stopped and started again.
* Any subsequent `decodeBuffer()` call in this state shall return false.
*
* An `IAudioDecoderControllerListener.onFrameOutput()` callback with `FrameMetadata.endOfStream`
* must be set to true after all audio frames have been output.
Expand Down
6 changes: 5 additions & 1 deletion videodecoder/current/com/rdk/hal/videodecoder/FrameMetadata.aidl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,11 @@ parcelable FrameMetadata {
int frameRateDenominator;

/**
* End of stream marker found in the video bitstream.
* End of stream flag for decoder output.
* Set to true on the onFrameOutput() callback when an EOS marker is detected in the video bitstream; the frame buffer handle is valid and all metadata fields are meaningful.
* Set to true on the final frame output callback after IVideoDecoderController.signalEOS(), once all queued frames have been output.
* On an EOS-only callback (where the frame buffer handle is invalid), only this field is guaranteed to be meaningful.
* All other metadata fields are undefined and must not be interpreted by the client on such a callback.
*/
boolean endOfStream;

Expand Down
3 changes: 2 additions & 1 deletion videodecoder/current/com/rdk/hal/videodecoder/IVideoDecoderController.aidl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ interface IVideoDecoderController
*
* @returns boolean
* @retval true Buffer successfully queued for decoding. Buffer ownership transfers to HAL.
* @retval false Internal decode buffer queue is full. Buffer ownership remains with caller.
* @retval false Internal decode buffer queue is full or signalEOS is called. Buffer ownership remains with caller.
*
* @exception binder::Status::Exception::EX_NONE for success
* @exception binder::Status::Exception::EX_ILLEGAL_STATE
Expand Down Expand Up @@ -158,6 +158,7 @@ interface IVideoDecoderController
*
* No more AV buffers are expected to be delivered to the Video Decoder after
* `signalEOS()` has been called unless the decoder is first flushed or stopped and started again.
* Any subsequent `decodeBuffer()` call in this state shall return false.
*
* An `IVideoDecoderControllerListener.onFrameOutput()` callback with `FrameMetadata.endOfStream`
* must be set to true after all video frames have been output.
Expand Down
Loading