Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates HDMI output listener documentation to remove app-specific references and clarify HPD behaviour, improving the neutrality and technical accuracy of the AIDL interface docs.
Changes:
- Generalised
onFrameRateChanged()documentation to reference OTT applications without naming specific apps. - Clarified
onHotPlugDetectStateChanged()documentation to include HPD deassertion caused by sink power-off (in addition to cable disconnect).
github-project-automation
bot
moved this from Review Requested
to Resolved
in halif_aidl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onFrameRateChanged()documentation, replaced with generic OTT languageonHotPlugDetectStateChanged()to note that HPD deassertion is triggered by both cable disconnect and sink power-offCloses #389
Origin: discussion #262 (points 5 and 7) by @thanushreevani