RDK-60795 : Added Cryptography plugin. (#6305)#6457
RDK-60795 : Added Cryptography plugin. (#6305)#6457sborushevsky wants to merge 1 commit intordkcentral:release/8.1_p1vfrom
Conversation
* RDK-57366 : Added Cryptography plugin. * Added VaultId(). Code cleanup. * Renamed plugin. * RDK-57366 : Used Svalbard plugin sources from R4_4 branch. * Added changelog.
sborushevsky
changed the title
There was a problem hiding this comment.
Pull request overview
This pull request adds a new Cryptography plugin to RDKServices, providing external access to cryptography functionality through an RPC interface. The plugin acts as a bridge between the WPEFramework plugin system and the underlying cryptography implementation.
Changes:
- Added new CryptographyExtAccess plugin with RPC communication support
- Integrated plugin into the main CMakeLists.txt build system
- Created initial CHANGELOG and README documentation
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| Cryptography/README.md | Minimal documentation with basic build instructions |
| Cryptography/Module.h | Standard module header defining plugin name and includes |
| Cryptography/Module.cpp | Module implementation with name declaration |
| Cryptography/CryptographyRPC.cpp | RPC server implementation managing cryptography instance and external access |
| Cryptography/CryptographyExtAccess.h | Plugin header defining the main plugin class and notification handling |
| Cryptography/CryptographyExtAccess.cpp | Plugin implementation with initialization, deinitialization, and connection management |
| Cryptography/CryptographyExtAccess.config | Configuration template for plugin settings |
| Cryptography/CryptographyExtAccess.conf.in | Configuration file template with autostart and root object settings |
| Cryptography/CMakeLists.txt | Build configuration for the plugin |
| Cryptography/CHANGELOG.md | Initial changelog with version 1.0.0 entry |
| CMakeLists.txt | Integration of Cryptography plugin into main build system |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (_implementation == nullptr) { | ||
| message = _T("CryptographyExtAccess could not be instantiated."); | ||
| } else { | ||
| printf("CryptographyExtAccess - Connection Id - %u\n",_connectionId); |
There was a problem hiding this comment.
Using printf for debug/logging output is inconsistent with the codebase convention of using TRACE macros for logging. The codebase extensively uses TRACE(Trace::Information, ...) for informational logging. Replace these printf statements with appropriate TRACE calls for consistency with the rest of the codebase.
| if (_implementation != nullptr) { | ||
|
|
||
| RPC::IRemoteConnection* connection(_service->RemoteConnection(_connectionId)); | ||
| printf("CryptographyExtAccess - Remote Connection - %p\n",connection); |
There was a problem hiding this comment.
Using printf for debug/logging output is inconsistent with the codebase convention of using TRACE macros for logging. The codebase extensively uses TRACE(Trace::Information, ...) for informational logging. Replace this printf statement with an appropriate TRACE call for consistency with the rest of the codebase.
| find_package(${NAMESPACE}Definitions REQUIRED) | ||
|
|
There was a problem hiding this comment.
The WPEFrameworkDefinitions package is found twice (lines 40 and 44), which is redundant. Remove one of the duplicate find_package calls to avoid confusion and follow the DRY principle.
| find_package(${NAMESPACE}Definitions REQUIRED) |
1 participant
RDK-57366 : Added Cryptography plugin.
Added VaultId(). Code cleanup.
Renamed plugin.
RDK-57366 : Used Svalbard plugin sources from R4_4 branch.
Added changelog.