Skip to content

Conversation

aktamilbe
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Aug 8, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.



/**
* @brief Structure defining the Gamma Whitbelance min,max and matrix points
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitbelance -> Whitebalance

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

* @param[out] num_ui_matrix_points - The number of points in the UI gamma matrix for customer adjustment.
* @param[out] ui_matrix_positions - An array of positions for the UI matrix points.
* Points to an array with `num_ui_matrix_points` elements with values between 0.0 and 1.0.
* @param[out] multiPointMatrix - Returns a pointer to an structure which contains values associated with MutiPoint WhiteBalance
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mutipoint -> Multipoint

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link

@8855345 8855345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few line comments left, seems ok otherwise.

8855345
8855345 previously approved these changes Aug 22, 2025
Copy link

@outdooruseonly outdooruseonly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made my points offline.
Summary.
We need to move HLA for multipoint white balance to the interface md doc.
I don't think the API function headers should reference the json caps file. It should be mentioned how it should be used in the md interface doc.
The Interface md doc should reflect the header file. It is key to understanding the interface and should be accurate.

I will approve but please address my points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants