-
Notifications
You must be signed in to change notification settings - Fork 7
gh #89 Add GetDefaultMultiPointWBMatrix #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
include/tvTypes.h
Outdated
|
||
|
||
/** | ||
* @brief Structure defining the Gamma Whitbelance min,max and matrix points |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whitbelance -> Whitebalance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
include/tvSettings.h
Outdated
* @param[out] num_ui_matrix_points - The number of points in the UI gamma matrix for customer adjustment. | ||
* @param[out] ui_matrix_positions - An array of positions for the UI matrix points. | ||
* Points to an array with `num_ui_matrix_points` elements with values between 0.0 and 1.0. | ||
* @param[out] multiPointMatrix - Returns a pointer to an structure which contains values associated with MutiPoint WhiteBalance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mutipoint -> Multipoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few line comments left, seems ok otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made my points offline.
Summary.
We need to move HLA for multipoint white balance to the interface md doc.
I don't think the API function headers should reference the json caps file. It should be mentioned how it should be used in the md interface doc.
The Interface md doc should reflect the header file. It is key to understanding the interface and should be accurate.
I will approve but please address my points.
No description provided.