TDK-11400: MVS - Dynamic URL Loading from PersistentStore & Framework Changes for AppManager Including Test Script Changes#102
Open
asuresh977 wants to merge 1 commit intodevelopfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for dynamically loading the Lightning app URL from org.rdk.PersistentStore (key MVS:lightningURL) to enable RDK8 flows where the Lightning URL is persisted and then used at app startup.
Changes:
- Added a PersistentStore write helper in the RDKV media library to set
MVS:lightningURLvia JSON-RPC. - Updated UnifiedPlayer Lightning entrypoint to read
MVS:lightningURLfrom PersistentStore (via ThunderJS) and redirect to it when valid. - Updated media test prerequisites to ensure
org.rdk.PersistentStoreis activated before launching WebKit.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| framework/fileStore/rdkv_medialib.py | Adds helper intended to set MVS:lightningURL in PersistentStore via JSON-RPC. |
| framework/fileStore/lightning-apps/unifiedplayer/src/index.js | Reads MVS:lightningURL from PersistentStore at startup and redirects to the formatted URL. |
| framework/fileStore/MediaValidationUtility.py | Activates PersistentStore plugin as part of media test prerequisites. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
asuresh977
force-pushed
the
feature/TDK-11400-Dynamic-Lightning-URL-Load-From-PS
branch
from
d8009d0 to
5cff47b
Compare
asuresh977
force-pushed
the
feature/TDK-11400-Dynamic-Lightning-URL-Load-From-PS
branch
from
5cff47b to
cf07c03
Compare
asuresh977
changed the title
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Changes [Sprint-M146] Reason for change: Added new lightning app & html player app implementation to fetch the URL from the PersistentStore and MVS framework changes based on new AppManager methods for RDK8 Test Procedure: Verify with TDK TM Risks: None Signed-off-by: Aromal Suresh <aromal_suresh@comcast.com>
asuresh977
force-pushed
the
feature/TDK-11400-Dynamic-Lightning-URL-Load-From-PS
branch
from
cf07c03 to
0f471be
Compare
asuresh977
changed the title
Contributor
Contributor
|
b'## WARNING: A Blackduck scan failure has been waived A prior failure has been upvoted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TDK-11400: MVS - Dynamic Lightning App URL Loading from PersistentStore [Sprint-M146]
Reason for change: Added new lightning app implementation to fetch the lightning URL from the PersistentStore for RDK8
Test Procedure: Verify with TDK TM
Risks: None