Open
Conversation
sahithya50
requested changes
Mar 25, 2026
framework/fileStore/testscriptsRDKV/component/rdkservices/RDKV_CERT_AVS_AppManager.py
Show resolved
Hide resolved
framework/fileStore/tdkvRDKServiceXMLs/AppManagerPlugin_TestCases.xml
Outdated
Show resolved
Hide resolved
framework/fileStore/tdkvRDKServiceXMLs/AppManagerPlugin_TestCases.xml
Outdated
Show resolved
Hide resolved
framework/fileStore/tdkvRDKServiceXMLs/AppManagerPlugin_TestCases.xml
Outdated
Show resolved
Hide resolved
framework/fileStore/tdkvRDKServiceXMLs/AppManagerPlugin_TestCases.xml
Outdated
Show resolved
Hide resolved
framework/fileStore/tdkvRDKServiceXMLs/AppManagerPlugin_TestCases.xml
Outdated
Show resolved
Hide resolved
framework/fileStore/tdkvRDKServiceXMLs/AppManagerPlugin_TestCases.xml
Outdated
Show resolved
Hide resolved
framework/fileStore/tdkvRDKServiceXMLs/AppManagerPlugin_TestCases.xml
Outdated
Show resolved
Hide resolved
sahithya50
requested changes
Mar 27, 2026
| <param tag="packageId" useConfigFile="true" key="PACKAGEMANAGER_APPLICATION_NAME"/> | ||
| <param tag="version" useConfigFile="true" key="PACKAGEMANAGER_APPLICATION_VERSION"/> | ||
| <param tag="fileLocator" usePreviousResult="true" Id="4" useMethodTag="downloadmanager_get_previous_filelocator_url"/> | ||
| <param tag="name" useConfigFile="true" key="PACKAGEMANAGER_ADDITIONALMETADATA_NAME"/> |
Contributor
There was a problem hiding this comment.
Additional Metadata name and value are not mandatory during install, can be removed?
| <param tag="version" useConfigFile="true" key="PACKAGEMANAGER_APPLICATION_VERSION"/> | ||
| <param tag="fileLocator" usePreviousResult="true" Id="4" useMethodTag="downloadmanager_get_previous_filelocator_url"/> | ||
| <param tag="name" useConfigFile="true" key="PACKAGEMANAGER_ADDITIONALMETADATA_NAME"/> | ||
| <param tag="value" useConfigFile="true" key="PACKAGEMANAGER_ADDITIONALMETADATA_VALUE"/> |
Contributor
There was a problem hiding this comment.
Missing "_" in the key value name - "PACKAGEMANAGER_ADDITIONALMETADATA_VALUE"
| <param tag="appId" useConfigFile="true" key="PACKAGEMANAGER_APPLICATION_NAME"/> | ||
| <param tag="launchArgs" value=""/> | ||
| </params> | ||
| <resultGeneration useMethodTag="appmanager_negative_scenario_validation" expectedValues="Invalid Parameter"/> |
Contributor
There was a problem hiding this comment.
launchArgs is an optional parameter, this scenario will not be negative scenario validation
| </testCase> | ||
|
|
||
| <!-- TestCases 18 --> | ||
| <testCase testCaseId="AM_18" testCaseName="AppManager_LaunchApp_Fail_Gracefully_Empty_Intent" desc="Verify that the launchApp method fails gracefully when the intent parameter is empty, while appId and launchArgs are provided"> |
Contributor
There was a problem hiding this comment.
Passing empty intent will not become negative scenario, revisit the scenario.
| </testCase> | ||
|
|
||
| <!-- TestCases 19 --> | ||
| <testCase testCaseId="AM_19" testCaseName="AppManager_LaunchApp_Fail_Gracefully_Empty_LaunchArgs" desc="Verify that the launchApp method fails gracefully when the launchArgs parameter is empty, while appId and intent are provided"> |
Contributor
There was a problem hiding this comment.
Passing empty launchArgs will not become negative scenario, , as it is optional parameter. Revisit the scenario.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.