Conversation
Reason for change: Testing purpose Test Procedure: There should not be crash and regression issues Risks: Medium Priority: P0 Signed-off-by: PriyaDharshini_Kathiravan <priyakathiravan05@gmail.com>
Reason for change: Testing purpose Test Procedure: There should not be crash and regression issues Risks: Medium Priority: P0 Signed-off-by: PriyaDharshini_Kathiravan <priyakathiravan05@gmail.com>
Reason for change: Testing purpose Test Procedure: There should not be crash and regression issues Risks: Medium Priority: P0 Signed-off-by: PriyaDharshini_Kathiravan <priyakathiravan05@gmail.com>
| return NULL; | ||
| } | ||
| T2Debug("Checking for events in event queue , event count = %d\n", t2_queue_count(eQueue)); | ||
| if(t2_queue_count(eQueue) > 0) |
There was a problem hiding this comment.
Coverity issue no longer present as of: undefined
Show issue
Coverity Issue - Double unlock
"pthread_mutex_unlock" unlocks "sTDMutex" while it is unlocked.
Medium Impact, CWE-765
LOCK
| ret = pthread_cond_signal(&erCond); | ||
| if(ret != 0) // pthread_cond _signal failed so after unlocking the mutex it will return | ||
| { | ||
| T2Error("%s pthread_cond_signal for erCond failed with error code : %d\n", __FUNCTION__, ret); |
There was a problem hiding this comment.
Coverity issue no longer present as of: undefined
Show issue
Coverity Issue - Thread deadlock
Calling "pthread_mutex_lock" acquires lock "sTDMutex" while holding lock "erMutex" (count: 1 / 2).
Medium Impact, CWE-833
ORDER_REVERSAL
shibu-kv
left a comment
shibu-kv
left a comment
There was a problem hiding this comment.
In general please do address coverity defects.
| { | ||
| T2Debug("Calling rbus_getExt for %s \n", paramNames[0]); | ||
| if(RBUS_ERROR_SUCCESS != rbus_getExt(t2bus_handle, 1, (const char**)paramNames, ¶mValCount, &rbusPropertyValues)) | ||
| int retries = 0; |
There was a problem hiding this comment.
We shouldn't do retries for timeouts. Timeouts can be for legit cases as well.
|
|
||
|
|
||
| void publishReportUploadStatus(char* status) | ||
| void publishReportUploadStatus(char* status) //needs revisit |
There was a problem hiding this comment.
This is a tricky handling and would need some refactoring. For the time being keep a local copy of data in the function an release once done.
Reason for change: Testing purpose Test Procedure: There should not be crash and regression issues Risks: Medium Priority: P0 Signed-off-by: PriyaDharshini_Kathiravan <priyakathiravan05@gmail.com>
…elemetry into topic/kp-RDKB-59901
| pthread_mutex_unlock(&erMutex); | ||
| if(pthread_mutex_unlock(&erMutex) != 0) | ||
| { | ||
| T2Error("%s pthread_mutex_unlock for erMutex failed\n", __FUNCTION__); |
There was a problem hiding this comment.
Coverity Issue - Double unlock
"pthread_mutex_unlock" unlocks "sTDMutex" while it is unlocked.
Medium Impact, CWE-765
LOCK
| @@ -110,7 +129,11 @@ void T2ER_PushDataWithDelim(char* eventInfo, char* user_data) | |||
| { | |||
| T2Error("Missing delimiter in the event received\n"); | |||
| } | |||
There was a problem hiding this comment.
Coverity Issue - Double unlock
"pthread_mutex_unlock" unlocks "sTDMutex" while it is unlocked.
Medium Impact, CWE-765
LOCK
3 participants
No description provided.