RDKCOM-5439: TELEMTERY-24 Add "REPORT_TYPE":"CACHED" to cache reports#154
RDKCOM-5439: TELEMTERY-24 Add "REPORT_TYPE":"CACHED" to cache reports#154shibu-kv merged 2 commits intordkcentral:developfrom
Conversation
Coverity Issue - Data race conditionAccessing "profile->grepSeekProfile->execCounter" without holding lock "plMutex". Elsewhere, "_GrepSeekProfile.execCounter" is written to with "plMutex" held 2 out of 2 times. Medium Impact, CWE-366 Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
Coverity Issue - Check of thread-shared field evades lock acquisitionThread1 sets "initialized" to a new value. Now the two threads have an inconsistent view of "initialized" and updates to fields correlated with "initialized" may be lost. High Impact, CWE-543 How to fixGuard the modification of "initialized" and the read used to decide whether to modify "initialized" with the same set of locks. Issue locationThis issue was discovered outside the diff for this Pull Request. You can find it at: |
shibu-kv
left a comment
There was a problem hiding this comment.
Changes looks good.
To have uniform coding format for readability and maintainability, telemetry project now enforces a uniform formatter based on utility style.
Could you please format this contribution by running below commands :
find . -name '*.c' -o -name '*.h' | xargs astyle --options=.astylerc find . -name '*.orig' -type f -delete
To apply formatting . Formater configs are already on the project - https://github.com/rdkcentral/telemetry/blob/develop/.astylerc
|
Hi @saikiran |
Hi @pradeeptakdas , I have signed CLA through username as vsai1990. |
Its still showing CLA is not signed for your github handle Saikiran. |
[Description] To differentiate between normal and cached reports, set "REPORT_TYPE": "CACHED" for cached reports. This makes it clear in the report that it's a cached one. [Solution] Modified the logic to include "REPORT_TYPE":"CACHED" in cached reports. [Testing] Verified that cached reports now include "REPORT_TYPE":"CACHED".
[Description]
To differentiate between normal and cached reports, set "REPORT_TYPE": "CACHED" for cached reports. This makes it clear in the report that it's a cached one.
[Solution]
Modified the logic to include "REPORT_TYPE":"CACHED" in cached reports.
[Testing]
Verified that cached reports now include "REPORT_TYPE":"CACHED".