Skip to content

RDKCOM-5439: TELEMTERY-24 Add "REPORT_TYPE":"CACHED" to cache reports#154

Merged
shibu-kv merged 2 commits intordkcentral:developfrom
vsai1990:develop
Oct 20, 2025
Merged

RDKCOM-5439: TELEMTERY-24 Add "REPORT_TYPE":"CACHED" to cache reports#154
shibu-kv merged 2 commits intordkcentral:developfrom
vsai1990:develop

Conversation

@vsai1990
Copy link
Contributor

[Description]
To differentiate between normal and cached reports, set "REPORT_TYPE": "CACHED" for cached reports. This makes it clear in the report that it's a cached one. 

[Solution]
Modified the logic to include "REPORT_TYPE":"CACHED" in cached reports.

[Testing]
Verified that cached reports now include "REPORT_TYPE":"CACHED".

@vsai1990 vsai1990 requested a review from a team August 22, 2025 15:08
@CLAassistant
Copy link

CLAassistant commented Aug 22, 2025

CLA assistant check
All committers have signed the CLA.

@rdkcmf-jenkins
Copy link
Contributor

Coverity Issue - Data race condition

Accessing "profile->grepSeekProfile->execCounter" without holding lock "plMutex". Elsewhere, "_GrepSeekProfile.execCounter" is written to with "plMutex" held 2 out of 2 times.

Medium Impact, CWE-366
MISSING_LOCK

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
source/bulkdata/profile.c:339

@rdkcmf-jenkins
Copy link
Contributor

rdkcmf-jenkins commented Aug 22, 2025

Coverity Issue - Check of thread-shared field evades lock acquisition

Thread1 sets "initialized" to a new value. Now the two threads have an inconsistent view of "initialized" and updates to fields correlated with "initialized" may be lost.

High Impact, CWE-543
LOCK_EVASION

How to fix

Guard the modification of "initialized" and the read used to decide whether to modify "initialized" with the same set of locks.

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
source/bulkdata/profilexconf.c:736

Copy link
Contributor

@shibu-kv shibu-kv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.
To have uniform coding format for readability and maintainability, telemetry project now enforces a uniform formatter based on utility style.
Could you please format this contribution by running below commands :

find . -name '*.c' -o -name '*.h' | xargs astyle --options=.astylerc find . -name '*.orig' -type f -delete

To apply formatting . Formater configs are already on the project - https://github.com/rdkcentral/telemetry/blob/develop/.astylerc

@pradeeptakdas
Copy link

pradeeptakdas commented Sep 23, 2025

Hi @saikiran
Can you please Sign the CLA?

@vsai1990
Copy link
Contributor Author

Hi @saikiran Can you please Sign the CLA?

Hi @pradeeptakdas , I have signed CLA through username as vsai1990.

@pradeeptakdas pradeeptakdas changed the title TELEMTERY-24 Add "REPORT_TYPE":"CACHED" to cache reports RDKCOM-5439: TELEMTERY-24 Add "REPORT_TYPE":"CACHED" to cache reports Sep 24, 2025
@pradeeptakdas
Copy link

Hi @saikiran Can you please Sign the CLA?

Hi @pradeeptakdas , I have signed CLA through username as vsai1990.

Hi @saikiran Can you please Sign the CLA?

Hi @pradeeptakdas , I have signed CLA through username as vsai1990.

Its still showing CLA is not signed for your github handle Saikiran.
Please login to github using your github handle Saikiran and Sign the CLA.
https://cla-assistant.io/rdkcentral/telemetry?pullRequest=154

[Description]
To differentiate between normal and cached reports, set "REPORT_TYPE": "CACHED" for cached reports.
This makes it clear in the report that it's a cached one. 

[Solution]
Modified the logic to include "REPORT_TYPE":"CACHED" in cached reports.

[Testing]
Verified that cached reports now include "REPORT_TYPE":"CACHED".
@shibu-kv shibu-kv merged commit 4d5253b into rdkcentral:develop Oct 20, 2025
4 of 5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants