ISSUE-76 : Fix race condition during aggressive reloads#189
Merged
ISSUE-76 : Fix race condition during aggressive reloads#189
Conversation
Reason for Change: moving reportThread out of profilexconf structure and making it static in the file, this helps in reuse without depending on profilexconf structure Test Procedure: Aggressively simulate report uploads and verify that no crashes occur. Risks: Medium Priority: P1
shibu-kv
previously approved these changes
Oct 16, 2025
| @@ -727,17 +731,7 @@ T2ERROR ProfileXConf_delete(ProfileXConf *profile) | |||
|
|
|||
| if(singleProfile->reportInProgress) | |||
| { | |||
Contributor
There was a problem hiding this comment.
Coverity issue no longer present as of: undefined
Show issue
Coverity Issue - Data race condition
Accessing "reportThread" without holding lock "plMutex". Elsewhere, "reportThread" is written to with "plMutex" held 1 out of 1 times.
Medium Impact, CWE-366
MISSING_LOCK
shibu-kv
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change: moving reportThread out of profilexconf structure and making it static in the file, this helps in reuse without depending on profilexconf structure
Test Procedure: Aggressively simulate report uploads and verify that no crashes occur.
Risks: Medium
Priority: P1