Skip to content

RDKB-62330 : Selfheal to recover devices when subdoc version mismatch #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ksures101 wants to merge 1 commit into from
+596 −1
Closed

RDKB-62330 : Selfheal to recover devices when subdoc version mismatch #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/TandDSsp/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ CcspTandDSsp_CPPFLAGS += -I$(top_srcdir)/source/DevicePrioritization/TR-181
CcspTandDSsp_CFLAGS = $(DEVICE_PRIORITIZATION_CFLAGS)
endif

CcspTandDSsp_SOURCES = tad_rbus_apis.c ssp_messagebus_interface.c ssp_action_priv.c ssp_main.c ssp_action.c ssp_messagebus_interface_priv.c dm_pack_datamodel.c current_time.c
CcspTandDSsp_SOURCES = tad_rbus_apis.c ssp_messagebus_interface.c ssp_action_priv.c ssp_main.c ssp_action.c ssp_messagebus_interface_priv.c dm_pack_datamodel.c current_time.c webcfg_selfheal.c
CcspTandDSsp_LDFLAGS = -lccsp_common -ldl -rdynamic -lrbus -lsyscfg -lsecure_wrapper -ltelemetry_msgsender
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new webcfg_selfheal.c file uses cJSON library functions (cJSON_Parse, cJSON_Delete, cJSON_GetObjectItemCaseSensitive, etc.) but the Makefile.am does not include -lcjson in the LDFLAGS. This will likely cause linker errors unless cJSON is already implicitly linked through another dependency. The LDFLAGS should explicitly include -lcjson.

Suggested change
CcspTandDSsp_LDFLAGS = -lccsp_common -ldl -rdynamic -lrbus -lsyscfg -lsecure_wrapper -ltelemetry_msgsender
CcspTandDSsp_LDFLAGS = -lccsp_common -ldl -rdynamic -lrbus -lsyscfg -lsecure_wrapper -ltelemetry_msgsender -lcjson

Copilot uses AI. Check for mistakes.

CcspTandDSsp_DEPENDENCIES = ${top_builddir}/source/LatencyMeasurement/TR-181/libLowLatency.la \
Expand Down
9 changes: 9 additions & 0 deletions source/TandDSsp/ssp_main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
#include "tad_rbus_apis.h"
#include "lowlatency_apis.h"
#include "current_time.h"
#include "webcfg_selfheal.h"
#include <telemetry_busmessage_sender.h>

#ifdef DEVICE_PRIORITIZATION_ENABLED
Expand Down Expand Up @@ -367,6 +368,14 @@ int main(int argc, char* argv[])

// Init LatencyMeasurent
LatencyMeasurementInit();

// SelfHeal Subdoc Version Mismatch
initWebcfgProperties(WEBCFG_PROPERTIES_FILE);
int webcfg_ret = webcfg_subdoc_mismatch_boot_check();
if (webcfg_ret != 0)
{
fprintf(stderr, "Error: webcfg_subdoc_mismatch_boot_check failed during initialization (ret=%d)\n", webcfg_ret);
}
Comment on lines +374 to +378
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function webcfg_subdoc_mismatch_boot_check is declared with a void return type in the header file, but the calling code in ssp_main.c is attempting to capture and check a return value. The function should either be changed to return an int status, or the calling code should not expect a return value.

Copilot uses AI. Check for mistakes.
Comment on lines +371 to +378
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation detected. The code uses tabs instead of spaces. The lines should be consistently indented with either tabs or spaces according to the project's coding style.

Copilot uses AI. Check for mistakes.

//crate a thread to update time thread for ethwan enable mode
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error in comment: "crate" should be "create".

Suggested change
//crate a thread to update time thread for ethwan enable mode
//create a thread to update time thread for ethwan enable mode

Copilot uses AI. Check for mistakes.
BOOL ethwanEnabled = FALSE;
Expand Down
Loading
Loading