Skip to content

RDKCOM-5522: RDKBDEV-3369 Fix TR069 repeat M Reboot in ACS reboot long run#13

Open
owen-lu-sercomm wants to merge 4 commits intordkcentral:developfrom
owen-lu-sercomm:RDKBDEV-3369
Open

RDKCOM-5522: RDKBDEV-3369 Fix TR069 repeat M Reboot in ACS reboot long run#13
owen-lu-sercomm wants to merge 4 commits intordkcentral:developfrom
owen-lu-sercomm:RDKBDEV-3369

Conversation

@owen-lu-sercomm
Copy link
Contributor

@owen-lu-sercomm owen-lu-sercomm commented Feb 9, 2026

Reason for change:
Sometimes TR069 sends repeat M Reboot in ACS reboot longrun
Test Procedure:

  1. connect to acs
  2. do reboot when ACS receive "1 Boot + M Reboot"
  3. check CPE send inform with only one M Reboot + 1 Boot

Risks: Low

@owen-lu-sercomm owen-lu-sercomm requested review from a team as code owners February 9, 2026 07:14
@pradeeptakdas pradeeptakdas changed the title RDKBDEV-3369:Fix TR069 repeat M Reboot in ACS reboot long run RDKCOM-5522: RDKBDEV-3369 Fix TR069 repeat M Reboot in ACS reboot long run Feb 9, 2026
@owen-lu-sercomm @tinaelizabeth84
RDKBDEV-3369:Fix TR069 repeat M Reboot in ACS reboot long run
7cf1012 
Reason for change:
Sometimes TR069 sends repeat M Reboot in ACS reboot longrun
Test Procedure:
1. connect to acs
2. do reboot when ACS receive "1 Boot + M Reboot"
3. check CPE send inform with only one M Reboot + 1 Boot
Risks: Low

Signed-off-by: Owen Lu <owen_lu@sercomm.com>
apattu200
apattu200 previously approved these changes Feb 24, 2026
View reviewed changes
rdkcmf-jenkins
rdkcmf-jenkins reviewed Feb 24, 2026
View reviewed changes
source-embedded/CcspCwmpSession/ccsp_cwmp_sesso_management.c Outdated
if((rc == EOK) && (!ind))
{
if((!pCcspCwmpEvent->CommandKey && !pCcspCwmpEventExist->CommandKey))
if((!pCcspCwmpEvent->CommandKey && !pCcspCwmpEventExist->CommandKey) ||
Copy link
Contributor

@rdkcmf-jenkins rdkcmf-jenkins Feb 24, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Dereference after null check

Passing null pointer "pCcspCwmpEvent->CommandKey" to "strlen", which dereferences it.

Medium Impact, CWE-476
FORWARD_NULL

pradeeptakdas
pradeeptakdas previously approved these changes Feb 25, 2026
View reviewed changes
Copy link

@pradeeptakdas pradeeptakdas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alagupandi have approved the changes and he suggested to merge after all check passed

@pradeeptakdas
Copy link

pradeeptakdas commented Feb 25, 2026

Hi @owen-lu-sercomm
Can you please fix the coverity issue?

Coverity Issue - Dereference after null check
Passing null pointer "pCcspCwmpEvent->CommandKey" to "strlen", which dereferences it.

Medium Impact, CWE-476
FORWARD_NULL

@owen-lu-sercomm
RDKBDEV-3369:Fix TR069 repeat M Reboot in ACS reboot long run
9fc463b 
Reason for change:
Fix the coverity issue in the commit for RDKBDEV-3369

Signed-off-by: Owen Lu <owen_lu@sercomm.com>
@owen-lu-sercomm owen-lu-sercomm dismissed stale reviews from pradeeptakdas and apattu200 via 9fc463b March 9, 2026 02:11
rdkcmf-jenkins
rdkcmf-jenkins reviewed Mar 9, 2026
View reviewed changes
source-embedded/CcspCwmpSession/ccsp_cwmp_sesso_management.c Outdated
if((rc == EOK) && (!ind))
{
if((!pCcspCwmpEvent->CommandKey && !pCcspCwmpEventExist->CommandKey))
if((!pCcspCwmpEvent->CommandKey && !pCcspCwmpEventExist->CommandKey) &&
Copy link
Contributor

@rdkcmf-jenkins rdkcmf-jenkins Mar 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Dereference after null check

Passing null pointer "pCcspCwmpEventExist->CommandKey" to "strlen", which dereferences it.

Medium Impact, CWE-476
FORWARD_NULL

source-embedded/CcspCwmpSession/ccsp_cwmp_sesso_management.c Outdated
if((rc == EOK) && (!ind))
{
if((!pCcspCwmpEvent->CommandKey && !pCcspCwmpEventExist->CommandKey))
if((!pCcspCwmpEvent->CommandKey && !pCcspCwmpEventExist->CommandKey) &&
Copy link
Contributor

@rdkcmf-jenkins rdkcmf-jenkins Mar 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Dereference after null check

Passing null pointer "pCcspCwmpEvent->CommandKey" to "strlen", which dereferences it.

Medium Impact, CWE-476
FORWARD_NULL

Copy link

@tinaelizabeth84 tinaelizabeth84 Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@owen-lu-sercomm Can you fix the merge conflict please?

@owen-lu-sercomm
RDKBDEV-3369:Fix TR069 repeat M Reboot in ACS reboot long run
f4ccdc5 
Reason for change:
Fix the coverity issue in the commit for RDKBDEV-3369

Signed-off-by: Owen Lu <owen_lu@sercomm.com>
@AkhilaReddyK7 AkhilaReddyK7 added the community-contribution Contribution from community label Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdkcmf-jenkins rdkcmf-jenkins rdkcmf-jenkins left review comments

@tinaelizabeth84 tinaelizabeth84 tinaelizabeth84 left review comments

@pradeeptakdas pradeeptakdas pradeeptakdas left review comments

@apattu200 apattu200 apattu200 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

community-contribution Contribution from community

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@owen-lu-sercomm @pradeeptakdas @rdkcmf-jenkins @tinaelizabeth84 @apattu200 @AkhilaReddyK7